Skip to content

Conversation

@fabiocos
Copy link
Contributor

PR description:

Trivial fix of the module phi definition used in test, now useful for fast monitoring of ordering (using degrees). USed for the development of test beam geometry.
The reference file used in unit test must be updated accordingly.

PR validation:

The values are consistent with the ideal geometry definition for crystals.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 28, 2026

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabiocos for master.

It involves the following packages:

  • Geometry/MTDGeometryBuilder (geometry)

@Dr15Jones, @bsunanda, @civanch, @cmsbuild, @kpedro88, @makortel, @mdhildreth can you please review it and eventually sign? Thanks.
@bsunanda, @martinamalberti this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

please test with cms-data/Geometry-TestReference#23

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d283a/50953/summary.html
COMMIT: b72666c
CMSSW: CMSSW_16_1_X_2026-01-27-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49956/50953/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d283a/50953/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d283a/50953/git-merge-result

Comparison Summary

Summary:

  • You potentially added 7 lines to the logs
  • Reco comparison results: 1 differences found in the comparisons
  • DQMHistoTests: Total files compared: 52
  • DQMHistoTests: Total histograms compared: 4025536
  • DQMHistoTests: Total failures: 46
  • DQMHistoTests: Total nulls: 3
  • DQMHistoTests: Total successes: 4025467
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 22123.097 KiB( 51 files compared)
  • DQMHistoSizes: changed ( 18434.0,... ): 2794.853 KiB HLT/Vertexing
  • DQMHistoSizes: changed ( 18434.0,... ): 0.004 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 18434.0,... ): 0.004 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 34434.0,... ): 3306.669 KiB HLT/Vertexing
  • Checked 222 log files, 193 edm output root files, 52 DQM output files
  • TriggerResults: found differences in 7 / 50 workflows

@bsunanda
Copy link
Contributor

+geometry

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-data/Geometry-TestReference#23

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ecb30c3 into cms-sw:master Jan 28, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants