-
Notifications
You must be signed in to change notification settings - Fork 4.6k
MTD geometry: fix phi printout in geometry test #49956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49956/47731 |
|
A new Pull Request was created by @fabiocos for master. It involves the following packages:
@Dr15Jones, @bsunanda, @civanch, @cmsbuild, @kpedro88, @makortel, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test with cms-data/Geometry-TestReference#23 |
|
+1 Size: This PR adds an extra 24KB to repository The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
|
+geometry |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
Trivial fix of the module phi definition used in test, now useful for fast monitoring of ordering (using degrees). USed for the development of test beam geometry.
The reference file used in unit test must be updated accordingly.
PR validation:
The values are consistent with the ideal geometry definition for crystals.