Remove legacy CUDA ECAL code

[thomreis]

PR description:

This PR removed all legacy CUDA ECAL modules and the corresponding data formats.

• Unpacker
• Uncalibrated RecHit producer (Multifit)
• Uncalibrated RecHit producer Phase 2 (Weights method)
• RecHit producer
• Corresponding ES producers
• Corresponding CPU to GPU and vice-versa data format converters
• ECAL and Calo common CUDA data formats

PR validation:

Code compiles. Passes 34034.61, 34034.612, 12834.412

[cmsbuild]

cms-bot internal usage

[thomreis]

type ecal

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49872/47573

• There are other open Pull requests which might conflict with changes you have proposed:
  • File RecoLocalCalo/EcalRecProducers/test/testEcalRechitProducer_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
  • File RecoLocalCalo/EcalRecProducers/test/testEcalUncalibRecHitPhase2WeightsProducerGPU.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
  • File RecoLocalCalo/EcalRecProducers/test/testEcalUncalibRechitProducer_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076

[cmsbuild]

A new Pull Request was created by @thomreis for master.

It involves the following packages:

• CUDADataFormats/CaloCommon (heterogeneous, reconstruction)
• CUDADataFormats/EcalDigi (heterogeneous, reconstruction)
• CUDADataFormats/EcalRecHitSoA (heterogeneous, reconstruction)
• CondFormats/EcalObjects (alca, db)
• EventFilter/EcalRawToDigi (reconstruction)
• RecoLocalCalo/EcalRecProducers (reconstruction)

@Alejandro1400, @JanChyczynski, @Moanwar, @arunhep, @atpathak, @cmsbuild, @francescobrivio, @fwyzard, @jfernan2, @makortel, @mandrenguyen, @perrotta, @srimanob can you please review it and eventually sign? Thanks.
@JanChyczynski, @Martin-Grunewald, @PonIlya, @ReyerBand, @apsallid, @argiro, @denizsun, @missirol, @mmusich, @rchatter, @rovere, @rsreds, @salimcerci, @seemasharmafnal, @thomreis, @tocheng, @wang0jin, @yuanchao this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[thomreis]

enable gpu

[thomreis]

please test

[cmsbuild]

-1

Failed Tests: Build HeaderConsistency
Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2b0afb/50743/summary.html
COMMIT: b3fb1a3
CMSSW: CMSSW_16_1_X_2026-01-19-1100/el8_amd64_gcc13
Additional Tests: GPU,AMD_MI300X,AMD_W7900,NVIDIA_H100,NVIDIA_L40S,NVIDIA_T4
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49872/50743/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed Build

I found compilation error when building:

Copying tmp/el8_amd64_gcc13/src/RecoLocalCalo/EcalRecAlgos/src/RecoLocalCaloEcalRecAlgos/libRecoLocalCaloEcalRecAlgos.so to productstore area:
Leaving library rule at RecoLocalCalo/EcalRecAlgos
>> Compiling  src/RecoLocalCalo/EcalRecAlgos/bin/makeEcalMultifitResultsGpuValidationPlots.cpp
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02925/el8_amd64_gcc13/external/gcc/13.4.0-6908cfdf803923e783448096ca4f0923/bin/c++ -c -DCMS_MICRO_ARCH='x86-64-v3' -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=130400 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DBOOST_MPL_IGNORE_PARENTHESES_WARNING -DCMSSW_GIT_HASH='CMSSW_16_1_X_2026-01-19-1100' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_16_1_X_2026-01-19-1100' -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02925/el8_amd64_gcc13/cms/cmssw-patch/CMSSW_16_1_X_2026-01-19-1100/src -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02925/el8_amd64_gcc13/external/pcre/8.43-6d98fda3bfd074ebb583e2d6a2c75d25/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02925/el8_amd64_gcc13/external/boost/1.80.0-b819d3899535842b3b08dcd6a725af1a/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02925/el8_amd64_gcc13/external/bz2lib/1.0.6-d113e1c6278c07eeaff5f84db9548446/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02925/el8_amd64_gcc13/external/gsl/2.6-9011a41928244b609ca4c22c439b3fef/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02925/el8_amd64_gcc13/external/libuuid/2.34-5ba7a8abfc0c5fecdc448cca360c25ff/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02925/el8_amd64_gcc13/lcg/root/6.36.07-bd71f88d9cd20e5042c0ac03a7e23595/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02925/el8_amd64_gcc13/external/tbb/v2022.3.0-88eb7be4ee320d604a798a914aea6359/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02925/el8_amd64_gcc13/external/xz/5.6.4-b9c4ffbc390ed320a5d57fd552e29a05/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02925/el8_amd64_gcc13/external/zlib/1.2.13-589f6bb51bbeba38a7adf5a10ea8a093/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02925/el8_amd64_gcc13/external/alpaka/2.1.1-3caaac8d71f39d400ab2511b2403675a/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02925/el8_amd64_gcc13/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-95c02b8a883b2934decb8bb53ff9b486/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02925/el8_amd64_gcc13/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-95c02b8a883b2934decb8bb53ff9b486/include/eigen3 -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02925/el8_amd64_gcc13/external/fmt/10.2.1-31d67b0504b4ba2262f03d3c5cad83c1/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02925/el8_amd64_gcc13/external/md5/1.0.0-26057075013e190e56dad37d35219376/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02925/el8_amd64_gcc13/external/OpenBLAS/0.3.27-da4a3c2bb8ae43f3913a4a44acdb1b50/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02925/el8_amd64_gcc13/external/tinyxml2/6.2.0-67924ead96ecb4e69aad321b767979a5/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -DEIGEN_DONT_PARALLELIZE -DEIGEN_MAX_ALIGN_BYTES=64 -DALPAKA_DEFAULT_HOST_MEMORY_ALIGNMENT=128 -DALPAKA_DISABLE_VENDOR_RNG -DALPAKA_HAS_STD_ATOMIC_REF -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/el8_amd64_gcc13/src/RecoLocalCalo/EcalRecAlgos/bin/makeEcalMultifitResultsGpuValidationPlots/makeEcalMultifitResultsGpuValidationPlots.cpp.d src/RecoLocalCalo/EcalRecAlgos/bin/makeEcalMultifitResultsGpuValidationPlots.cpp -o tmp/el8_amd64_gcc13/src/RecoLocalCalo/EcalRecAlgos/bin/makeEcalMultifitResultsGpuValidationPlots/makeEcalMultifitResultsGpuValidationPlots.cpp.o
In file included from src/RecoLocalCalo/EcalRecAlgos/bin/makeEcalMultifitResultsGpuValidationPlots.cpp:16:
poison/CUDADataFormats/EcalRecHitSoA/interface/EcalUncalibratedRecHit.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
    1 | #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
      |  ^~~~~
src/RecoLocalCalo/EcalRecAlgos/bin/makeEcalMultifitResultsGpuValidationPlots.cpp: In function 'int main(int, char**)':
src/RecoLocalCalo/EcalRecAlgos/bin/makeEcalMultifitResultsGpuValidationPlots.cpp:38:16: error: 'ecal' was not declared in this scope
   38 |   edm::Wrapper>> *wgpuEB =


[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49872/47574

• There are other open Pull requests which might conflict with changes you have proposed:
  • File RecoLocalCalo/EcalRecProducers/test/testEcalRechitProducer_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
  • File RecoLocalCalo/EcalRecProducers/test/testEcalUncalibRecHitPhase2WeightsProducerGPU.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076
  • File RecoLocalCalo/EcalRecProducers/test/testEcalUncalibRechitProducer_cfg.py modified in PR(s): Remove the configuration of the legacy CUDA workflows #46076

[thomreis]

It is not clear to me why the repository is getting larger when 10k lines are removed.

[fwyzard]

It is not clear to me why the repository is getting larger when 10k lines are removed.

Well, I guess there is still some extra information in the repository.

32k looks like a new file.

[fwyzard]

+heterogeneous

[makortel]

It is not clear to me why the repository is getting larger when 10k lines are removed.

Well, I guess there is still some extra information in the repository.

Right, the deletion becomes part of the history so git must record it in some way.

32k looks like a new file.

I'm not sure about the precision of the check (like does it repack the local repository before checking the size after merging the PR in question).

[smuzaffar]

Right, the deletion becomes part of the history so git must record it in some way.

correct, deletion of files does not mean that all the history of that file is removed from repository. Each commit adds a blob in to the history so size of repository always increases .

I'm not sure about the precision of the check (like does it repack the local repository before checking the size after merging the PR in question).

bot does repack the repo couple of times before merging the changes and then repack again after the merge. But I agree that number here is not an exact representation of the actual increase.

[cmsbuild]

REMINDER @ftenchini, @sextonkennedy, @mandrenguyen: This PR was tested with cms-sw/cmsdist#10289, please check if they should be merged together

[perrotta]

+1

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1