[CPP23] Remove FORCE_REQUIRES for cuda in spec file

[smuzaffar]

No description provided.

[cmsbuild]

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_16_1_X/cpp23.

@akritkbehera, @cmsbuild, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

[cmsbuild]

cms-bot internal usage

[smuzaffar]

please test with cms-sw/cmssw#49872,cms-sw/cmssw#49829 using full cmssw for CMSSW_16_1_CPP23_X

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dcdca9/50763/summary.html
COMMIT: b777d78
CMSSW: CMSSW_16_1_CPP23_X_2026-01-20-1100/el8_amd64_gcc14
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10289/50763/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed Build

I found compilation error when building:

/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc14/external/gcc/14.3.1-724da22786638848892aa9ded8fcd995/bin/c++ -c -DCMS_MICRO_ARCH='x86-64-v3' -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=140301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DBOOST_MPL_IGNORE_PARENTHESES_WARNING -DCMSSW_GIT_HASH='CMSSW_16_1_CPP23_X_2026-01-20-1100' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_16_1_CPP23_X_2026-01-20-1100' -Isrc -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc14/external/onnxruntime/1.20.1-e8c22c550be936056ecc6fb7037d5db8/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc14/external/pcre/8.43-dd87967f31bc038bf6a8abe2be06d878/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc14/external/boost/1.80.0-c41698204bbd8fe6b779e12574786ae4/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc14/external/bz2lib/1.0.6-a45a4a64bd925bd0ba8954d249304f19/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc14/external/cppunit/1.15.x-cab1f5c16961d3146ed5b5b58dbaf0f2/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc14/external/libuuid/2.34-767b094004db7bc5bb18e2c4125785ec/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc14/external/protobuf/3.21.9-a596ab8f795bc24a6d33407d76b5f949/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc14/lcg/root/6.36.07-a4d1fa890c372e508af854bfb8620c41/include -isystem/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc14/external/tbb/v2022.3.0-b08dd18838015457cfeb2ffa9192bd18/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc14/external/xz/5.6.4-d44dfda29fc121dff35f6cb17845463b/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc14/external/zlib/1.2.13-8abc0804c1703682302a8801f051fa9d/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc14/external/md5/1.0.0-4c04fac6c42256d53fbdabb58aa703f3/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc14/external/re2/2021-06-01-ce65e95e12e2879f99e3522b2e14de6b/include -I/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc14/external/tinyxml2/6.2.0-776d06aaa678176c86223e685b2807b3/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++23 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/el8_amd64_gcc14/src/PhysicsTools/ONNXRuntime/test/testONNXRuntime/testRunner.cpp.d src/PhysicsTools/ONNXRuntime/test/testRunner.cpp -o tmp/el8_amd64_gcc14/src/PhysicsTools/ONNXRuntime/test/testONNXRuntime/testRunner.cpp.o
>> Building binary testONNXRuntime
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc14/external/gcc/14.3.1-724da22786638848892aa9ded8fcd995/bin/c++ -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++23 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC  tmp/el8_amd64_gcc14/src/PhysicsTools/ONNXRuntime/test/testONNXRuntime/testONNXRuntime.cc.o tmp/el8_amd64_gcc14/src/PhysicsTools/ONNXRuntime/test/testONNXRuntime/testRunner.cpp.o -Wl,-E -Wl,--hash-style=gnu -Wl,--as-needed -Wl,-z,noexecstack -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_16_1_CPP23_X_2026-01-20-1100/biglib/el8_amd64_gcc14 -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_16_1_CPP23_X_2026-01-20-1100/lib/el8_amd64_gcc14 -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_16_1_CPP23_X_2026-01-20-1100/external/el8_amd64_gcc14/lib -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_16_1_CPP23_X_2026-01-20-1100/static/el8_amd64_gcc14 -lFWCoreParameterSet -lFWCoreMessageLogger -lDataFormatsProvenance -lFWCorePluginManager -lFWCoreReflection -lPhysicsToolsONNXRuntime -lFWCoreUtilities -lTree -lNet -lThread -lMathCore -lRIO -lCore -lboost_thread -lboost_date_time -lonnxruntime -lpcre -lbz2 -lcppunit -luuid -lprotobuf -ltbb -llzma -lz -lcms-md5 -lre2 -lcrypt -ldl -lrt -lstdc++fs -ltinyxml2 -o tmp/el8_amd64_gcc14/src/PhysicsTools/ONNXRuntime/test/testONNXRuntime/testONNXRuntime
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc14/external/gcc/14.3.1-724da22786638848892aa9ded8fcd995/bin/../lib/gcc/x86_64-redhat-linux-gnu/14.3.1/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: tmp/el8_amd64_gcc14/src/PhysicsTools/ONNXRuntime/test/testONNXRuntime/ccmMtQhT.ltrans0.ltrans.o: in function `testONNXRuntime::checkGPU()':
:(.text+0x1b4d): undefined reference to `cms::cudatest::testDevices()'
collect2: error: ld returned 1 exit status
>> Deleted: tmp/el8_amd64_gcc14/src/PhysicsTools/ONNXRuntime/test/testONNXRuntime/testONNXRuntime
gmake: *** [tmp/el8_amd64_gcc14/src/PhysicsTools/ONNXRuntime/test/testONNXRuntime/testONNXRuntime] Error 1
>> Leaving Package PhysicsTools/ONNXRuntime
>> Package PhysicsTools/ONNXRuntime built
>> Entering Package PhysicsTools/PyTorchAlpaka


[smuzaffar]

@fwyzard , only two packages now failed to build (8 more with link errors due to 2 build failures) after dropping cuda completely from cmssw software stack + CMSSW PRs cms-sw/cmssw#49872 cms-sw/cmssw#49829

[fwyzard]

The failure in PhysicsTools/ONNXRuntime is in a test, that uses CUDA unconditionally.

[fwyzard]

The failure in Sonic should be fixable by moving the #include for cudaCheck.h inside an #ifdef TRITON_ENABLE_GPU block.

[smuzaffar]

indeed moving cudaCheck.h include under #ifdef TRITON_ENABLE_GPU fixed all Sonic related build and link issues.

[fwyzard]

@smuzaffar do you think something like cms-sw/cmssw#49883 should work for the ONNX test ?

[smuzaffar]

+externals
nearly every thing either build or we know where to fix. So lets get this change in

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_16_1_X/cpp23 IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmssw#49872