-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Add RNTupleTempSource and RNTupleTempOutputModule #49532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
please test |
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49532/47042
|
|
A new Pull Request was created by @Dr15Jones for master. It involves the following packages:
@AdrianoDee, @DickyChant, @Dr15Jones, @antoniovagnerini, @battibass, @ftorrresd, @makortel, @miquork, @smuzaffar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
-1 Failed Tests: ClangBuild Failed Clang BuildI found compilation warning while trying to compile with clang. Command used: See details on the summary page. |
|
hold too many commits |
|
Pull request has been put on hold by @Dr15Jones |
This will allow other sources to reuse the code
Names have changed but still using TTree for now.
- Also removed some backwards compatibility code
- based on IOPool/Tests - includes changes needed to make tests work
Cloning is not an option for RNTuple.
Removed all references to TTree used during the transition.
|
please test with #49531 |
|
-1 Failed Tests: UnitTests Failed Unit TestsI found 1 errors in the following unit tests: ---> test TestRNTupleTempEventHistory had ERRORS Comparison SummarySummary:
|
|
Comparison differences are related to #47071 |
|
+core I compared the diff of the PR to the diff of |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
|
It is a bit weird though that the test with #49531 still showed a failure in |
|
ignore tests-rejected ib-failure |
|
+1 |
PR description:
PR validation:
Code compiles. Unit tests that pass in IBs pass after change.
resolves cms-sw/framework-team#1680