Skip to content

Conversation

@Dr15Jones
Copy link
Contributor

@Dr15Jones Dr15Jones commented Dec 2, 2025

PR description:

  • Used PoolSource and PoolOutputModule as templates for their equivalent implementation using RNTuple. The new modules are meant to be used to further stress test the use of RNTuple in CMSSW. A different set of modules will be made for use during HL-LHC running.
  • moved commits from RNTUPLE_X build to master.

PR validation:

Code compiles. Unit tests that pass in IBs pass after change.

resolves cms-sw/framework-team#1680

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2025

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49532/47042

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2025

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv)
  • FWCore/Sources (core)
  • FWIO/RNTuple (core)
  • FWIO/RNTupleTempInput (core)
  • FWIO/RNTupleTempOutput (core)
  • FWIO/RNTupleTempTests (core)
  • IOPool/Common (core)
  • IOPool/Input (core)
  • PhysicsTools/NanoAOD (xpog)

@AdrianoDee, @DickyChant, @Dr15Jones, @antoniovagnerini, @battibass, @ftorrresd, @makortel, @miquork, @smuzaffar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @gpetruc, @makortel, @missirol, @mmusich, @slomeo, @wddgit this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2025

-1

Failed Tests: ClangBuild
Size: This PR adds an extra 80KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-56d9da/49771/summary.html
COMMIT: 5839e3b
CMSSW: CMSSW_16_0_X_2025-12-02-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49532/49771/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' /usr/bin/time -v scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

@Dr15Jones
Copy link
Contributor Author

hold

too many commits

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2025

Pull request has been put on hold by @Dr15Jones
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Dec 2, 2025
This will allow other sources to reuse the code
Names have changed but still using TTree for now.
- Also removed some backwards compatibility code
  - based on IOPool/Tests
  - includes changes needed to make tests work
Cloning is not an option for RNTuple.
Removed all references to TTree used during the transition.
@Dr15Jones
Copy link
Contributor Author

please test with #49531

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2025

-1

Failed Tests: UnitTests
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-56d9da/49787/summary.html
COMMIT: b3bf9f0
CMSSW: CMSSW_16_0_X_2025-12-03-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49532/49787/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed Unit Tests

I found 1 errors in the following unit tests:

---> test TestRNTupleTempEventHistory had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 4 differences found in the comparisons
  • Reco comparison had 4 failed jobs
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4273241
  • DQMHistoTests: Total failures: 27
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4273194
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor

makortel commented Dec 3, 2025

Comparison differences are related to #47071

@makortel
Copy link
Contributor

makortel commented Dec 3, 2025

+core

I compared the diff of the PR to the diff of master..CMSSW_16_0_RNTUPLE_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: #49531

@makortel
Copy link
Contributor

makortel commented Dec 3, 2025

It is a bit weird though that the test with #49531 still showed a failure in TestRNTupleTempEventHistory. If the failure persists in IBs, I think it would be better to investigate there.

@makortel
Copy link
Contributor

makortel commented Dec 3, 2025

ignore tests-rejected ib-failure

@ftenchini
Copy link

+1

@cmsbuild cmsbuild merged commit c51d1ad into cms-sw:master Dec 4, 2025
9 of 10 checks passed
@Dr15Jones Dr15Jones deleted the rntuple_temp_to_master branch December 10, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorporate RNTuple code

4 participants