[DAQ] Fix DTH input readout with multiple source IDs#49552
[DAQ] Fix DTH input readout with multiple source IDs#49552cmsbuild merged 1 commit intocms-sw:masterfrom
Conversation
|
cms-bot internal usage |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49552/47068 Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
smorovic
force-pushed
the
dev-fix-multi-source
branch
from
795e5df to
2cb3855
Compare
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49552/47069 |
|
A new Pull Request was created by @smorovic for master. It involves the following packages:
@cmsbuild, @emeschi, @smorovic can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild please test |
|
-1 Failed Tests: UnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Failed Unit TestsI found 2 errors in the following unit tests: ---> test TestRNTupleTempEventHistory had ERRORS ---> test TestIOPoolInputSchemaEvolution had ERRORS Comparison SummarySummary:
|
|
please test |
|
-1 Failed Tests: UnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Failed Unit TestsI found 2 errors in the following unit tests: ---> test TestRNTupleTempEventHistory had ERRORS ---> test TestIOPoolInputSchemaEvolution had ERRORS Comparison SummarySummary:
|
|
test are failures not related to this patch. |
|
+daq |
cmsbuild
added
daq-approved
fully-signed
and removed
daq-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2) |
|
@cmsbuild please test |
|
+1 Size: This PR adds an extra 16KB to repository DAS Queries: The DAS query tests failed, see the summary page for details. Comparison SummarySummary:
|
|
+1 |
3 participants
PR description:
Fixes buffer size accounting with multiple source IDs read when using DTH input mode.
Also improve text message when one input file has too few events.
PR validation:
Tested manually with a sample of three files provided by subdetector experts.