Skip to content

Define dictionaries for X::Layout type aliases in DataFormats/HGCalDigi #49473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cmsbuild merged 2 commits into from
Nov 27, 2025
Merged

Define dictionaries for X::Layout type aliases in DataFormats/HGCalDigi #49473

cmsbuild merged 2 commits into from
Nov 27, 2025

Conversation

@makortel
Copy link
Contributor

@makortel makortel commented Nov 25, 2025

PR description:

#49470 reported auto-parsing failures related to HGCalECONDPacketInfoSoALayout (and somehow specific to using RNTuple output). Visual inspection of the classes_def.xml file showed that the X::Layout type alias has not been specified, while the read rule explicitly uses the X::Layout in a string form, and therefore a dictionary has to be specified in order to avoid header parsing. This PR adds entries for the X::Layout type aliases.

In addition this PR uses the rntupleStreamerMode attribute consistently for the PortableHostCollection types.

For more information on "why" see #49458, #48824.

Resolves #49470
Resolves cms-sw/framework-team#1703

PR validation:

The DataFormatsHGCalDigi_xr.rootmap file has entries for all the four X::Layout type aliases. Workflow 77.0 runs successfully in CMSSW_16_0_RNTUPLE_X_2025-11-24-2300 and this PR.

@makortel
Define dictionaries for X::Layout type aliases before their alias-to …
368070a 
…types

This is necessary to get the X::Laout type alias recorded in the
rootmap file, that is needed for the read rule.
@makortel
Specify rntupleStreamerMode consistently for the PortableHostCollections
f5d4652
@cmsbuild cmsbuild added this to the CMSSW_16_0_X milestone Nov 25, 2025
@makortel makortel mentioned this pull request Nov 25, 2025
Closed
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 25, 2025 •
edited
Loading

cms-bot internal usage

@makortel makortel mentioned this pull request Nov 25, 2025
Open
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 25, 2025

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49473/46951

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 25, 2025

A new Pull Request was created by @makortel for master.

It involves the following packages:

  • DataFormats/HGCalDigi (simulation)

@civanch, @cmsbuild, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@IzaakWN, @missirol, @mmusich, @pfs, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

makortel commented Nov 25, 2025

@cmsbuild, please test

@makortel makortel mentioned this pull request Nov 25, 2025
Merged
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 25, 2025

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c4f965/49679/summary.html
COMMIT: f5d4652
CMSSW: CMSSW_16_0_X_2025-11-25-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49473/49679/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 11 differences found in the comparisons
  • Reco comparison had 4 failed jobs
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4269665
  • DQMHistoTests: Total failures: 89
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4269556
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Nov 27, 2025

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 27, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

mandrenguyen commented Nov 27, 2025

+1

@cmsbuild cmsbuild merged commit f4faf02 into cms-sw:master Nov 27, 2025
10 checks passed
@makortel makortel deleted the hgcalDictionary branch December 3, 2025 20:34
@mmusich mmusich mentioned this pull request Dec 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

changes-dataformats code-checks-approved fully-signed orp-approved simulation-approved tests-approved

Projects

None yet

Milestone

CMSSW_16_0_X

Development

Successfully merging this pull request may close these issues.

Fix missing dictionaries in workflow 77.0 [RNTUPLE_X] Header auto-parse failure in workflow 77.0

4 participants

@makortel @cmsbuild @civanch @mandrenguyen