-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Define dictionaries for X::Layout type aliases in DataFormats/EcalDigi
#49581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49581/47114 |
|
A new Pull Request was created by @mmusich for master. It involves the following packages:
@civanch, @cmsbuild, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test |
|
By eye looks good to me |
|
+1 Size: This PR adds an extra 24KB to repository DAS Queries: The DAS query tests failed, see the summary page for details. Comparison SummarySummary:
|
|
Judging from the bot test results, this was not effective in solving #49568. |
Darn. I think this PR should be merged anyhow, and we need a ROOT debug build to investigate further. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
In response to #49568, follows the same spirit as #49473, taking #49568 (comment).
Visual inspection of the
classes_def.xmlfile showed that theX::Layouttype alias has not been specified, while the read rule explicitly uses theX::Layoutin a string form, and therefore a dictionary has to be specified in order to avoid header parsing. This PR adds entries for theX::Layouttype aliases.PR validation:
cmsswcompiles.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, no backport needed.