Skip to content

Conversation

@mmusich
Copy link
Contributor

@mmusich mmusich commented Dec 9, 2025

PR description:

In response to #49568, follows the same spirit as #49473, taking #49568 (comment).
Visual inspection of the classes_def.xml file showed that the X::Layout type alias has not been specified, while the read rule explicitly uses the X::Layout in a string form, and therefore a dictionary has to be specified in order to avoid header parsing. This PR adds entries for the X::Layout type aliases.

PR validation:

cmssw compiles.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, no backport needed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2025

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • DataFormats/EcalDigi (simulation)

@civanch, @cmsbuild, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@ReyerBand, @argiro, @missirol, @rchatter, @rovere, @thomreis, @wang0jin this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Dec 9, 2025

@cmsbuild, please test

@makortel
Copy link
Contributor

makortel commented Dec 9, 2025

By eye looks good to me

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2025

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-37f476/49863/summary.html
COMMIT: efb0c1c
CMSSW: CMSSW_16_0_X_2025-12-09-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49581/49863/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 6 differences found in the comparisons
  • Reco comparison had 4 failed jobs
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4273241
  • DQMHistoTests: Total failures: 70
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4273151
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Dec 10, 2025

Judging from the bot test results, this was not effective in solving #49568.
I see still a segmentation fault in it.

@makortel
Copy link
Contributor

Judging from the bot test results, this was not effective in solving #49568. I see still a segmentation fault in it.

Darn. I think this PR should be merged anyhow, and we need a ROOT debug build to investigate further.

@civanch
Copy link
Contributor

civanch commented Dec 12, 2025

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 87c78c7 into cms-sw:master Dec 12, 2025
10 checks passed
@mmusich mmusich deleted the ecalDictionary branch December 12, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants