Skip to content

[FSC DQMn - master]: Initial commit of FSC plus implementation in DQM. #49273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 10, 2025
Merged

[FSC DQMn - master]: Initial commit of FSC plus implementation in DQM. #49273

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce7b535
[FSC DQM]: Initial commit of FSC plus implementation in DQM.
hjbossi Oct 31, 2025
b8014df
Add uHTR data TP plots
hjbossi Nov 6, 2025
692fa28
Add variables instead of hard coded values for TP info.
hjbossi Nov 7, 2025
6a5b57f
Fix code checks.
hjbossi Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions DQM/HcalTasks/interface/ZDCQIE10Task.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,14 @@ class ZDCQIE10Task : public hcaldqm::DQTask {

// tags
edm::InputTag _tagQIE10;
edm::InputTag _tagData;
edm::InputTag sumTag;
edm::InputTag sumTagUnpacked;
edm::EDGetTokenT<QIE10DigiCollection> _tokQIE10;
edm::ESGetToken<HcalDbService, HcalDbRecord> hcalDbServiceToken_;
edm::EDGetToken sumToken_;
edm::EDGetToken sumTokenUnpacked_;
edm::EDGetToken sumTokenData_;
edm::ESGetToken<HcalTopology, HcalRecNumberingRecord> htopoToken_;
edm::ESGetToken<HcalLongRecoParams, HcalLongRecoParamsRcd> paramsToken_;

Expand All @@ -64,6 +66,8 @@ class ZDCQIE10Task : public hcaldqm::DQTask {
std::map<uint32_t, MonitorElement *> _cZDC_BXSUMS;
std::map<uint32_t, MonitorElement *> _cZDC_BX_EmuSUMS;
std::map<uint32_t, MonitorElement *> _cZDC_EmuSumTP_DataSum;
std::map<uint32_t, MonitorElement *> _cZDC_EmuSumTP_L1rcvdSum;
std::map<uint32_t, MonitorElement *> _cZDC_L1rcvdSumTP_DataSum;
std::map<uint32_t, MonitorElement *> _cZDC_CapIDS;
std::map<uint32_t, MonitorElement *> _cfC_EChannel;
std::map<uint32_t, MonitorElement *> _cTDC_EChannel;
Expand Down
107 changes: 100 additions & 7 deletions DQM/HcalTasks/plugins/ZDCQIE10Task.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,20 @@ using namespace hcaldqm::filter;
ZDCQIE10Task::ZDCQIE10Task(edm::ParameterSet const& ps)

: DQTask(ps), hcalDbServiceToken_(esConsumes<HcalDbService, HcalDbRecord, edm::Transition::BeginRun>()) {
//tags
//tags data for digis and TPs
_tagQIE10 = ps.getUntrackedParameter<edm::InputTag>("tagQIE10", edm::InputTag("hcalDigis", "ZDC"));
_tokQIE10 = consumes<QIE10DigiCollection>(_tagQIE10);
_tagData = ps.getUntrackedParameter<edm::InputTag>("tagData", edm::InputTag("hcalDigis"));
sumTokenData_ = consumes<HcalTrigPrimDigiCollection>(_tagData);

// emulated sums
sumTag = ps.getUntrackedParameter<edm::InputTag>("etSumTag", edm::InputTag("etSumZdcProducer", ""));
sumToken_ = consumes<l1t::EtSumBxCollection>(sumTag);

// unpacked sums
sumTagUnpacked = ps.getUntrackedParameter<edm::InputTag>("etSumTag", edm::InputTag("gtStage2Digis", "EtSumZDC"));
sumTokenUnpacked_ = consumes<l1t::EtSumBxCollection>(sumTag);
sumTagUnpacked =
ps.getUntrackedParameter<edm::InputTag>("etSumTagUnpacked", edm::InputTag("gtStage2Digis", "EtSumZDC"));
sumTokenUnpacked_ = consumes<l1t::EtSumBxCollection>(sumTagUnpacked);

htopoToken_ = esConsumes<HcalTopology, HcalRecNumberingRecord>();
paramsToken_ = esConsumes<HcalLongRecoParams, HcalLongRecoParamsRcd>();
Expand Down Expand Up @@ -148,11 +151,13 @@ ZDCQIE10Task::ZDCQIE10Task(edm::ParameterSet const& ps)
varbins.push_back(1023);
varbins.push_back(1024);

histoname = "ZDCM_EmuSumTP_DataSum";
// Emu Sum TP vs. Data Sum TP
histoname = "ZDCM_EmuSumTP_DataSumTP";
ib.setCurrentFolder("Hcal/ZDCQIE10Task/TPs");

TH2D* varBinningTH2D = new TH2D(
histoname.c_str(), histoname.c_str(), varbins.size() - 1, varbins.data(), varbins.size() - 1, varbins.data());

_cZDC_EmuSumTP_DataSum[0] = ib.book2DD(histoname.c_str(), varBinningTH2D);
_cZDC_EmuSumTP_DataSum[0]->setAxisTitle("Emulated TP Sum (Online Counts)", 2);

Expand All @@ -162,6 +167,38 @@ ZDCQIE10Task::ZDCQIE10Task(edm::ParameterSet const& ps)
_cZDC_EmuSumTP_DataSum[1]->setAxisTitle("Data TP Sum (Online Counts)", 1);
_cZDC_EmuSumTP_DataSum[1]->setAxisTitle("Emulated TP Sum (Online Counts)", 2);

// Emu Sum TP vs. L1rcvd Sum TP
histoname = "ZDCM_EmuSumTP_L1rcvdSumTP";
ib.setCurrentFolder("Hcal/ZDCQIE10Task/TPs");

TH2D* varBinningTH2D_EmuL1rcvd = new TH2D(
histoname.c_str(), histoname.c_str(), varbins.size() - 1, varbins.data(), varbins.size() - 1, varbins.data());

_cZDC_EmuSumTP_L1rcvdSum[0] = ib.book2DD(histoname.c_str(), varBinningTH2D_EmuL1rcvd);
_cZDC_EmuSumTP_L1rcvdSum[0]->setAxisTitle("Emulated TP Sum (Online Counts)", 2);

histoname = "ZDCP_EmuSumTP_L1rcvdSumTP";
ib.setCurrentFolder("Hcal/ZDCQIE10Task/TPs");
_cZDC_EmuSumTP_L1rcvdSum[1] = ib.book2DD(histoname.c_str(), varBinningTH2D_EmuL1rcvd);
_cZDC_EmuSumTP_L1rcvdSum[1]->setAxisTitle("L1 rcvd TP Sum (Online Counts)", 1);
_cZDC_EmuSumTP_L1rcvdSum[1]->setAxisTitle("Emulated TP Sum (Online Counts)", 2);

// L1rcvd Sum TP vs. Data Sum TP
histoname = "ZDCM_L1rcvdSumTP_DataSumTP";
ib.setCurrentFolder("Hcal/ZDCQIE10Task/TPs");

TH2D* varBinningTH2D_L1rcvdData = new TH2D(
histoname.c_str(), histoname.c_str(), varbins.size() - 1, varbins.data(), varbins.size() - 1, varbins.data());

_cZDC_L1rcvdSumTP_DataSum[0] = ib.book2DD(histoname.c_str(), varBinningTH2D_L1rcvdData);
_cZDC_L1rcvdSumTP_DataSum[0]->setAxisTitle("L1 rcvd TP Sum (Online Counts)", 2);

histoname = "ZDCP_L1rcvdSumTP_DataSumTP";
ib.setCurrentFolder("Hcal/ZDCQIE10Task/TPs");
_cZDC_L1rcvdSumTP_DataSum[1] = ib.book2DD(histoname.c_str(), varBinningTH2D_L1rcvdData);
_cZDC_L1rcvdSumTP_DataSum[1]->setAxisTitle("Data TP Sum (Online Counts)", 1);
_cZDC_L1rcvdSumTP_DataSum[1]->setAxisTitle("L1 rcvd TP Sum (Online Counts)", 2);

histoname = "CapIDs";
ib.setCurrentFolder("Hcal/ZDCQIE10Task");
_cZDC_CapIDS[0] = ib.book1DD(histoname.c_str(), histoname.c_str(), 4, 0, 4);
Expand Down Expand Up @@ -292,7 +329,7 @@ ZDCQIE10Task::ZDCQIE10Task(edm::ParameterSet const& ps)

// adding 6 FSC channels on z- side (labeled as EM7_minus - EM12_minus)
for (int channel = 7; channel < 13; channel++) {
// EM Minus
// FSC Minus
HcalZDCDetId didm(HcalZDCDetId::EM, false, channel);

std::vector<std::string> stationString = {
Expand Down Expand Up @@ -323,6 +360,38 @@ ZDCQIE10Task::ZDCQIE10Task(edm::ParameterSet const& ps)
_cTDC_EChannel[didm()] = ib.book1DD(histoname.c_str(), histoname.c_str(), 150, 0, 150);
_cTDC_EChannel[didm()]->setAxisTitle("TDC", 1);
_cTDC_EChannel[didm()]->setAxisTitle("N", 2);

// FSC plus
HcalZDCDetId didp(HcalZDCDetId::EM, true, channel);

std::vector<std::string> stationStringP = {
"2_P_Top", "2_P_Bottom", "3_P_BottomLeft", "3_P_BottomRight", "3_P_TopLeft", "3_P_TopRight"};

histoname = "FSC" + stationStringP.at(channel - 7);
ib.setCurrentFolder("Hcal/ZDCQIE10Task/ADC_perChannel");
_cADC_EChannel[didp()] = ib.book1DD(histoname.c_str(), histoname.c_str(), 256, 0, 256);
_cADC_EChannel[didp()]->setAxisTitle("ADC", 1);
_cADC_EChannel[didp()]->setAxisTitle("N", 2);
ib.setCurrentFolder("Hcal/ZDCQIE10Task/ADC_vs_TS_perChannel");
_cADC_vs_TS_EChannel[didp()] = ib.book1DD(histoname.c_str(), histoname.c_str(), 6, 0, 6);
_cADC_vs_TS_EChannel[didp()]->setAxisTitle("TS", 1);
_cADC_vs_TS_EChannel[didp()]->setAxisTitle("sum ADC", 2);

histoname = "FSC" + stationStringP.at(channel - 7);
ib.setCurrentFolder("Hcal/ZDCQIE10Task/fC_perChannel");
_cfC_EChannel[didp()] = ib.book1DD(histoname.c_str(), histoname.c_str(), 100, 0, 8000);
_cfC_EChannel[didp()]->setAxisTitle("fC", 1);
_cfC_EChannel[didp()]->setAxisTitle("N", 2);
ib.setCurrentFolder("Hcal/ZDCQIE10Task/fC_vs_TS_perChannel");
_cfC_vs_TS_EChannel[didp()] = ib.book1DD(histoname.c_str(), histoname.c_str(), 6, 0, 6);
_cfC_vs_TS_EChannel[didp()]->setAxisTitle("TS", 1);
_cfC_vs_TS_EChannel[didp()]->setAxisTitle("sum fC", 2);

histoname = "FSC" + stationStringP.at(channel - 7);
ib.setCurrentFolder("Hcal/ZDCQIE10Task/TDC_perChannel");
_cTDC_EChannel[didp()] = ib.book1DD(histoname.c_str(), histoname.c_str(), 150, 0, 150);
_cTDC_EChannel[didp()]->setAxisTitle("TDC", 1);
_cTDC_EChannel[didp()]->setAxisTitle("N", 2);
}

for (int channel = 1; channel < 5; channel++) {
Expand Down Expand Up @@ -502,9 +571,33 @@ void ZDCQIE10Task::_process(edm::Event const& e, edm::EventSetup const& es) {
}
}

edm::Handle<HcalTrigPrimDigiCollection> data_sums;
e.getByToken(sumTokenData_, data_sums);
double dataSumP = -1.0;
double dataSumM = -1.0;
for (HcalTrigPrimDigiCollection::const_iterator it = data_sums->begin(); it != data_sums->end(); ++it) {
// Explicit check on the DetIds present in the Collection
HcalTrigTowerDetId tid = it->id();

// ZDCp TP
if (tid.ieta() >= 42 && tid.iphi() == 99) {
// need to convert to the actual dynamic range of the ZDC sums
dataSumP = it->t0().raw() & 1023;
}
// ZDCm TP
if (tid.ieta() <= -42 && tid.iphi() == 99) {
// need to convert to the actual dynamic range of the ZDC sums
dataSumM = it->t0().raw() & 1023;
}
}

// now fill the unpacked and emulator comparison histogram
_cZDC_EmuSumTP_DataSum[0]->Fill(unpackedSumM, emulatedSumM);
_cZDC_EmuSumTP_DataSum[1]->Fill(unpackedSumP, emulatedSumP);
_cZDC_EmuSumTP_DataSum[0]->Fill(dataSumM, emulatedSumM);
_cZDC_EmuSumTP_DataSum[1]->Fill(dataSumP, emulatedSumP);
_cZDC_EmuSumTP_L1rcvdSum[0]->Fill(unpackedSumM, emulatedSumM);
_cZDC_EmuSumTP_L1rcvdSum[1]->Fill(unpackedSumP, emulatedSumP);
_cZDC_L1rcvdSumTP_DataSum[0]->Fill(dataSumM, unpackedSumM);
_cZDC_L1rcvdSumTP_DataSum[1]->Fill(dataSumP, unpackedSumP);

edm::Handle<QIE10DigiCollection> digis;
if (!e.getByToken(_tokQIE10, digis))
Expand Down