[FSC DQMn - master]: Initial commit of FSC plus implementation in DQM. #49273
Conversation
|
cms-bot internal usage |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49273/46631 Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49273/46710 |
|
A new Pull Request was created by @hjbossi for master. It involves the following packages:
@cmsbuild, @ctarricone, @gabrielmscampos, @nothingface0, @rseidita can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Hi All, I have just pushed some updates for additional TP histograms recording the data TP, l1 received TP and the emulated TP. Tagging in addition @JHiltbrand. This PR should now be ready for review and the backport to 15_1_X, which will be used in the DQM for HI data taking (to be synchronized with the update of the GT to occur tomorrow). |
|
test parameters: |
|
please test |
| // ZDCp TP | ||
| if (tid.ieta() >= 42 && tid.iphi() == 99) { | ||
| // need to convert to the actual dynamic range of the ZDC sums | ||
| dataSumP = it->t0().raw() & 1023; |
There was a problem hiding this comment.
Hi @hjbossi ,
Can we define the saturation value somewhere so as to not hard-code a number here ?
| // ZDCm TP | ||
| if (tid.ieta() <= -42 && tid.iphi() == 99) { | ||
| // need to convert to the actual dynamic range of the ZDC sums | ||
| dataSumM = it->t0().raw() & 1023; |
4 participants
PR description:
This PR includes the addition of the FSC on the plus side to the DQM, that will be newly installed for the heavy-ion run. Note that this PR can only be merged once the global tag is updated with the emap included in the ongoing full track validation. See JIRA ticket for more details.
PR validation:
As the FSC on the plus side is not yet installed, this PR was validated using data from the light ion run. A description of this and proof this histograms are created is included here. See dropbox paper
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This PR is intended for HIN data taking and will need to be backported to 15_1_X.
Tagging HIN colleagues: @mandrenguyen
Tagging HCAL colleagues:@abdoulline @akhukhun @salimcerci, @denizsun
Tagging FSC colleagues: @michael-pitt