-
Notifications
You must be signed in to change notification settings - Fork 4.6k
[NGT] Add support for older geometries in PixelTracking CA #49272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- remove reliance on hard-coded value in simplePixelTopology - support older geometries (tested from D95)
|
cms-bot internal usage |
|
type ngt, bug-fix |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49272/46630
|
|
A new Pull Request was created by @Parsifal-2045 for master. It involves the following packages:
@cmsbuild, @jfernan2, @mandrenguyen, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
test parameters:
|
|
@cmsbuild, please test |
|
urgent |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2) |
|
-1 Failed Tests: UnitTests HLT P2 Timing: chart Unit TestsI found 1 errors in the following unit tests: ---> test test-das-selected-lumis had ERRORS Comparison SummarySummary:
|
failures are unrelated. |
|
ignore tests-rejected with ib-failure |
|
+1 |
|
This PR is a suspect for more crashes on GPUs, see #49288 |
PR description:
Since #48921 made the alpaka-based PixelTracking CA default for Phase 2 we have observed some failures in IB tests, mostly related to older geometries failing an assertion in the CA code (see #49266). The root cause has been investigated and found to be in the way used to compute
offsetBPIX2#49266 (comment).This PR implements a more flexible computation based on the geometry instead of using an hard-coded constant stored in
simplePixelTopology.hPR validation:
Tested locally on workflows that were failing in the latest IB:
23634.0, 24834.0,25234.0,25634.0,26034.0,26834.0plus a D110 reference29634.0.Run 3 performance is unaffected, verified using the following recipe
before and after the fix (full plots here).
Phase-2 CA (and CA Extension) physics performance is also unaffected and reflects the results in #48921.