Skip to content

Pass new signals to Tracer file #49276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cmsbuild merged 1 commit into from
Nov 3, 2025
Merged

Pass new signals to Tracer file #49276

cmsbuild merged 1 commit into from
Nov 3, 2025

Conversation

@Dr15Jones
Copy link
Contributor

@Dr15Jones Dr15Jones commented Oct 31, 2025 •
edited
Loading

PR description:

  • handle new startup related signals in Tracer file
  • Update edmTracerCompactLogViewer to handle new file entries
  • Update web view of timing for new signals.

PR validation:

Code compiles. New unit test passes. Running the web viewer shows the new information.

resolves cms-sw/framework-team#1625
resolves cms-sw/framework-team#1626
resolves cms-sw/framework-team#1627

@cmsbuild cmsbuild added this to the CMSSW_16_0_X milestone Oct 31, 2025
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 31, 2025 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 31, 2025

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49276/46638

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 31, 2025

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

  • FWCore/Services (core)

@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@fwyzard, @makortel, @wddgit this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

Dr15Jones commented Oct 31, 2025

please test

makortel
makortel reviewed Oct 31, 2025
View reviewed changes
FWCore/Services/scripts/edmTracerCompactLogViewer.py Outdated
if self.transition == Phase.beginProcessBlock or self.transition == Phase.endProcessBlock or self.transition == Phase.writeProcessBlock or self.transition == Phase.accessInputProcessBlock:
return ''
if self.transition == Phase.startTracing:
if self.transition == Phase.finalizeEDModules or self.transition == Phase.finalizeEventSetupConfiguration or self.transition == Phase.scheduleConsistencyCheck or self.transition == Phase.createRunLumiEvents or self.transition == Phase.finishSchedule or self.transition == Phase.constructESModules or self.transition == Phase.startServices or self.transition == Phase.processPython:
Copy link
Contributor

@makortel makortel Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about

Suggested change
if self.transition == Phase.finalizeEDModules or self.transition == Phase.finalizeEventSetupConfiguration or self.transition == Phase.scheduleConsistencyCheck or self.transition == Phase.createRunLumiEvents or self.transition == Phase.finishSchedule or self.transition == Phase.constructESModules or self.transition == Phase.startServices or self.transition == Phase.processPython:
if self.transition in [Phase.finalizeEDModules, Phase.finalizeEventSetupConfiguration, Phase.scheduleConsistencyCheck, Phase.createRunLumiEvents, Phase.finishSchedule, Phase.constructESModules, Phase.startServices, Phase.processPython]:

(or some variation of that)?

Copy link
Contributor Author

@Dr15Jones Dr15Jones Nov 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I let @copilot autocomplete that for me

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 31, 2025

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d80de/49126/summary.html
COMMIT: cdced77
CMSSW: CMSSW_16_0_X_2025-10-31-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49276/49126/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d80de/49126/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d80de/49126/git-merge-result

Comparison Summary

Summary:

@Dr15Jones
Pass new signals to Tracer file
857f9fc 
- handle new startup related signals in Tracer file
- Update edmTracerCompactLogViewer to handle new file entries
- Update web view of timing for new signals.
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2025

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49276/46639

@Dr15Jones
Copy link
Contributor Author

Dr15Jones commented Nov 1, 2025

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2025

Pull request #49276 was updated. @Dr15Jones, @makortel, @smuzaffar can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2025

+1

Size: This PR adds an extra 44KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d80de/49137/summary.html
COMMIT: 857f9fc
CMSSW: CMSSW_16_0_X_2025-11-01-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49276/49137/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 19 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3939953
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3939927
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 218 log files, 188 edm output root files, 51 DQM output files
  • TriggerResults: found differences in 1 / 49 workflows

@makortel
Copy link
Contributor

makortel commented Nov 3, 2025

+core

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

mandrenguyen commented Nov 3, 2025

+1

@cmsbuild cmsbuild merged commit 7dd41ef into cms-sw:master Nov 3, 2025
10 checks passed
@cmsbuild cmsbuild mentioned this pull request Nov 4, 2025
Merged
@makortel makortel mentioned this pull request Nov 4, 2025
Open
@Dr15Jones Dr15Jones deleted the tracerFileStartup branch November 14, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@makortel makortel makortel left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-checks-approved core-approved fully-signed orp-approved tests-approved

Projects

None yet

Milestone

CMSSW_16_0_X

4 participants

@Dr15Jones @cmsbuild @makortel @mandrenguyen