-
Notifications
You must be signed in to change notification settings - Fork 4.6k
BTagPerformance.h: added cmath header to fix the header consistency error #49146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BTagPerformance.h: added cmath header to fix the header consistency error #49146
Conversation
|
please test |
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49146/46431
|
|
A new Pull Request was created by @smuzaffar for master. It involves the following packages:
@tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+1 Size: This PR adds an extra 20KB to repository Comparison SummarySummary:
|
|
REMINDER @mandrenguyen, @ftenchini, @sextonkennedy: This PR was tested with #49159, please check if they should be merged together |
|
The PRs are independent. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
This adds the missing header
cmathfor https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/PatExamples/interface/BTagPerformance.h which usessqrtwithout includingcmathheader. This causes header consistency error [a][a] https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d1f908/48627/headers_chks.log