[ROOT6_X] Fix deprecated-literal-operator warning #49154

iarspider · 2025-10-14T08:42:04Z

PR description:

In CMSSW_16_0_ROOT6_X_2025-10-13-1600, gcc emits a warning of type deprecated-literal-operator: warning: identifier '<identifier>' preceded by whitespace in a literal operator declaration is deprecated.

In older C++ standards, both of these were valid:

operator""_pi     // no space
operator"" _pi    // space before suffix

But starting with C++23, the spaced form (operator"" _pi) is deprecated — the standard now prefers the no-space form.

PR validation:

Bot tests

iarspider · 2025-10-14T08:42:23Z

please test for CMSSW_16_0_ROOT6_X/el8_aarch64_gcc13

cmsbuild · 2025-10-14T08:42:33Z

cms-bot internal usage

cmsbuild · 2025-10-14T08:44:05Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49154/46443

cmsbuild · 2025-10-14T08:44:27Z

A new Pull Request was created by @iarspider for master.

It involves the following packages:

DataFormats/Math (reconstruction)

@jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@fabiocos, @felicepantaleo, @makortel, @missirol, @mmusich, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

iarspider · 2025-10-14T08:44:38Z

please test for CMSSW_16_0_ROOT6_X

cmsbuild · 2025-10-14T11:58:41Z

-1

Failed Tests: HeaderConsistency
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-43b94f/48658/summary.html
COMMIT: 197cee5
CMSSW: CMSSW_16_0_ROOT6_X_2025-10-13-2300/el8_aarch64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49154/48658/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-43b94f/48658/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-43b94f/48658/git-merge-result

iarspider · 2025-10-14T12:10:13Z

please test with #49146,#49159 for CMSSW_16_0_ROOT6_X/el8_amd64_gcc13

cmsbuild · 2025-10-14T12:27:35Z

-1

Failed Tests: HeaderConsistency
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-43b94f/48657/summary.html
COMMIT: 197cee5
CMSSW: CMSSW_16_0_ROOT6_X_2025-10-13-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49154/48657/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-43b94f/48657/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-43b94f/48657/git-merge-result

Comparison Summary

Summary:

You potentially added 270 lines to the logs
Reco comparison results: 45 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3940073
DQMHistoTests: Total failures: 3056
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3936997
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 218 log files, 188 edm output root files, 51 DQM output files
TriggerResults: no differences found

iarspider · 2025-10-14T15:15:01Z

please test with #49146,#49159 for CMSSW_16_0_ROOT6_X/el8_aarch64_gcc13

cmsbuild · 2025-10-14T15:44:02Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-43b94f/48670/summary.html
COMMIT: 197cee5
CMSSW: CMSSW_16_0_ROOT6_X_2025-10-13-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49154/48670/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-43b94f/48670/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-43b94f/48670/git-merge-result

Comparison Summary

Summary:

You potentially added 269 lines to the logs
Reco comparison results: 45 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3940073
DQMHistoTests: Total failures: 3128
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3936925
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 218 log files, 188 edm output root files, 51 DQM output files
TriggerResults: no differences found

iarspider · 2025-10-14T16:03:07Z

Additional PRs are not directly related, they are to fix HeaderConsistency errors.

cmsbuild · 2025-10-14T18:44:57Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-43b94f/48681/summary.html
COMMIT: 197cee5
CMSSW: CMSSW_16_0_ROOT6_X_2025-10-13-2300/el8_aarch64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49154/48681/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-43b94f/48681/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-43b94f/48681/git-merge-result

iarspider · 2025-10-15T09:17:46Z

type bug-fix
update syntax to match current C++ standard

jfernan2 · 2025-10-15T12:04:16Z

+1

cmsbuild · 2025-10-15T12:04:43Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

smuzaffar · 2025-10-15T13:27:25Z

please test

lets run tests for default/production IB too

cmsbuild · 2025-10-15T16:45:22Z

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-43b94f/48696/summary.html
COMMIT: 197cee5
CMSSW: CMSSW_16_0_X_2025-10-15-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49154/48696/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 14 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3940073
DQMHistoTests: Total failures: 31
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3940022
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 218 log files, 188 edm output root files, 51 DQM output files
TriggerResults: no differences found

mandrenguyen · 2025-10-15T19:48:15Z

+1

[ROOT6_X] Fix deprecated-literal-operator warning

197cee5

cmsbuild added this to the CMSSW_16_0_X milestone Oct 14, 2025

cmsbuild added reconstruction-pending pending-signatures orp-pending tests-started code-checks-pending labels Oct 14, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 14, 2025

cmsbuild added tests-rejected requires-external tests-started and removed tests-started tests-rejected labels Oct 14, 2025

cmsbuild added tests-approved and removed tests-started labels Oct 14, 2025

cmsbuild added the bug-fix label Oct 15, 2025

cmsbuild added reconstruction-approved fully-signed and removed reconstruction-pending pending-signatures labels Oct 15, 2025

cmsbuild added tests-started and removed requires-external tests-approved labels Oct 15, 2025

cmsbuild added tests-approved and removed tests-started labels Oct 15, 2025

cmsbuild added orp-approved and removed orp-pending labels Oct 15, 2025

cmsbuild merged commit 1438756 into cms-sw:master Oct 15, 2025
22 checks passed

iarspider deleted the patch-17 branch October 16, 2025 08:39

[ROOT6_X] Fix deprecated-literal-operator warning #49154

[ROOT6_X] Fix deprecated-literal-operator warning #49154

Uh oh!

Conversation

iarspider commented Oct 14, 2025

PR description:

PR validation:

Uh oh!

iarspider commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Oct 14, 2025

Uh oh!

cmsbuild commented Oct 14, 2025

Uh oh!

iarspider commented Oct 14, 2025

Uh oh!

cmsbuild commented Oct 14, 2025

Uh oh!

iarspider commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Oct 14, 2025

Comparison Summary

Uh oh!

iarspider commented Oct 14, 2025

Uh oh!

cmsbuild commented Oct 14, 2025

Comparison Summary

Uh oh!

iarspider commented Oct 14, 2025

Uh oh!

cmsbuild commented Oct 14, 2025

Uh oh!

iarspider commented Oct 15, 2025

Uh oh!

jfernan2 commented Oct 15, 2025

Uh oh!

cmsbuild commented Oct 15, 2025

Uh oh!

smuzaffar commented Oct 15, 2025

Uh oh!

cmsbuild commented Oct 15, 2025

Comparison Summary

Uh oh!

mandrenguyen commented Oct 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

iarspider commented Oct 14, 2025 •

edited

Loading

cmsbuild commented Oct 14, 2025 •

edited

Loading

iarspider commented Oct 14, 2025 •

edited

Loading