Skip to content

Additions to scouting DQM with the ScoutingCollectionMonitor and a new ScoutingMuonPropertiesAnalyzer#49130

Merged
cmsbuild merged 15 commits intocms-sw:masterfrom
cms-ngt-hlt:AdditionsScoutingDQM
Oct 14, 2025
Merged

Additions to scouting DQM with the ScoutingCollectionMonitor and a new ScoutingMuonPropertiesAnalyzer#49130
cmsbuild merged 15 commits intocms-sw:masterfrom
cms-ngt-hlt:AdditionsScoutingDQM

Conversation

@jprendi
Copy link
Contributor

@jprendi jprendi commented Oct 10, 2025

PR description:

This PR introduces a new DQMEDAnalyzer ScoutingMuonPropertiesAnalyzer for further monitoring of the scouting muon collection complimenting ScoutingCollectionMonitor and additions to the ScoutingCollectionMonitor module.

For DQM/HLTEvF/plugins/ScoutingCollectionMonitor.cc and in DQM/Integration/python/clients/scouting_dqm_sourceclient-live_cfg.py, we enable monitoring of multiplicity for all the scouting objects but also IP w.r.t beam spot or dxy, dz w.r.t BS.

We also turned off monitoring of the calorechits in <= 2024 in DQM/HLTEvF/python/ScoutingCollectionMonitor_cfi.py

HLTriggerOffline/Scouting/plugins/ScoutingMuonPropertiesAnalyzer.cc and HLTriggerOffline/Scouting/python/ScoutingMuonPropertiesMonitoring_cfi.py is new for the scouting muon properties analyzer.

DQM/HLTEvF/python/ScoutingMuonMonitoring_cff.py, DQMOffline/HLTScouting/python/HLTScoutingDqmOffline_cff.py and HLTriggerOffline/Scouting/plugins/BuildFile.xml were adapted to include the ScoutingMuonPropertiesAnalyzer.

The scouting muon properties analyzer is based of the work done by @prijb here.

PR validation:

We started out with:

cmsrel CMSSW_16_0_X_2025-10-08-2300

cd CMSSW_16_0_X_2025-10-08-2300/src

cmsenv
git cms-addpkg DQM/HLTEvF DQM/Integration DQMOffline/HLTScouting HLTriggerOffline/Scouting
scram b -j
scram b code-format && scram b code-checks
scram b -j


and validated via using the input files at cms-data/DQM-Integration#12 by copying them inside the DQM/Integration/data/run392642 folder and then running:

cmsRun DQM/Integration/python/clients/scouting_dqm_sourceclient-live_cfg.py runInputDir=DQM/Integration/data/ runNumber=392642 scanOnce=True

followed by subsquent inspection of the output histograms.

We also tested the workflow via:


runTheMatrix.py -l  145.415 -t 4 -j 8


Running git cms-checkdeps -a -A shows further dependencies to DQMOffline/Configuration.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is not a backport but will be backported to 15_0_X and 15_1_X.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 10, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49130/46412

  • Found files with invalid states:
    • DQM/HLTEvF/python/ScoutingMuonPropertiesMonitoring_cff.py:

@jprendi
Copy link
Contributor Author

jprendi commented Oct 10, 2025

type ngt

@mmusich
Copy link
Contributor

mmusich commented Oct 10, 2025

test parameters:

  • addpkg = DQM/Integration
  • workflow = 145.415

@mmusich
Copy link
Contributor

mmusich commented Oct 10, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jprendi for master.

It involves the following packages:

  • DQM/HLTEvF (dqm, hlt)
  • DQM/Integration (dqm)
  • DQMOffline/HLTScouting (dqm)
  • HLTriggerOffline/Scouting (dqm)

@Martin-Grunewald, @ctarricone, @gabrielmscampos, @mmusich, @nothingface0, @rseidita can you please review it and eventually sign? Thanks.
@batinkov, @francescobrivio, @missirol, @mmusich, @mtosi, @rociovilar, @threus this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49130/46447

  • Found files with invalid states:
    • DQM/HLTEvF/python/ScoutingMuonPropertiesMonitoring_cff.py:

@cmsbuild
Copy link
Contributor

Pull request #49130 was updated. @Martin-Grunewald, @cmsbuild, @ctarricone, @gabrielmscampos, @mmusich, @nothingface0, @rseidita can you please check and sign again.

@gabrielmscampos
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 48KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1a5dad/48663/summary.html
COMMIT: ea5f0e5
CMSSW: CMSSW_16_0_X_2025-10-14-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49130/48663/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 52
  • DQMHistoTests: Total histograms compared: 4035815
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4035792
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 27.728 KiB( 51 files compared)
  • DQMHistoSizes: changed ( 2025.016005 ): 27.728 KiB HLT/ScoutingOffline
  • Checked 222 log files, 192 edm output root files, 52 DQM output files
  • TriggerResults: no differences found

@gabrielmscampos
Copy link
Member

+dqm

@mmusich
Copy link
Contributor

mmusich commented Oct 14, 2025

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit bfcf87d into cms-sw:master Oct 14, 2025
11 checks passed
@mmusich mmusich deleted the AdditionsScoutingDQM branch October 14, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants