Skip to content

Conversation

@akritkbehera
Copy link
Contributor

@akritkbehera akritkbehera commented Oct 8, 2025

PR description:

This PR performs minor cleanup and header corrections across a few packages.

  • Dropped #include "DataFormats/Math/interface/Vector3D.h" from files in PhysicsTools/CandUtils/interface/{EventShapeVariables.h,Thrust.h}, as it’s no longer required.
  • Updated PhysicsTools/PatExamples/interface/BTagPerformance.h to explicitly include

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2025

@akritkbehera akritkbehera marked this pull request as ready for review October 8, 2025 14:50
@@ -1,4 +1,5 @@
<use name="DataFormats/Candidate"/>
<use name="DataFormats/Math"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akritkbehera , looks like DataFormats/Math is needed as following files in PhysicsTools/CandUtils/interface have included DataFormats/Math/interface/Vector3D.h . Looks like DataFormats/Math/interface/Vector3D.h is actually not needed any we can cleanup the file in [a] and drop the include statement. This also means we do not need this change in BuildFile.xml here

[a]

EventShapeVariables.h:#include "DataFormats/Math/interface/Vector3D.h"
Thrust.h:#include "DataFormats/Math/interface/Vector3D.h"

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2025

REMINDER @mandrenguyen, @ftenchini, @sextonkennedy: This PR was tested with cms-sw/cmsdist#10110, please check if they should be merged together

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2025

A new Pull Request was created by @akritkbehera for master.

It involves the following packages:

  • PhysicsTools/CandUtils (analysis)
  • PhysicsTools/PatExamples (analysis)

@cmsbuild, @tvami can you please review it and eventually sign? Thanks.
@AlexDeMoor, @Ming-Yan, @Senphy, @andrzejnovak, @castaned, @pavlo-kashko, @philippgadow this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2025

Pull request #49104 was updated. @cmsbuild, @tvami can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2025

Pull request #49104 was updated. @cmsbuild, @tvami can you please check and sign again.

@akritkbehera
Copy link
Contributor Author

Please test

@tvami
Copy link
Contributor

tvami commented Oct 9, 2025

@akritkbehera please make the PR title a little bit more descriptive, right now it seems like it applies to all cmssw-sw

@smuzaffar
Copy link
Contributor

@akritkbehera , please squash these commits too

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2025

Pull request #49104 was updated. @cmsbuild, @tvami can you please check and sign again.

@akritkbehera
Copy link
Contributor Author

Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2025

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7fcc5b/48568/summary.html
COMMIT: 7f06037
CMSSW: CMSSW_16_0_X_2025-10-09-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49104/48568/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3940073
  • DQMHistoTests: Total failures: 481
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3939572
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 218 log files, 188 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Oct 9, 2025

@akritkbehera I see you changed the commit name, that sounds good to me, but I meant to have the same for the PR title

@akritkbehera akritkbehera changed the title Fixes for failure due to HeaderConsistency scram b check-headers Drop Unneeded Vector3D Includes and Update BTagPerformance.h Oct 9, 2025
@akritkbehera akritkbehera changed the title Drop Unneeded Vector3D Includes and Update BTagPerformance.h Drop not used Vector3D in header and Update BTagPerformance.h Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants