-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Drop not used Vector3D in header and Update BTagPerformance.h #49104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49104/46341 |
PhysicsTools/CandUtils/BuildFile.xml
Outdated
| @@ -1,4 +1,5 @@ | |||
| <use name="DataFormats/Candidate"/> | |||
| <use name="DataFormats/Math"/> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akritkbehera , looks like DataFormats/Math is needed as following files in PhysicsTools/CandUtils/interface have included DataFormats/Math/interface/Vector3D.h . Looks like DataFormats/Math/interface/Vector3D.h is actually not needed any we can cleanup the file in [a] and drop the include statement. This also means we do not need this change in BuildFile.xml here
[a]
EventShapeVariables.h:#include "DataFormats/Math/interface/Vector3D.h"
Thrust.h:#include "DataFormats/Math/interface/Vector3D.h"
|
REMINDER @mandrenguyen, @ftenchini, @sextonkennedy: This PR was tested with cms-sw/cmsdist#10110, please check if they should be merged together |
|
A new Pull Request was created by @akritkbehera for master. It involves the following packages:
@cmsbuild, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49104/46367 |
b6846e9 to
21eb020
Compare
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49104/46368 |
|
Please test |
|
@akritkbehera please make the PR title a little bit more descriptive, right now it seems like it applies to all cmssw-sw |
|
@akritkbehera , please squash these commits too |
21eb020 to
7f06037
Compare
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49104/46371 |
|
Please test |
|
+1 Size: This PR adds an extra 24KB to repository Comparison SummarySummary:
|
|
@akritkbehera I see you changed the commit name, that sounds good to me, but I meant to have the same for the PR title |
PR description:
This PR performs minor cleanup and header corrections across a few packages.