[DQM]: Improvements to ZDC DQM

[hjbossi]

PR description:

This PR implements two of the 3 foreseen DQM improvements for 2025.

Changing FSC information to be more informative
Adding fine timing information
The remaining change still to come is to implement a plot to check emulated information vs. unpacked data information.

PR validation:

This PR was tested by running the DQM locally using 2025 OO raw data. This process is documented here.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is intended for HI data-taking in 2025 and will need to be backported to 15_1_X.

Tagging HIN colleagues: @mandrenguyen
Tagging HCAL colleagues:@abdoulline @akhukhun @salimcerci, @denizsun
Tagging FSC colleagues: @michael-pitt

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48978/46154

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48978/46154/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48978/46154/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[hjbossi]

As a note, this PR assumes a single-sided FSC, which will not be the case in 2025. Subsequent updates to the DQM will need to be performed to synchronize with these changes.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48978/46155

[cmsbuild]

A new Pull Request was created by @hjbossi for master.

It involves the following packages:

• DQM/HcalTasks (dqm)

@antoniovagnerini, @cmsbuild, @ctarricone, @gabrielmscampos, @nothingface0, @rseidita can you please review it and eventually sign? Thanks.
@DryRun, @abdoulline, @bsunanda, @denizsun, @salimcerci this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[nothingface0]

@hjbossi Does this affect online DQM as well?

[hjbossi]

Hi @nothingface0, yes this would also impact the online DQM and is intended to be used to monitor conditions etc during data-taking.

[nothingface0]

test parameters:

• addpkg = DQM/Integration

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48978/46170

• There are other open Pull requests which might conflict with changes you have proposed:
  • File DQM/HcalTasks/plugins/ZDCQIE10Task.cc modified in PR(s): Rawp v3 #48992

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48978/46170/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48978/46170/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[nothingface0]

@hjbossi is the PR ready, or do you have more changes planned to include?

[hjbossi]

Hi @nothingface0 , there were some comments made by HCAL colleagues (not sure this link is accessible without HCAL permissions, but the comments are here: https://gitlab.cern.ch/cmshcal/docs/-/issues/303). I will have to resolve these comments and push a new version.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48978/46233

[cmsbuild]

Pull request #48978 was updated. @cmsbuild, @ctarricone, @gabrielmscampos, @nothingface0, @rseidita can you please check and sign again.

[gabrielmscampos]

@cmsbuild please test

[cmsbuild]

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-58b3e7/48371/summary.html
COMMIT: 4f548cc
CMSSW: CMSSW_16_0_X_2025-09-29-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48978/48371/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3922620
• DQMHistoTests: Total failures: 23
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3922577
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 218 log files, 188 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

urgent
Needed for 15_1_0 for heavy-ion data taking

[gabrielmscampos]

+dqm

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1