Skip to content

Conversation

@hjbossi
Copy link
Contributor

@hjbossi hjbossi commented Sep 23, 2025

PR description:

This PR implements two of the 3 foreseen DQM improvements for 2025.

  • Changing FSC information to be more informative
  • Adding fine timing information

The remaining change still to come is to implement a plot to check emulated information vs. unpacked data information.

PR validation:

This PR was tested by running the DQM locally using 2025 OO raw data. This process is documented here.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is a backport of #48978 as it is intended for HI data taking in 2025.

Tagging HIN colleagues: @mandrenguyen
Tagging HCAL colleagues:@abdoulline @akhukhun @salimcerci, @denizsun
Tagging FSC colleagues: @michael-pitt

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 23, 2025

A new Pull Request was created by @hjbossi for CMSSW_15_1_X.

It involves the following packages:

  • DQM/HcalTasks (dqm)

@antoniovagnerini, @cmsbuild, @ctarricone, @gabrielmscampos, @nothingface0, @rseidita can you please review it and eventually sign? Thanks.
@DryRun, @abdoulline, @bsunanda, @denizsun, @salimcerci this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 23, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

Pull request #48977 was updated. @antoniovagnerini, @cmsbuild, @ctarricone, @gabrielmscampos, @nothingface0, @rseidita can you please check and sign again.

@nothingface0
Copy link
Contributor

backport of #48978

@nothingface0
Copy link
Contributor

test parameters:

  • addpkg = DQM/Integration

@cmsbuild
Copy link
Contributor

Pull request #48977 was updated. @antoniovagnerini, @cmsbuild, @ctarricone, @gabrielmscampos, @nothingface0, @rseidita can you please check and sign again.

@nothingface0
Copy link
Contributor

please test

@nothingface0
Copy link
Contributor

please abort

@nothingface0
Copy link
Contributor

nothingface0 commented Sep 25, 2025

code-checks

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48977/46171

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

Pull request #48977 was updated. @cmsbuild, @ctarricone, @gabrielmscampos, @nothingface0, @rseidita can you please check and sign again.

@nothingface0
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-db45b2/48286/summary.html
COMMIT: f003106
CMSSW: CMSSW_15_1_X_2025-09-25-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48977/48286/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4113751
  • DQMHistoTests: Total failures: 26
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4113705
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

Pull request #48977 was updated. @cmsbuild, @ctarricone, @gabrielmscampos, @nothingface0, @rseidita can you please check and sign again.

@gabrielmscampos
Copy link
Member

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-db45b2/48370/summary.html
COMMIT: 5ee436a
CMSSW: CMSSW_15_1_X_2025-09-29-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48977/48370/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4113751
  • DQMHistoTests: Total failures: 21
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4113710
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

urgent
Needed for 15_1_0 for heavy-ion data taking

@gabrielmscampos
Copy link
Member

+dqm

  • Tests OK in playback machines at P5, using 15_1_0_pre6 as the baseline.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ff643f8 into cms-sw:CMSSW_15_1_X Sep 30, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants