Removed workaround for illegal memory access #48854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
cms-bot internal usage |
Contributor
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48854/46002
|
Contributor
|
A new Pull Request was created by @leobeltra for master. It involves the following packages:
@cmsbuild, @fwyzard, @jfernan2, @makortel, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Contributor
|
allow @leobeltra test rights |
Author
|
please test |
Contributor
|
-1 Failed Tests: Build BuildI found compilation error when building: Copying tmp/el8_amd64_gcc12/src/RecoVertex/PixelVertexFinding/plugins/RecoPixelVertexingPixelVertexFindingPluginsPortableROCmAsync/libRecoPixelVertexingPixelVertexFindingPluginsPortableROCmAsync_rocm.a to productstore area: Copying tmp/el8_amd64_gcc12/src/RecoVertex/PixelVertexFinding/test/deviceVertexFinderByDensity_tROCmAsync/libdeviceVertexFinderByDensity_tROCmAsync_rocm.a to productstore area: cp: cannot stat 'tmp/el8_amd64_gcc12/src/RecoVertex/PixelVertexFinding/plugins/RecoPixelVertexingPixelVertexFindingPluginsPortableROCmAsync/libRecoPixelVertexingPixelVertexFindingPluginsPortableROCmAsync_rocm.a': No such file or directory >> Deleted: tmp/el8_amd64_gcc12/src/RecoVertex/PixelVertexFinding/plugins/RecoPixelVertexingPixelVertexFindingPluginsPortableROCmAsync/libRecoPixelVertexingPixelVertexFindingPluginsPortableROCmAsync_rocm.a Copying tmp/el8_amd64_gcc12/src/RecoVertex/PixelVertexFinding/test/deviceVertexFinderDBSCAN_tROCmAsync/libdeviceVertexFinderDBSCAN_tROCmAsync_rocm.a to productstore area: gmake: *** [config/SCRAM/GMake/Makefile.rules:1920: tmp/el8_amd64_gcc12/src/RecoVertex/PixelVertexFinding/plugins/RecoPixelVertexingPixelVertexFindingPluginsPortableROCmAsync/libRecoPixelVertexingPixelVertexFindingPluginsPortableROCmAsync_rocm.a] Error 1 cp: cannot stat 'tmp/el8_amd64_gcc12/src/RecoVertex/PixelVertexFinding/test/deviceVertexFinderByDensity_tROCmAsync/libdeviceVertexFinderByDensity_tROCmAsync_rocm.a': No such file or directory cp: cannot stat 'tmp/el8_amd64_gcc12/src/RecoVertex/PixelVertexFinding/test/deviceVertexFinderDBSCAN_tROCmAsync/libdeviceVertexFinderDBSCAN_tROCmAsync_rocm.a': No such file or directory >> Deleted: tmp/el8_amd64_gcc12/src/RecoVertex/PixelVertexFinding/test/deviceVertexFinderByDensity_tROCmAsync/libdeviceVertexFinderByDensity_tROCmAsync_rocm.a gmake: *** [config/SCRAM/GMake/Makefile.rules:1920: tmp/el8_amd64_gcc12/src/RecoVertex/PixelVertexFinding/test/deviceVertexFinderByDensity_tROCmAsync/libdeviceVertexFinderByDensity_tROCmAsync_rocm.a] Error 1 >> Deleted: tmp/el8_amd64_gcc12/src/RecoVertex/PixelVertexFinding/test/deviceVertexFinderDBSCAN_tROCmAsync/libdeviceVertexFinderDBSCAN_tROCmAsync_rocm.a |
fwyzard
reviewed
Sep 5, 2025
Contributor
There was a problem hiding this comment.
Please do not remove this file.
Contributor
|
enable gpu |
leobeltra
force-pushed
the
workaround#47931_removed
branch
from
d33308f to
44f9b6e
Compare
cmsbuild
added
tests-pending
code-checks-pending
and removed
tests-rejected
code-checks-approved
labels
Contributor
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48854/46008
|
leobeltra
force-pushed
the
workaround#47931_removed
branch
from
44f9b6e to
01bde69
Compare
Contributor
|
Pull request #48854 was updated. @jfernan2, @mandrenguyen can you please check and sign again. |
Contributor
|
+heterogeneous The changes look OK, assuming all the tests pass. |
Contributor
|
assign heterogeneous :-) |
Contributor
Contributor
|
+1 Size: This PR adds an extra 28KB to repository Comparison SummarySummary:
AMD_MI300X Comparison SummarySummary:
AMD_W7900 Comparison SummarySummary:
NVIDIA_H100 Comparison SummarySummary:
NVIDIA_L40S Comparison SummarySummary:
NVIDIA_T4 Comparison SummarySummary:
|
Contributor
|
+1 |
Author
|
kind ping |
Contributor
|
unhold |
Contributor
|
please test Let's refresh the test results since they are over two weeks old. |
Contributor
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2) |
Contributor
|
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
AMD_MI300X Comparison SummarySummary:
AMD_W7900 Comparison SummarySummary:
NVIDIA_H100 Comparison SummarySummary:
NVIDIA_L40S Comparison SummarySummary:
NVIDIA_T4 Comparison SummarySummary:
|
Contributor
|
+1 |
This was referenced Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
This PR removes the workaround introduced in #47931 for the issue in GPU relvals found in #47808.
The problem has been addressed by reverting some changes introduced in #47306. In particular,
size_has been deleted fromSoAParametersImpl.When CUDA 13.1 is released, it will be possible to add
size_for other purposes, and the bug should be fixed (since a bug report has been opened and closed).PR validation:
Workflows 12834.402 and 29661.402 work.