-
Notifications
You must be signed in to change notification settings - Fork 4.6k
TICLv5 Adjust Linking step #48851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TICLv5 Adjust Linking step #48851
Conversation
|
cms-bot internal usage |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48851/45991 ERROR: Unable to merge PR. See log https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48851/45991/cms-checkout-topic.log |
e0895f4 to
d41fcc2
Compare
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48851/45992
|
|
A new Pull Request was created by @waredjeb for master. It involves the following packages:
@Martin-Grunewald, @Moanwar, @cmsbuild, @jfernan2, @mandrenguyen, @mmusich, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
test parameters:
|
|
please test |
| if (muonRef.isNonnull() and muonRef->isGlobalMuon()) { | ||
| // create muon candidate | ||
| edm::Ptr<Trackster> tracksterPtr; | ||
| TICLCandidate chargedCandidate(trackPtr, tracksterPtr); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So just to check, this is where you discarded the alone track, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, here we just produce muons, but the other tracks are discarded, at least for now
|
-1 Failed Tests: RelVals RelValsValueError: Undefined workflows: 29696.203, 29896.203
|
under which matrix are these workflows? I can't find them under the upgrade one either. |
see https://github.com/cms-sw/cmssw/pull/48801/files#r2325506904. |
|
+hlt
|
|
+1 |
|
+pdmv |
|
+Upgrade |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
|
Milestone for this pull request has been moved to CMSSW_16_0_X. Please open a backport if it should also go in to CMSSW_15_1_X. |
|
+1 |
PR description
This PR addresse the issue reported by the NGT group on Jet performance with TICLv5, showing a disruptive increase in the jet energy response. See presentation at HLT upgrade [1] from slide 15 with the comparison between TICLv4 and TICLv5.
This PR introduces a first stage of changes:
Testing
The PR has been tested on CMSSW_15_1_0_pre5. Physics validation has been performed exploiting the HLT Jet Validation.
To evaluate the effectiveness of the changes, a comparison between Baseline and PR has been performed on a QCD sample in 200 PU, where the energy regression was turned off (as the regression is the other issue that will be fixed in a future PR).
Below some plots where on the left you have the Baseline while on the right the PR changes have been applied
pT Response with energy correction
Distributions after the changes look more healthy
Fake Rate
Major reduction in the jet fake rate in the [1.5,3.0] pseudorapidity region
HGCAL/TICL side
These changes leads to a mild drop in the overall efficiency. Tested on a pion sample in 200PU
These changes should be tested on workflow enabling the TICLv5 procModifier:
@AuroraPerego @felicepantaleo
[1] https://indico.cern.ch/event/1578363/contributions/6650118/attachments/3119987/5532471/2025_08_19%20-%20Jet%20Validation%20HLT.pdf