Skip to content

Conversation

@JunwonTomOh
Copy link
Contributor

@JunwonTomOh JunwonTomOh commented Aug 15, 2025

This PR adds JSON data files to support the externalization of constants used by the L1 MET emulator and the JUMP algorithm, in support of: cms-sw/cmssw#48308.

In particular:

L1Trigger/Phase2L1ParticleFlow/data/met/l1met_ptphi2pxpy_poly2_v1.json

2nd-order polynomial coefficients for the pt,phi→px,py projection

phi_edges (radians, 16 bins → 17 edges), cos2.par{0,1,2}, sin2.par{0,1,2}

includes version, description, and phi_bins metadata

L1Trigger/Phase2L1ParticleFlow/data/met/l1jump_jer_v1.json

per-|η| linear JER model for JUMP: σ(pT)[GeV] = eta.par0(ηbin)·pT + eta.par1(ηbin)

|η| boundaries at 1.3, 1.7, 2.5, 3.0 (defining 5 bins), arrays a and b

includes version and description metadata

@cmsbuild
Copy link
Contributor

Pull request #9 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 15, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2025

A new Pull Request was created by @JunwonTomOh for branch master.

@BenjaminRS, @Moanwar, @akritkbehera, @cmsbuild, @iarspider, @quinnanm, @smuzaffar, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

REMINDER @ftenchini, @mandrenguyen, @sextonkennedy: This PR was tested with cms-sw/cmssw#48308, please check if they should be merged together

@BenjaminRS
Copy link

test parameters:

@BenjaminRS
Copy link

please test

@mandrenguyen
Copy link

please test
let's just clean up this bot failure

@mandrenguyen
Copy link

+1

@mandrenguyen
Copy link

merge

@cmsbuild cmsbuild merged commit 2d9c189 into cms-data:master Sep 10, 2025
9 of 10 checks passed
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d1d3d/48048/summary.html
COMMIT: 0599bf8
CMSSW: CMSSW_16_0_X_2025-09-10-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/L1Trigger-Phase2L1ParticleFlow/9/48048/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d1d3d/48048/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d1d3d/48048/git-merge-result

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4113751
  • DQMHistoTests: Total failures: 19
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4113712
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link

Integration builds are failing. It seems they are not able to find the data. See for example here:
https://cmssdt.cern.ch/SDT/cgi-bin/logreader/el8_amd64_gcc12/CMSSW_16_0_X_2025-09-10-2300/pyRelValMatrixLogs/run/23634.0_TTbar_14TeV+Run4D95/step2_TTbar_14TeV+Run4D95.log#/

@mmusich
Copy link

mmusich commented Sep 11, 2025

Integration builds are failing. It seems they are not able to find the data.

I think the issue might be explained at cms-sw/cmssw#48897 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants