-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Add ZEE_14 workflows to TICLv5 procModifier #48801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48801/45904
|
|
A new Pull Request was created by @waredjeb for master. It involves the following packages:
@AdrianoDee, @Moanwar, @cmsbuild, @DickyChant, @miquork, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
test parameters: |
|
@cmsbuild please test |
|
+1 Size: This PR adds an extra 40KB to repository Comparison SummarySummary:
|
|
+Upgrade |
|
Kind ping @cms-sw/pdmv-l2, could you please check this and approve? Thanks! |
|
+pdmv |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
| return (fragment=="TTbar_14TeV" or 'CloseByP' in fragment or 'Eta1p7_2p7' in fragment) and 'Run4' in key | ||
| selected_fragments = ["TTbar_14TeV", "CloseByP", "Eta1p7_2p7", "ZEE_14"] | ||
| return (fragment in selected_fragments) and 'Run4' in key |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as @AuroraPerego pointed out, now you will accept only exact matches here, which for 29646.203_ZEE_14+Run4D110_ticl_v5 works, but for the other ones (e.g. 29696.0_CloseByPGun_CE_E_Front_120um+Run4D110) will not.
Adding ZEE_14 workflow to TICLv5 procModifier targeting testing for TICL-DNNSuperClustering
In the case tests are needed on these particular workflows, here are the wf numbers: