Skip to content

Conversation

@waredjeb
Copy link
Contributor

@waredjeb waredjeb commented Aug 26, 2025

Adding ZEE_14 workflow to TICLv5 procModifier targeting testing for TICL-DNNSuperClustering

In the case tests are needed on these particular workflows, here are the wf numbers:

  • 29646.203
  • 29846.203

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 26, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48801/45904

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @waredjeb for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@AdrianoDee, @Moanwar, @cmsbuild, @DickyChant, @miquork, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @missirol, @slomeo this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@Moanwar
Copy link
Contributor

Moanwar commented Aug 26, 2025

test parameters:
workflow_opts= -w upgrade
workflow = 29646.203, 29846.203

@Moanwar
Copy link
Contributor

Moanwar commented Aug 26, 2025

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9517ae/47862/summary.html
COMMIT: be6c884
CMSSW: CMSSW_15_1_X_2025-08-26-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48801/47862/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 7 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4113272
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4113249
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@Moanwar
Copy link
Contributor

Moanwar commented Aug 26, 2025

+Upgrade

@Moanwar
Copy link
Contributor

Moanwar commented Aug 27, 2025

Kind ping @cms-sw/pdmv-l2, could you please check this and approve? Thanks!

@AdrianoDee
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 99e4676 into cms-sw:master Aug 27, 2025
11 checks passed
Comment on lines -859 to +860
return (fragment=="TTbar_14TeV" or 'CloseByP' in fragment or 'Eta1p7_2p7' in fragment) and 'Run4' in key
selected_fragments = ["TTbar_14TeV", "CloseByP", "Eta1p7_2p7", "ZEE_14"]
return (fragment in selected_fragments) and 'Run4' in key
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as @AuroraPerego pointed out, now you will accept only exact matches here, which for 29646.203_ZEE_14+Run4D110_ticl_v5 works, but for the other ones (e.g. 29696.0_CloseByPGun_CE_E_Front_120um+Run4D110) will not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants