Updated SuperclusterDNN v3 for superclustering in TICLv5 #48811

gsokmen · 2025-08-27T12:02:10Z

This PR introduces a new version (v3) of the SuperclusterDNN to be used for superclustering in TICLv5. This PR includes updates to the previous DNN model as well as the superclustering algorithm. The model and algorithm are used for reconstructing electromagnetic objects within TICL.

-This PR needs to be tested with the following cms-data PR: cms-data/RecoHGCal-TICL#9

-It needs to be tested with the following workflows
. 29646.203
. 29846.203

-Validation plots are attached.
Validation_SuperclusterDNN_v3_4Sept_GSokmen.pdf

@waredjeb @felicepantaleo @sameasy

cmsbuild · 2025-08-27T12:02:36Z

cms-bot internal usage

cmsbuild · 2025-08-27T12:05:14Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48811/45919

There are other open Pull requests which might conflict with changes you have proposed:
- File RecoHGCal/TICL/plugins/SuperclusteringSampleDumper.cc modified in PR(s): Add directories for TICL-EGM code development #48319
- File RecoHGCal/TICL/plugins/TracksterLinkingbySuperClusteringDNN.cc modified in PR(s): Add directories for TICL-EGM code development #48319
- File RecoHGCal/TICL/src/SuperclusteringDNNInputs.cc modified in PR(s): Add directories for TICL-EGM code development #48319

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48811/45919/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48811/45919/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

felicepantaleo · 2025-08-27T12:10:09Z

allow @waredjeb test rights

felicepantaleo · 2025-08-27T12:10:41Z

allow @sameasy test rights

felicepantaleo · 2025-08-27T12:10:47Z

type hgcal

felicepantaleo · 2025-08-27T12:11:06Z

test parameters:
pull_request = cms-data/RecoHGCal-TICL#9
workflow_opts = -w upgrade
workflows = 29646.203,29846.203

cmsbuild · 2025-08-27T12:59:48Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48811/45921

There are other open Pull requests which might conflict with changes you have proposed:
- File RecoHGCal/TICL/plugins/SuperclusteringSampleDumper.cc modified in PR(s): Add directories for TICL-EGM code development #48319
- File RecoHGCal/TICL/plugins/TracksterLinkingbySuperClusteringDNN.cc modified in PR(s): Add directories for TICL-EGM code development #48319
- File RecoHGCal/TICL/src/SuperclusteringDNNInputs.cc modified in PR(s): Add directories for TICL-EGM code development #48319

waredjeb · 2025-10-08T08:03:37Z

@mmusich looks like we don't have the reproducibility problem anymore after the merging of #49023
what do you think?

mmusich · 2025-10-08T08:10:18Z

what do you think?

there is too much churn going on in tests (due also to #49073). Let's wait to have the solution to that merged and run a final round of tests.

waredjeb · 2025-10-08T08:11:33Z

what do you think?

there is too much churn going on in tests (due also to #49073). Let's wait to have the solution to that merged and run a final round of tests.

ok perfect, thanks!

mmusich · 2025-10-12T08:52:49Z

@cmsbuild, please test

cmsbuild · 2025-10-12T13:58:12Z

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5bb023/48618/summary.html
COMMIT: f70dfb5
CMSSW: CMSSW_16_0_X_2025-10-12-0000/el8_amd64_gcc13
Additional Tests: HLT_P2_INTEGRATION,HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48811/48618/install.sh to create a dev area with all the needed externals and cmssw changes.

HLT P2 Timing: chart

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 18 differences found in the comparisons
DQMHistoTests: Total files compared: 64
DQMHistoTests: Total histograms compared: 4293829
DQMHistoTests: Total failures: 59
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4293750
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 63 files compared)
Checked 263 log files, 223 edm output root files, 64 DQM output files
TriggerResults: found differences in 1 / 62 workflows

waredjeb · 2025-10-13T08:58:55Z

Hi @mmusich , looks like we don't have the differences anymore, what do you think?

mmusich · 2025-10-13T09:03:46Z

TriggerResults: found differences in 1 / 62 workflows

there are changes in the trigger results (in L1 algos?). Probably not related though.

mmusich · 2025-10-13T09:05:18Z

+hlt

cmsbuild · 2025-10-13T09:05:48Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-data/RecoHGCal-TICL#9

mmusich · 2025-10-14T14:44:36Z

there are changes in the trigger results (in L1 algos?). Probably not related though.

for completeness I re-run the tests in a vacuum at #49063 (comment) and I don't see the same. I wonder if it reproduces here.

waredjeb · 2025-10-14T14:53:43Z

there are changes in the trigger results (in L1 algos?). Probably not related though.

for completeness I re-run the tests in a vacuum at #49063 (comment) and I don't see the same. I wonder if it reproduces here.

If I understood correctly the differences, they are shown in workflow 29634.0 which is the default (no procModifiers) with TICLv4. This PR does not touch anything in TICLv4 so I would guess it should not be related to this PR. But if you have doubts I can try to run additional tests

mmusich · 2025-10-14T14:54:43Z

@cmsbuild, please test

cmsbuild · 2025-10-14T19:26:43Z

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5bb023/48680/summary.html
COMMIT: f70dfb5
CMSSW: CMSSW_16_0_X_2025-10-14-1100/el8_amd64_gcc13
Additional Tests: HLT_P2_INTEGRATION,HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48811/48680/install.sh to create a dev area with all the needed externals and cmssw changes.

HLT P2 Timing: chart

Comparison Summary

Summary:

You potentially added 12 lines to the logs
Reco comparison results: 12 differences found in the comparisons
DQMHistoTests: Total files compared: 64
DQMHistoTests: Total histograms compared: 4293829
DQMHistoTests: Total failures: 14
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4293795
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 63 files compared)
Checked 263 log files, 223 edm output root files, 64 DQM output files
TriggerResults: no differences found

mandrenguyen · 2025-10-15T19:46:28Z

+1

gsokmen and others added 5 commits August 26, 2025 19:00

DNN v3 with timing info, corrected seed pT

ad12e52

Fixing superclustering logic

e48b573

changing scls config

cb9937e

modified SCS and minor changes in the SuperclusteringDNNInputs

65e32db

Update model name in config file

6307d9d

cmsbuild added this to the CMSSW_15_1_X milestone Aug 27, 2025

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending upgrade-pending code-checks-pending labels Aug 27, 2025

cmsbuild added code-checks-rejected and removed code-checks-pending labels Aug 27, 2025

cmsbuild added the allow-waredjeb label Aug 27, 2025

cmsbuild added hgcal allow-sameasy labels Aug 27, 2025

cmsbuild added the requires-external label Aug 27, 2025

Adding code format

1526f0d

cmsbuild added code-checks-pending and removed code-checks-rejected labels Aug 27, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 27, 2025

cmsbuild added tests-started and removed tests-approved labels Oct 12, 2025

cmsbuild added tests-approved and removed tests-started labels Oct 12, 2025

cmsbuild added hlt-approved fully-signed and removed hlt-pending pending-signatures labels Oct 13, 2025

cmsbuild mentioned this pull request Oct 13, 2025

Adding new version of SuperclusterDNN model v3 cms-data/RecoHGCal-TICL#9

Merged

cmsbuild added tests-started and removed tests-approved labels Oct 14, 2025

cmsbuild added tests-approved and removed tests-started labels Oct 14, 2025

cmsbuild added orp-approved and removed orp-pending labels Oct 15, 2025

cmsbuild merged commit 859386e into cms-sw:master Oct 15, 2025
22 checks passed

Updated SuperclusterDNN v3 for superclustering in TICLv5 #48811

Updated SuperclusterDNN v3 for superclustering in TICLv5 #48811

Uh oh!

Conversation

gsokmen commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Aug 27, 2025

Uh oh!

felicepantaleo commented Aug 27, 2025

Uh oh!

felicepantaleo commented Aug 27, 2025

Uh oh!

felicepantaleo commented Aug 27, 2025

Uh oh!

felicepantaleo commented Aug 27, 2025

Uh oh!

cmsbuild commented Aug 27, 2025

Uh oh!

waredjeb commented Oct 8, 2025

Uh oh!

mmusich commented Oct 8, 2025

Uh oh!

waredjeb commented Oct 8, 2025

Uh oh!

mmusich commented Oct 12, 2025

Uh oh!

cmsbuild commented Oct 12, 2025

Comparison Summary

Uh oh!

waredjeb commented Oct 13, 2025

Uh oh!

mmusich commented Oct 13, 2025

Uh oh!

mmusich commented Oct 13, 2025

Uh oh!

cmsbuild commented Oct 13, 2025

Uh oh!

mmusich commented Oct 14, 2025

Uh oh!

waredjeb commented Oct 14, 2025

Uh oh!

mmusich commented Oct 14, 2025

Uh oh!

cmsbuild commented Oct 14, 2025

Comparison Summary

Uh oh!

mandrenguyen commented Oct 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

gsokmen commented Aug 27, 2025 •

edited

Loading

cmsbuild commented Aug 27, 2025 •

edited

Loading