Skip to content

[15.0.X] Fixing minor error in Scouting DQM module#48790

Merged
cmsbuild merged 2 commits intocms-sw:CMSSW_15_0_Xfrom
jprendi:primaryVertexCounterFix_BP
Sep 9, 2025
Merged

[15.0.X] Fixing minor error in Scouting DQM module#48790
cmsbuild merged 2 commits intocms-sw:CMSSW_15_0_Xfrom
jprendi:primaryVertexCounterFix_BP

Conversation

@jprendi
Copy link
Contributor

@jprendi jprendi commented Aug 25, 2025

backport of #48789

PR description:

@mmusich noticed an error in the way the primaryVertex_counter is initialised within the code. The way it was until now, the counter does to not get updated for each event separately. The fix starts and sets the counter to 0 each over each event.

PR validation:

Using input files set at cms-data/DQM-Integration#12 by coping inside the DQM/Integration/data/run392642 folder and running:

cmsRun DQM/Integration/python/clients/scouting_dqm_sourceclient-live_cfg.py runInputDir=DQM/Integration/data/ runNumber=392642 scanOnce=True

followed by subsequent inspection of the output histograms.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #48789 for 2025 data-taking operations

@cmsbuild
Copy link
Contributor

Pull request #48790 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 25, 2025

cms-bot internal usage

@jprendi jprendi marked this pull request as ready for review August 25, 2025 13:26
@jprendi jprendi changed the title Primary vertex counter fix bp [15.0.X] Primary vertex counter fix bp Aug 25, 2025
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 25, 2025

A new Pull Request was created by @jprendi for CMSSW_15_0_X.

It involves the following packages:

  • DQM/HLTEvF (dqm, hlt)

@Martin-Grunewald, @antoniovagnerini, @cmsbuild, @ctarricone, @mmusich, @rseidita can you please review it and eventually sign? Thanks.
@missirol, @mmusich, @mtosi this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@jprendi jprendi changed the title [15.0.X] Primary vertex counter fix bp [15.0.X] Fixing minor error in Scouting DQM module Aug 25, 2025
@mmusich
Copy link
Contributor

mmusich commented Aug 25, 2025

test parameters:

  • addpkg = DQM/Integration

@mmusich
Copy link
Contributor

mmusich commented Aug 25, 2025

@cmsbuild, please test

@mmusich
Copy link
Contributor

mmusich commented Aug 25, 2025

type bug-fix

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eb64e2/47843/summary.html
COMMIT: b7ba2f8
CMSSW: CMSSW_15_0_X_2025-08-25-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48790/47843/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 4 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4020932
  • DQMHistoTests: Total failures: 72
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4020840
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor

mmusich commented Aug 25, 2025

+hlt

@antoniovagnerini
Copy link

+dqm

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 980159e into cms-sw:CMSSW_15_0_X Sep 9, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants