Skip to content

Fixing minor error in Scouting DQM module#48789

Merged
cmsbuild merged 2 commits intocms-sw:masterfrom
jprendi:primaryVertexCounterFix
Aug 27, 2025
Merged

Fixing minor error in Scouting DQM module#48789
cmsbuild merged 2 commits intocms-sw:masterfrom
jprendi:primaryVertexCounterFix

Conversation

@jprendi
Copy link
Contributor

@jprendi jprendi commented Aug 25, 2025

PR description:

@mmusich noticed an error in the way the primaryVertex_counter is initialised within the code. The way it was until now, the counter does to not get updated for each event separately. The fix starts and sets the counter to 0 each over each event.

PR validation:

Using input files set at cms-data/DQM-Integration#12 by coping inside the DQM/Integration/data/run392642 folder and running:

cmsRun DQM/Integration/python/clients/scouting_dqm_sourceclient-live_cfg.py runInputDir=DQM/Integration/data/ runNumber=392642 scanOnce=True

followed by subsequent inspection of the output histograms.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but it will be backported to CMSSW_15_0_X for data-taking operations.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 25, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@jprendi jprendi marked this pull request as ready for review August 25, 2025 13:19
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jprendi for master.

It involves the following packages:

  • DQM/HLTEvF (dqm, hlt)

@Martin-Grunewald, @antoniovagnerini, @cmsbuild, @ctarricone, @mmusich, @rseidita can you please review it and eventually sign? Thanks.
@missirol, @mmusich, @mtosi this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Aug 25, 2025

test parameters:

  • addpkg = DQM/Integration

@mmusich
Copy link
Contributor

mmusich commented Aug 25, 2025

@cmsbuild, please test

@mmusich
Copy link
Contributor

mmusich commented Aug 25, 2025

type bug-fix

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ea7f2/47842/summary.html
COMMIT: 8ef8433
CMSSW: CMSSW_15_1_X_2025-08-25-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48789/47842/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4113272
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4113246
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor

mmusich commented Aug 25, 2025

+hlt

@antoniovagnerini
Copy link

+dqm

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6786ff8 into cms-sw:master Aug 27, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants