Skip to content

Conversation

@makortel
Copy link
Contributor

@makortel makortel commented Aug 22, 2025

PR description:

This PR extends the IOPool schema evolution tests to cover split levels 0 and 99 (earlier version of the tests implicitly used split level 99). It is a preparatory step to extend the schema evolution testing to cover std::auto_ptr to std::unique_ptr evolution in order to test #43923 (comment)

Needs cms-data/IOPool-Input#3

Resolves cms-sw/framework-team#1537

PR validation:

Unit test runs

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 22, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel for master.

It involves the following packages:

  • IOPool/Input (core)

@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

@cmsbuild, please test with cms-data/IOPool-Input#3

@makortel
Copy link
Contributor Author

@wddgit Could you take a look?

@makortel
Copy link
Contributor Author

@cmsbuild, please abort

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #48783 was updated. @Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please check and sign again.

@makortel
Copy link
Contributor Author

@cmsbuild, please test with cms-data/IOPool-Input#3

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #48783 was updated. @Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please check and sign again.

@makortel
Copy link
Contributor Author

@cmsbuild, please test with cms-data/IOPool-Input#3

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8cc62f/47852/summary.html
COMMIT: fd03932
CMSSW: CMSSW_15_1_X_2025-08-25-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48783/47852/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 17 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4113272
  • DQMHistoTests: Total failures: 24
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4113228
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor Author

Comparison differences are related to #47071

@makortel
Copy link
Contributor Author

+core

Must be merged to together with cms-data/IOPool-Input#3

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-data/IOPool-Input#3

@cmsbuild
Copy link
Contributor

REMINDER @sextonkennedy, @mandrenguyen, @ftenchini: This PR was tested with cms-data/IOPool-Input#3, please check if they should be merged together

@iarspider
Copy link
Contributor

@cms-sw/orp-l2

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4eb6ddc into cms-sw:master Aug 28, 2025
10 checks passed
@makortel makortel deleted the schemaEvolutionTest branch August 28, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extend schema evolution test to splitLevel 0 files

5 participants