Skip to content

Conversation

@mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 8, 2025

PR description:

There has been a recent addition of the PF Calo Rechits to the HLT Scouting Event Content for the rest of 2025 data-taking after the deployment of the HLT menu V1.3 (see #48583).
In order to properly monitor the new scouting collections both in the ScoutingPFMonitor (offline) and in the DQMOnlineScouting (online), the class ScoutingCollectionMonitor is updated to support monitoring of the several Ecal (cleaned, uncleaned) and Hcal PF rechits collection.
This PR has been developed in collaboration with @jprendi and it's accompanied by a corresponding cms-data PR cms-data/DQM-Integration#12 to include a suitable input file for testing.

PR validation:

Used the input files at cms-data/DQM-Integration#12 by copying them inside the DQM/Integration/data/run392642 folder and then running:

cmsRun DQM/Integration/python/clients/scouting_dqm_sourceclient-live_cfg.py runInputDir=DQM/Integration/data/ runNumber=392642 scanOnce=True

followed by subsquent inspection of the output histograms.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but it will be backported to CMSSW_15_0_X for 2025 data-taking operations.

FYI: @silviodonato @elfontan @patinkaew

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2025

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Aug 8, 2025

test parameters:

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2025

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • DQM/HLTEvF (hlt, dqm)

@Martin-Grunewald, @antoniovagnerini, @cmsbuild, @ctarricone, @mmusich, @rseidita can you please review it and eventually sign? Thanks.
@missirol, @mtosi this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Aug 8, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2025

+1

Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ea6d2/47627/summary.html
COMMIT: 649c43b
CMSSW: CMSSW_15_1_X_2025-08-08-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48707/47627/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ea6d2/47627/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ea6d2/47627/git-merge-result

Comparison Summary

Summary:

  • You potentially added 13 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 4171113
  • DQMHistoTests: Total failures: 2203
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4168890
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 728.162 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 145.415 ): 728.162 KiB HLT/ScoutingOffline
  • Checked 218 log files, 188 edm output root files, 51 DQM output files
  • TriggerResults: found differences in 2 / 49 workflows

@mmusich
Copy link
Contributor Author

mmusich commented Aug 9, 2025

TriggerResults: found differences in 2 / 49 workflows

Changes in trigger results are spurious. Coming from #48658

@mmusich
Copy link
Contributor Author

mmusich commented Aug 9, 2025

+hlt

@rseidita
Copy link
Contributor

+dqm

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-data/DQM-Integration#12

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 78ed121 into cms-sw:master Aug 12, 2025
11 checks passed
@mmusich mmusich deleted the mm_jp_caloScouting_DQM branch August 12, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants