-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Update ScoutingCollectionMonitor to allow monitoring of ECal and HCal PF rechits
#48707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cms-bot internal usage |
|
test parameters:
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48707/45747 |
|
A new Pull Request was created by @mmusich for master. It involves the following packages:
@Martin-Grunewald, @antoniovagnerini, @cmsbuild, @ctarricone, @mmusich, @rseidita can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test |
|
+1 Size: This PR adds an extra 36KB to repository The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
Changes in trigger results are spurious. Coming from #48658 |
|
+hlt |
|
+dqm |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
There has been a recent addition of the PF Calo Rechits to the HLT Scouting Event Content for the rest of 2025 data-taking after the deployment of the HLT menu V1.3 (see #48583).
In order to properly monitor the new scouting collections both in the
ScoutingPFMonitor(offline) and in theDQMOnlineScouting(online), the classScoutingCollectionMonitoris updated to support monitoring of the several Ecal (cleaned, uncleaned) and Hcal PF rechits collection.This PR has been developed in collaboration with @jprendi and it's accompanied by a corresponding cms-data PR cms-data/DQM-Integration#12 to include a suitable input file for testing.
PR validation:
Used the input files at cms-data/DQM-Integration#12 by copying them inside the
DQM/Integration/data/run392642folder and then running:followed by subsquent inspection of the output histograms.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, but it will be backported to CMSSW_15_0_X for 2025 data-taking operations.
FYI: @silviodonato @elfontan @patinkaew