Skip to content

Conversation

@jprendi
Copy link
Contributor

@jprendi jprendi commented Aug 11, 2025

backport of #48707

PR description:

There has been a recent addition of the PF Calo Rechits to the HLT Scouting Event Content for the rest of 2025 data-taking after the deployment of the HLT menu V1.3 (see #48583).
In order to properly monitor the new scouting collections both in the ScoutingPFMonitor (offline) and in the DQMOnlineScouting (online), the class ScoutingCollectionMonitor is updated to support monitoring of the several Ecal (cleaned, uncleaned) and Hcal PF rechits collection.
This PR has been developed in collaboration with @mmusich and it's accompanied by a corresponding cms-data PR cms-data/DQM-Integration#12 to include a suitable input file for testing.

PR validation:

Used the input files at cms-data/DQM-Integration#12 by copying them inside the DQM/Integration/data/run392642 folder and then running:

cmsRun DQM/Integration/python/clients/scouting_dqm_sourceclient-live_cfg.py runInputDir=DQM/Integration/data/ runNumber=392642 scanOnce=True

followed by subsquent inspection of the output histograms.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #48707 to 15.0.X for 2025 data taking operations.

@cmsbuild
Copy link
Contributor

Pull request #48715 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 11, 2025

cms-bot internal usage

@jprendi jprendi marked this pull request as ready for review August 11, 2025 11:14
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 11, 2025

A new Pull Request was created by @jprendi for CMSSW_15_0_X.

It involves the following packages:

  • DQM/HLTEvF (hlt, dqm)

@Martin-Grunewald, @antoniovagnerini, @cmsbuild, @ctarricone, @mmusich, @rseidita can you please review it and eventually sign? Thanks.
@missirol, @mmusich, @mtosi this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild cmsbuild added ngt and removed ngt labels Aug 11, 2025
@rseidita
Copy link
Contributor

please test

@mmusich
Copy link
Contributor

mmusich commented Aug 11, 2025

@cmsbuild, please abort

@mmusich
Copy link
Contributor

mmusich commented Aug 11, 2025

test parameters:

@mmusich
Copy link
Contributor

mmusich commented Aug 11, 2025

@cmsbuild, please test

@nothingface0
Copy link
Contributor

nothingface0 commented Aug 11, 2025

For future PRs, to make our life easier, we would like to request that you base them on the production release we're using at DQM (e.g. 15_0_10_patch3 currently, see here), instead of IBs, if possible. From what I understand, this specific PR depends on recent PRs not merged in 15_0_10_patch3, right?

@mmusich
Copy link
Contributor

mmusich commented Aug 11, 2025

From what I understand, this specific PR depends on recent PRs not merged in 15_0_10_patch3, right?

If you count #48655 (which is merged in CMSSW_15_0_12), yes.

EDIT: it also needs #48613 (merged in CMSSW_15_0_11). I didn't appreciate online DQM was so far behind.

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ea01a/47652/summary.html
COMMIT: 9565246
CMSSW: CMSSW_15_0_X_2025-08-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48715/47652/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 26 lines to the logs
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 4115853
  • DQMHistoTests: Total failures: 38
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4115795
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 728.162 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 145.415 ): 728.162 KiB HLT/ScoutingOffline
  • Checked 221 log files, 193 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor

mmusich commented Aug 11, 2025

+hlt

@nothingface0
Copy link
Contributor

nothingface0 commented Aug 11, 2025

P5 DQM tests are good @rseidita

PS: It also needed #48613

@rseidita
Copy link
Contributor

+dqm

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-data/DQM-Integration#12

@mmusich
Copy link
Contributor

mmusich commented Aug 13, 2025

@cms-sw/orp-l2 any objections to merge this?

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a185d89 into cms-sw:CMSSW_15_0_X Aug 13, 2025
9 checks passed
@mmusich mmusich deleted the CaloDQM_BP branch August 13, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants