Skip to content

Conversation

@battibass
Copy link

@battibass battibass commented Aug 1, 2025

PR description:

This pull-request add information to both the ZMu and the ZeroBias flavours of the Muon DPG custom-NANO.

Results from the validation of the ZMu ntuples are reported in the google-doc from this DT DPG meeting.

The changes imply a ~1% increase in the ntuple event-size.

Results validating the additions to the ZeroBias ntuples are scattered in meetings of the Muon Background Studies Group.

The ntuple event-size get roughly doubled because of this this update, but it has to be noted that ZeroBias ntuples are never produced in central workflows, hence event-size is "just" a muon DPGO matter.

PR validation:

Beyond performance studies the ntuples were validated issuing runTheMatrix.py -l 2500.2402,2500.2403.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2025

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48660/45672

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2025

Pull request #48660 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2025

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48660/45680

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2025

Pull request #48660 was updated.

@ftorrresd
Copy link
Contributor

enable nano

@ftorrresd
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2025

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c5bba4/47513/summary.html
COMMIT: 3cc0d53
CMSSW: CMSSW_15_1_X_2025-08-04-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48660/47513/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

NANO Comparison Summary

Summary:

  • You potentially added 894 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 89100
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 89100
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 21 files compared)
  • Checked 134 log files, 80 edm output root files, 22 DQM output files
  • TriggerResults: no differences found

Nano size comparison Summary:

workflow id kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
NANOmc106Xul16v2 2500.0001 3.118 3.118 0.000 ( +0.0% ) 3.68 3.58 +2.8% 2.813 2.806
NANOmc106Xul17v2 2500.0002 3.177 3.177 0.000 ( +0.0% ) 3.43 3.30 +3.9% 3.289 3.279
NANOmc106Xul18v2 2500.0003 3.128 3.128 0.000 ( +0.0% ) 3.50 3.39 +3.2% 3.254 3.261
NANOdata106Xul16v2 2500.0101 1.560 1.560 0.000 ( +0.0% ) 6.08 5.75 +5.7% 2.852 2.844
NANOdata106Xul17v2 2500.0102 1.948 1.948 0.000 ( +0.0% ) 4.09 3.90 +4.9% 3.042 3.028
NANOdata106Xul18v2 2500.0103 1.914 1.914 0.000 ( +0.0% ) 4.90 4.62 +6.0% 3.011 3.016
NANOmcUL16APVreMINI 2500.0201 0.022 0.022 0.000 ( +0.0% ) 1.68 1.14 +47.4% 2.991 2.993
NANOmcUL16reMINI 2500.0202 0.022 0.022 0.000 ( +0.0% ) 1.57 1.59 -0.9% 2.986 2.996
NANOmcUL17reMINI 2500.0203 0.022 0.022 0.000 ( +0.0% ) 1.53 1.56 -2.0% 2.696 2.703
NANOmcUL18reMINI 2500.0204 0.022 0.022 0.000 ( +0.0% ) 1.27 1.28 -1.0% 3.133 3.134
NANOdataUL16APVreMINI 2500.0301 0.035 0.035 0.000 ( +0.0% ) 1.18 1.38 -14.6% 2.919 2.929
NANOdataUL16reMINI 2500.0302 0.036 0.036 0.000 ( +0.0% ) 1.45 1.51 -3.8% 2.940 2.951
NANOdataUL17reMINI 2500.0303 0.037 0.037 0.000 ( +0.0% ) 1.26 1.32 -4.4% 2.945 2.948
NANOdataUL18reMINI 2500.0304 0.036 0.036 0.000 ( +0.0% ) 1.26 1.29 -1.7% 2.940 2.931
NANOmc130X 2500.1001 3.220 3.220 0.000 ( +0.0% ) 4.23 4.03 +5.0% 3.234 3.228
NANOdata130Xrun3 2500.1101 1.799 1.799 0.000 ( +0.0% ) 6.14 5.87 +4.6% 2.825 2.837
ScoutingNANOdata130Xrun3 2500.1301 0.771 0.771 0.000 ( +0.0% ) 32.23 33.34 -3.3% 1.693 1.689
muPOGNANOmc140X 2500.2201 2.065 2.065 0.000 ( +0.0% ) 5.30 5.59 -5.2% 2.361 2.360
EGMNANOmc140X 2500.2202 3.876 3.876 0.000 ( +0.0% ) 3.86 3.96 -2.6% 2.724 2.726
BTVNANOmc140X 2500.2203 10.607 10.607 0.000 ( +0.0% ) 2.40 2.54 -5.4% 2.942 2.941
jmeNANOmc140X 2500.2204 6.666 6.666 0.000 ( +0.0% ) 1.08 1.05 +2.5% 2.724 2.811
lepTrackInfoNANOmc140X 2500.2206 3.570 3.570 0.000 ( +0.0% ) 3.84 3.99 -3.8% 2.715 2.717
ScoutingNANOmc140X 2500.2207 1.486 1.486 0.000 ( +0.0% ) 14.67 15.04 -2.5% 2.037 2.042
ScoutingNANOwithPromptmc140X 2500.2208 4.474 4.474 0.000 ( +0.0% ) 3.30 3.16 +4.5% 2.932 2.951
muPOGNANO140Xrun3 2500.2301 1.469 1.469 0.000 ( +0.0% ) 7.04 7.45 -5.5% 2.662 2.666
EGMNANOdata140Xrun3 2500.2302 2.623 2.623 0.000 ( +0.0% ) 5.26 5.65 -6.9% 3.011 3.015
BTVNANOdata140Xrun3 2500.2303 5.612 5.612 0.000 ( +0.0% ) 3.36 3.59 -6.4% 3.226 3.241
jmeNANOdata140Xrun3 2500.2304 3.976 3.976 0.000 ( +0.0% ) 1.41 1.28 +10.5% 2.723 3.053
lepTrackInfoNANOdata140Xrun3 2500.2306 2.413 2.413 0.000 ( +0.0% ) 5.49 5.54 -1.0% 3.001 3.018
ScoutingNANOdata140Xrun3 2500.2307 1.101 1.101 0.000 ( +0.0% ) 28.37 26.36 +7.6% 1.663 1.678
ScoutingNANOwithPromptdata140Xrun3 2500.2308 2.783 2.783 0.000 ( +0.0% ) 5.03 4.74 +6.1% 2.921 3.144
l1DPGNANO140Xrun3 2500.2401 9.404 9.404 0.000 ( +0.0% ) 6.96 6.59 +5.5% 1.935 1.939
muDPGNANO140Xrun3 2500.2402 10.377 10.331 0.045 ( +0.4% ) 1.65 1.51 +9.4% 1.745 1.733
muDPGNANOBkg140Xrun3 2500.2403 6.401 2.712 3.689 ( +136.0% ) 11.73 13.99 -16.2% 1.258 1.069
hcalDPGNANO140Xrun3 2500.2404 486.016 486.016 0.000 ( +0.0% ) 1.13 0.93 +22.1% 1.715 1.725
hcalDPGCalibNANO140Xrun3 2500.2405 826.413 826.413 0.000 ( +0.0% ) 1.49 1.18 +26.3% 1.709 1.710
hcalDPGMCNANO140Xrun3 2500.2501 645.333 645.333 0.000 ( +0.0% ) 1.63 1.22 +33.3% 1.808 1.815
NANOmc2024reMINI 2500.2601 0.021 0.021 0.000 ( +0.0% ) 1.47 1.10 +33.8% 3.166 3.166
NANOdata2024reMINI 2500.2701 0.036 0.036 0.000 ( +0.0% ) 1.31 0.93 +40.1% 2.920 2.913
NANOmc150X 2500.3001 3.217 3.217 0.000 ( +0.0% ) 17.93 16.77 +6.9% 2.777 2.765
NANOdata150X 2500.3101 2.144 2.144 0.000 ( +0.0% ) 34.23 27.70 +23.6% 2.495 2.483
NANOdata150X 2500.3102 2.630 2.630 0.000 ( +0.0% ) 23.03 17.82 +29.2% 2.572 2.577
muPOGNANOmc150X 2500.3201 2.255 2.255 0.000 ( +0.0% ) 15.49 14.39 +7.6% 2.642 2.644
EGMNANOmc150X 2500.3202 4.111 4.111 0.000 ( +0.0% ) 14.23 13.05 +9.1% 2.748 2.746
BTVNANOmc150X 2500.3203 10.552 10.552 0.000 ( +0.0% ) 4.93 4.58 +7.7% 2.967 2.966
jmeNANOmc150X 2500.3204 6.760 6.760 0.000 ( +0.0% ) 1.37 1.32 +3.8% 2.316 2.316
jmeNANOrePuppimc150X 2500.3205 6.763 6.763 0.000 ( +0.0% ) 1.28 1.24 +2.7% 2.579 2.579
lepTrackInfoNANOmc150X 2500.3206 3.721 3.721 0.000 ( +0.0% ) 15.10 14.57 +3.6% 2.744 2.742
ScoutingNANOmc150X 2500.3207 1.562 1.562 0.000 ( +0.0% ) 18.82 18.85 -0.1% 2.542 2.527
ScoutingNANOwithPromptmc150X 2500.3208 4.774 4.774 0.000 ( +0.0% ) 10.44 10.47 -0.3% 2.985 2.977
BPHNANOmc150X 2500.3209 4.109 4.109 0.000 ( +0.0% ) 16.77 16.78 -0.1% 2.799 2.803
muPOGNANO150Xrun3 2500.3301 1.125 1.125 0.000 ( +0.0% ) 25.98 24.45 +6.2% 2.409 2.402
EGMNANOdata150Xrun3 2500.3302 2.985 2.985 0.000 ( +0.0% ) 23.33 21.69 +7.6% 2.489 2.488
BTVNANOdata150Xrun3 2500.3303 7.971 7.971 0.000 ( +0.0% ) 5.80 5.79 +0.2% 2.703 2.717
jmeNANOdata150Xrun3 2500.3304 4.349 4.349 0.000 ( +0.0% ) 1.64 1.63 +0.3% 2.368 2.368
jmeNANOrePuppidata150Xrun3 2500.3305 4.332 4.332 0.000 ( +0.0% ) 1.41 1.44 -1.6% 2.634 2.625
lepTrackInfoNANOdata150Xrun3 2500.3306 2.625 2.625 0.000 ( +0.0% ) 24.70 24.40 +1.2% 2.479 2.490
ScoutingNANOdata150Xrun3 2500.3307 1.737 1.737 0.000 ( +0.0% ) 30.59 30.67 -0.2% 1.692 1.678
ScoutingNANOwithPromptdata150Xrun3 2500.3308 2.601 2.601 0.000 ( +0.0% ) 17.14 17.09 +0.3% 2.800 2.689
BPHNANOdata150Xrun3 2500.3309 2.604 2.604 0.000 ( +0.0% ) 33.01 31.54 +4.7% 2.540 2.223
TTbarMINIAOD10.6_UL18v2 2500.9001 1.819 1.819 0.000 ( +0.0% ) 29.09 27.81 +4.6% 1.938 1.492
TTbarMINIAOD14.0 2500.9002 1.665 1.665 0.000 ( +0.0% ) 28.20 27.48 +2.6% 1.581 1.580
DYToLL_M-50_13TeV_pythia8 2500.9101 14.345 14.345 0.000 ( +0.0% ) 7.46 7.26 +2.7% 1.100 1.102
DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV 2500.9102 0.199 0.240 -0.041 ( -16.9% ) 3.15 2.41 +30.8% 0.852 0.849
TTbar_Pow_LHE_13TeV 2500.9103 0.110 0.110 0.000 ( +0.0% ) 2.64 2.64 -0.0% 0.856 0.854

@AdrianoDee
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @battibass for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (upgrade, pdmv)
  • DPGAnalysis/MuonTools (xpog)
  • PhysicsTools/NanoAOD (xpog)

@Moanwar, @ftorrresd, @hqucms, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @gpetruc, @makortel, @missirol, @mmusich, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@ftorrresd
Copy link
Contributor

+1

@mandrenguyen
Copy link
Contributor

@cms-sw/upgrade-l2 can you have a look please?

@Moanwar
Copy link
Contributor

Moanwar commented Aug 13, 2025

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d03d230 into cms-sw:master Aug 13, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants