Skip to content

[15.0.X] Backport of Muon DPG custom-NANO updates enabling additional studies #48672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cmsbuild merged 1 commit into from
Aug 14, 2025
Merged

[15.0.X] Backport of Muon DPG custom-NANO updates enabling additional studies #48672

cmsbuild merged 1 commit into from
Aug 14, 2025

Conversation

@battibass
Copy link

@battibass battibass commented Aug 5, 2025

PR description

This PR is a back-port of #48660. The inclusion of the changes described in the original PR will allow more muon DPG analyses to take advantage of centrally (and privately) produced ntuples.

PR validation:

Beyond performance studies reported in the original PR, the ntuples were validated issuing runTheMatrix.py -l 2500.242,2500.243

@cmsbuild cmsbuild added this to the CMSSW_15_0_X milestone Aug 5, 2025
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2025

A new Pull Request was created by @battibass for CMSSW_15_0_X.

It involves the following packages:

  • Configuration/PyReleaseValidation (upgrade, pdmv)
  • DPGAnalysis/MuonTools (xpog)
  • PhysicsTools/NanoAOD (xpog)

@AdrianoDee, @Moanwar, @cmsbuild, @DickyChant, @ftorrresd, @hqucms, @miquork, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @gpetruc, @makortel, @missirol, @mmusich, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2025 •
edited
Loading

cms-bot internal usage

@battibass
Copy link
Author

battibass commented Aug 5, 2025

enable nano

@battibass
Copy link
Author

battibass commented Aug 5, 2025

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2025

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-529bf1/47533/summary.html
COMMIT: de54c8d
CMSSW: CMSSW_15_0_X_2025-08-05-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48672/47533/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4020902
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4020868
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially added 94 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 88860
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 88860
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 21 files compared)
  • Checked 134 log files, 80 edm output root files, 22 DQM output files
  • TriggerResults: no differences found

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.001_NANOmc106Xul16v2 3.118 3.118 0.000 ( +0.0% ) 3.82 3.77 +1.3% 2.681 2.645
2500.002_NANOmc106Xul17v2 3.177 3.177 0.000 ( +0.0% ) 3.56 3.53 +1.0% 2.707 3.065
2500.003_NANOmc106Xul18v2 3.128 3.128 0.000 ( +0.0% ) 3.64 3.57 +1.9% 2.719 3.050
2500.011_NANOdata106Xul16v2 1.560 1.560 0.000 ( +0.0% ) 6.11 6.24 -2.0% 2.508 2.728
2500.012_NANOdata106Xul17v2 1.948 1.948 0.000 ( +0.0% ) 4.24 4.18 +1.6% 2.562 2.864
2500.013_NANOdata106Xul18v2 1.914 1.914 0.000 ( +0.0% ) 5.08 4.96 +2.4% 2.583 2.771
2500.021_NANOmcUL16APVreMINI 0.022 0.022 0.000 ( +0.0% ) 1.83 1.83 -0.3% 2.940 2.625
2500.022_NANOmcUL16reMINI 0.022 0.022 0.000 ( +0.0% ) 1.79 1.73 +3.4% 2.931 2.610
2500.023_NANOmcUL17reMINI 0.022 0.022 0.000 ( +0.0% ) 1.48 1.59 -7.0% 2.647 2.583
2500.024_NANOmcUL18reMINI 0.022 0.022 0.000 ( +0.0% ) 1.42 1.39 +2.0% 2.966 2.745
2500.031_NANOdataUL16APVreMINI 0.035 0.035 0.000 ( +0.0% ) 1.59 1.59 +0.0% 2.881 2.716
2500.032_NANOdataUL16reMINI 0.036 0.036 0.000 ( +0.0% ) 1.58 1.57 +0.9% 2.894 2.644
2500.033_NANOdataUL17reMINI 0.037 0.037 0.000 ( +0.0% ) 1.51 1.52 -0.4% 2.902 2.744
2500.034_NANOdataUL18reMINI 0.036 0.036 0.000 ( +0.0% ) 1.53 1.51 +1.0% 2.885 2.724
2500.101_NANOmc130X 3.220 3.220 0.000 ( +0.0% ) 4.39 4.34 +1.1% 2.526 3.076
2500.111_NANOdata130Xrun3 1.799 1.799 0.000 ( +0.0% ) 6.44 6.39 +0.7% 2.768 2.795
2500.131_ScoutingNANOdata130Xrun3 0.771 0.771 0.000 ( +0.0% ) 33.43 33.43 +0.0% 1.635 1.663
2500.221_muPOGNANOmc140X 2.065 2.065 0.000 ( +0.0% ) 5.64 5.61 +0.6% 2.232 2.240
2500.222_EGMNANOmc140X 3.876 3.876 0.000 ( +0.0% ) 4.05 4.04 +0.4% 2.592 2.445
2500.223_BTVNANOmc140X 10.607 10.607 0.000 ( +0.0% ) 2.54 2.52 +0.5% 2.799 2.587
2500.224_jmeNANOmc140X 6.666 6.666 0.000 ( +0.0% ) 1.13 1.14 -1.2% 2.658 2.453
2500.226_lepTrackInfoNANOmc140X 3.570 3.570 0.000 ( +0.0% ) 4.00 4.03 -0.7% 2.577 2.401
2500.227_ScoutingNANOmc140X 1.486 1.486 0.000 ( +0.0% ) 15.67 15.68 -0.1% 1.870 1.919
2500.228_ScoutingNANOwithPromptmc140X 4.474 4.474 0.000 ( +0.0% ) 3.40 3.37 +0.9% 2.807 2.724
2500.231_muPOGNANO140Xrun3 1.469 1.469 0.000 ( +0.0% ) 7.94 7.96 -0.3% 2.560 2.417
2500.232_EGMNANOdata140Xrun3 2.623 2.623 0.000 ( +0.0% ) 5.77 5.89 -1.9% 2.929 2.910
2500.233_BTVNANOdata140Xrun3 5.612 5.612 0.000 ( +0.0% ) 3.71 3.71 -0.0% 3.122 2.945
2500.234_jmeNANOdata140Xrun3 3.976 3.976 0.000 ( +0.0% ) 1.48 1.47 +0.8% 2.970 2.337
2500.236_lepTrackInfoNANOdata140Xrun3 2.413 2.413 0.000 ( +0.0% ) 5.82 5.76 +1.1% 2.914 2.664
2500.237_ScoutingNANOdata140Xrun3 1.101 1.101 0.000 ( +0.0% ) 29.35 29.58 -0.8% 1.649 1.616
2500.238_ScoutingNANOwithPromptdata140Xrun3 2.783 2.783 0.000 ( +0.0% ) 5.21 5.12 +1.8% 3.102 2.706
2500.241_l1DPGNANO140Xrun3 9.404 9.404 0.000 ( +0.0% ) 6.45 7.20 -10.4% 1.933 1.931
2500.242_muDPGNANO140Xrun3 10.377 10.331 0.045 ( +0.4% ) 1.62 1.22 +32.9% 1.737 1.718
2500.243_muDPGNANOBkg140Xrun3 6.401 2.712 3.689 ( +136.0% ) 12.52 14.94 -16.2% 1.253 1.060
2500.244_hcalDPGNANO140Xrun3 486.016 486.016 0.000 ( +0.0% ) 1.13 1.15 -1.2% 1.688 1.720
2500.245_hcalDPGCalibNANO140Xrun3 826.413 826.413 0.000 ( +0.0% ) 1.51 1.52 -0.3% 1.729 1.690
2500.251_hcalDPGMCNANO140Xrun3 645.333 645.333 0.000 ( +0.0% ) 1.66 1.64 +1.2% 1.792 1.779
2500.261_NANOmc2024reMINI 0.021 0.021 0.000 ( +0.0% ) 1.62 1.60 +1.1% 3.107 3.017
2500.271_NANOdata2024reMINI 0.036 0.036 0.000 ( +0.0% ) 1.64 1.66 -1.0% 2.904 2.774
2500.301_NANOmc150X 3.217 3.217 0.000 ( +0.0% ) 18.62 17.95 +3.8% 2.710 2.106
2500.311_NANOdata150X 2.144 2.144 0.000 ( +0.0% ) 36.19 34.96 +3.5% 2.443 2.244
2500.312_NANOdata150X 2.630 2.630 0.000 ( +0.0% ) 27.81 28.01 -0.7% 2.540 2.541
2500.321_muPOGNANOmc150X 2.255 2.255 0.000 ( +0.0% ) 17.05 16.38 +4.0% 2.593 2.591
2500.322_EGMNANOmc150X 4.111 4.111 0.000 ( +0.0% ) 15.51 15.21 +2.0% 2.701 2.696
2500.323_BTVNANOmc150X 10.552 10.552 0.000 ( +0.0% ) 5.13 5.01 +2.4% 2.918 2.916
2500.324_jmeNANOmc150X 6.760 6.760 0.000 ( +0.0% ) 1.41 1.36 +3.7% 2.284 2.820
2500.325_jmeNANOrePuppimc150X 6.763 6.763 0.000 ( +0.0% ) 1.32 1.27 +3.6% 2.572 3.159
2500.326_lepTrackInfoNANOmc150X 3.721 3.721 0.000 ( +0.0% ) 15.92 15.46 +3.0% 2.081 2.692
2500.327_ScoutingNANOmc150X 1.562 1.562 0.000 ( +0.0% ) 19.76 19.30 +2.3% 1.889 2.388
2500.328_ScoutingNANOwithPromptmc150X 4.774 4.774 0.000 ( +0.0% ) 10.83 10.57 +2.5% 2.943 2.697
2500.329_BPHNANOmc150X 4.109 4.109 0.000 ( +0.0% ) 17.75 16.81 +5.6% 2.754 2.585
2500.331_muPOGNANO150Xrun3 1.125 1.125 0.000 ( +0.0% ) 31.09 30.21 +2.9% 2.365 2.363
2500.332_EGMNANOdata150Xrun3 2.985 2.985 0.000 ( +0.0% ) 27.29 25.63 +6.5% 2.138 2.240
2500.333_BTVNANOdata150Xrun3 7.971 7.971 0.000 ( +0.0% ) 6.20 6.02 +2.9% 2.389 2.623
2500.334_jmeNANOdata150Xrun3 4.349 4.349 0.000 ( +0.0% ) 1.72 1.67 +3.0% 2.608 2.604
2500.335_jmeNANOrePuppidata150Xrun3 4.332 4.332 0.000 ( +0.0% ) 1.49 1.41 +5.2% 2.882 2.594
2500.336_lepTrackInfoNANOdata150Xrun3 2.625 2.625 0.000 ( +0.0% ) 29.72 27.08 +9.8% 2.436 2.205
2500.337_ScoutingNANOdata150Xrun3 1.737 1.737 0.000 ( +0.0% ) 31.98 31.11 +2.8% 1.657 1.594
2500.338_ScoutingNANOwithPromptdata150Xrun3 2.601 2.601 0.000 ( +0.0% ) 18.31 17.78 +2.9% 2.708 2.514
2500.339_BPHNANOdata150Xrun3 2.604 2.604 0.000 ( +0.0% ) 36.44 32.50 +12.1% 2.486 2.477
2500.901_TTbarMINIAOD10.6_UL18v2 1.819 1.819 0.000 ( +0.0% ) 34.15 32.15 +6.2% 1.881 1.879
2500.902_TTbarMINIAOD14.0 1.665 1.665 0.000 ( +0.0% ) 33.55 31.38 +6.9% 1.459 1.459
2500.911_DYToLL_M-50_13TeV_pythia8 14.345 14.345 0.000 ( +0.0% ) 7.58 7.83 -3.2% 1.096 1.095
2500.912_DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV 0.240 0.240 0.000 ( +0.0% ) 3.02 2.68 +12.5% 0.849 0.849
2500.913_TTbar_Pow_LHE_13TeV 0.110 0.110 0.000 ( +0.0% ) 2.69 2.53 +6.1% 0.852 0.851

@Moanwar
Copy link
Contributor

Moanwar commented Aug 5, 2025

+Upgrade

@AdrianoDee
Copy link
Contributor

AdrianoDee commented Aug 11, 2025

+pdmv

@ftorrresd
Copy link
Contributor

ftorrresd commented Aug 12, 2025

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 12, 2025

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

mandrenguyen commented Aug 14, 2025

+1

@cmsbuild cmsbuild merged commit 72fc923 into cms-sw:CMSSW_15_0_X Aug 14, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

fully-signed orp-approved pdmv-approved tests-approved upgrade-approved xpog-approved

Projects

None yet

Milestone

CMSSW_15_0_X

Development

Successfully merging this pull request may close these issues.

6 participants

@battibass @cmsbuild @Moanwar @AdrianoDee @ftorrresd @mandrenguyen