Skip to content

Conversation

@mmusich
Copy link
Contributor

@mmusich mmusich commented Jul 31, 2025

backport of #48646

PR description:

This PR is a follow-up to #48450.
When inspecting the output of the DQM online scouting distributions for 2025 data-taking I noticed that the rate of objects to monitor is such that we are exhausting the number of entries per bin in single precision, see e.g. https://tinyurl.com/2bbsyrpx or https://tinyurl.com/23rw78su (certain bins getting capped at a fixed value).
The goal of this PR is to book the various distributions to be monitored as TH1D instead of TH1F (similarly in spirit to what was done for #45225, see also issue #45183).
Additionally I provide commit d091e88, in which the onlyScouting flag for ScoutingCollectionMonitor is flipped to false. This is possible because we're actually saving the hltOnlineMetaDataDigis to DQMOnlineScouting stream (see also CMSHLT-3585).

PR validation:

scram b runtests_TestDQMOnlineClient-scouting_dqm_sourceclient runs fine and without warnings.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #48646 to CMSSW_15_0_X for data-taking operations.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 31, 2025

A new Pull Request was created by @mmusich for CMSSW_15_0_X.

It involves the following packages:

  • DQM/HLTEvF (dqm, hlt)
  • DQM/Integration (dqm)

@Martin-Grunewald, @antoniovagnerini, @cmsbuild, @ctarricone, @mmusich, @rseidita can you please review it and eventually sign? Thanks.
@batinkov, @francescobrivio, @missirol, @mtosi, @threus this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 31, 2025

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Jul 31, 2025

test parameters:

  • workflow = 145.415

@mmusich
Copy link
Contributor Author

mmusich commented Jul 31, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb53e3/47473/summary.html
COMMIT: d091e88
CMSSW: CMSSW_15_0_X_2025-07-31-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48655/47473/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 4115895
  • DQMHistoTests: Total failures: 37
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4115838
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 74.957 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 145.415 ): 74.957 KiB HLT/ScoutingOffline
  • Checked 221 log files, 193 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Aug 1, 2025

+hlt

@rseidita
Copy link
Contributor

rseidita commented Aug 4, 2025

+dqm

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2025

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c1239d5 into cms-sw:CMSSW_15_0_X Aug 4, 2025
9 checks passed
@mmusich mmusich deleted the mm_improve_ScoutingCollectionMonitor_15_0_X branch August 4, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants