avoid relying on the collections order and maintain flexibility in `RecHitMapProducer.cc`

[brusale]

With #48517, in order to have some flexibility on which collections are passed to RecHitMapProducer.cc the input is given as a std::vector<edm::InputTag>.

void RecHitMapProducer::fillDescriptions(edm::ConfigurationDescriptions& descriptions) {
  edm::ParameterSetDescription desc;
  desc.add<std::vector<edm::InputTag>>("hits",
                                       {edm::InputTag("HGCalRecHit", "HGCEERecHits"),
                                        edm::InputTag("HGCalRecHit", "HGCHEFRecHits"),
                                        edm::InputTag("HGCalRecHit", "HGCHEBRecHits")});
  desc.add<bool>("hgcalOnly", true);
  descriptions.add("recHitMapProducer", desc);
}

However, as pointed out in #48517 (comment) this is very fragile as it relies on the correct ordering of the collections to stay in sync with the rest of the associators and validation code.

A first to circumvent this issue was made with 0c8751e but this lead to numerous differences in the validation.

Another solution might be revert back to the situation in which each collection has its own edm::EDGetTokenT.

fyi @mmusich

[cmsbuild]

cms-bot internal usage

[cmsbuild]

A new Issue was created by @brusale.

@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[makortel]

assign RecoLocalCalo/HGCalRecProducers

[cmsbuild]

New categories assigned: reconstruction,upgrade

@jfernan2,@mandrenguyen,@Moanwar,@srimanob,@subirsarkar you have been requested to review this Pull request/Issue and eventually sign? Thanks

[kpedro88]

There are places in the code that concretely expect three HGC hit collections with specific meanings (EE, FH, BH), so having separate parameters for each seems warranted. The flexibility of a list/vector could never actually be used in the code as currently written.

[mmusich]

type hgcal, pf

[mmusich]

@cms-sw/hgcal-dpg-l2 @cms-sw/pf-l2 FYI