Skip to content

MTD reconstruction: updated MTD track quality BDT #48514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 1 commit into from
Jul 14, 2025
Merged

MTD reconstruction: updated MTD track quality BDT #48514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 21 additions & 15 deletions RecoMTD/TimingIDTools/interface/MTDTrackQualityMVA.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,20 +10,23 @@
#include "CommonTools/MVAUtils/interface/TMVAEvaluator.h"

#define MTDTRACKQUALITYMVA_VARS(MTDBDTVAR) \
MTDBDTVAR(pt) \
MTDBDTVAR(eta) \
MTDBDTVAR(phi) \
MTDBDTVAR(chi2) \
MTDBDTVAR(ndof) \
MTDBDTVAR(numberOfValidHits) \
MTDBDTVAR(numberOfValidPixelBarrelHits) \
MTDBDTVAR(numberOfValidPixelEndcapHits) \
MTDBDTVAR(btlMatchChi2) \
MTDBDTVAR(btlMatchTimeChi2) \
MTDBDTVAR(etlMatchChi2) \
MTDBDTVAR(etlMatchTimeChi2) \
MTDBDTVAR(mtdt) \
MTDBDTVAR(path_len)
MTDBDTVAR(Track_pt) \
MTDBDTVAR(Track_eta) \
MTDBDTVAR(Track_phi) \
MTDBDTVAR(Track_dz) \
MTDBDTVAR(Track_dxy) \
MTDBDTVAR(Track_chi2) \
MTDBDTVAR(Track_ndof) \
MTDBDTVAR(Track_npixBarrelValidHits) \
MTDBDTVAR(Track_npixEndcapValidHits) \
MTDBDTVAR(Track_BTLchi2) \
MTDBDTVAR(Track_BTLtime_chi2) \
MTDBDTVAR(Track_ETLchi2) \
MTDBDTVAR(Track_ETLtime_chi2) \
MTDBDTVAR(Track_Tmtd) \
MTDBDTVAR(Track_sigmaTmtd) \
MTDBDTVAR(Track_length) \
MTDBDTVAR(Track_lHitPos)

#define MTDBDTVAR_ENUM(ENUM) ENUM,
#define MTDBDTVAR_STRING(STRING) #STRING,
Expand All @@ -38,14 +41,17 @@ class MTDTrackQualityMVA {
//---getters---
// 4D
float operator()(const reco::TrackRef& trk,
const reco::BeamSpot& beamspot,
const edm::ValueMap<int>& npixBarrels,
const edm::ValueMap<int>& npixEndcaps,
const edm::ValueMap<float>& btl_chi2s,
const edm::ValueMap<float>& btl_time_chi2s,
const edm::ValueMap<float>& etl_chi2s,
const edm::ValueMap<float>& etl_time_chi2s,
const edm::ValueMap<float>& tmtds,
const edm::ValueMap<float>& trk_lengths) const;
const edm::ValueMap<float>& sigmatmtds,
const edm::ValueMap<float>& trk_lengths,
const edm::ValueMap<float>& trk_lhitpos) const;

private:
std::vector<std::string> vars_, spec_vars_;
Expand Down
29 changes: 25 additions & 4 deletions RecoMTD/TimingIDTools/plugins/MTDTrackQualityMVAProducer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,31 +37,37 @@ class MTDTrackQualityMVAProducer : public edm::stream::EDProducer<> {

edm::EDGetTokenT<reco::TrackCollection> tracksToken_;
edm::EDGetTokenT<reco::TrackCollection> tracksMTDToken_;

edm::EDGetTokenT<edm::ValueMap<float>> btlMatchChi2Token_;
edm::EDGetTokenT<reco::BeamSpot> RecBeamSpotToken_;
edm::EDGetTokenT<edm::ValueMap<float>> btlMatchTimeChi2Token_;
edm::EDGetTokenT<edm::ValueMap<float>> etlMatchChi2Token_;
edm::EDGetTokenT<edm::ValueMap<float>> etlMatchTimeChi2Token_;
edm::EDGetTokenT<edm::ValueMap<float>> mtdTimeToken_;
edm::EDGetTokenT<edm::ValueMap<float>> sigmamtdTimeToken_;
edm::EDGetTokenT<edm::ValueMap<float>> pathLengthToken_;
edm::EDGetTokenT<edm::ValueMap<int>> npixBarrelToken_;
edm::EDGetTokenT<edm::ValueMap<int>> npixEndcapToken_;
edm::EDGetTokenT<edm::ValueMap<float>> outermostHitPositionToken_;

MTDTrackQualityMVA mva_;
};

MTDTrackQualityMVAProducer::MTDTrackQualityMVAProducer(const ParameterSet& iConfig)
: tracksToken_(consumes<reco::TrackCollection>(iConfig.getParameter<edm::InputTag>("tracksSrc"))),
btlMatchChi2Token_(consumes<edm::ValueMap<float>>(iConfig.getParameter<edm::InputTag>("btlMatchChi2Src"))),
RecBeamSpotToken_(consumes<reco::BeamSpot>(iConfig.getParameter<edm::InputTag>("offlineBS"))),
btlMatchTimeChi2Token_(
consumes<edm::ValueMap<float>>(iConfig.getParameter<edm::InputTag>("btlMatchTimeChi2Src"))),
etlMatchChi2Token_(consumes<edm::ValueMap<float>>(iConfig.getParameter<edm::InputTag>("etlMatchChi2Src"))),
etlMatchTimeChi2Token_(
consumes<edm::ValueMap<float>>(iConfig.getParameter<edm::InputTag>("etlMatchTimeChi2Src"))),
mtdTimeToken_(consumes<edm::ValueMap<float>>(iConfig.getParameter<edm::InputTag>("mtdTimeSrc"))),
sigmamtdTimeToken_(consumes<edm::ValueMap<float>>(iConfig.getParameter<edm::InputTag>("sigmamtdTimeSrc"))),
pathLengthToken_(consumes<edm::ValueMap<float>>(iConfig.getParameter<edm::InputTag>("pathLengthSrc"))),
npixBarrelToken_(consumes<edm::ValueMap<int>>(iConfig.getParameter<edm::InputTag>("npixBarrelSrc"))),
npixEndcapToken_(consumes<edm::ValueMap<int>>(iConfig.getParameter<edm::InputTag>("npixEndcapSrc"))),
outermostHitPositionToken_(
consumes<edm::ValueMap<float>>(iConfig.getParameter<edm::InputTag>("outermostHitPositionSrc"))),
mva_(iConfig.getParameter<edm::FileInPath>("qualityBDT_weights_file").fullPath()) {
produces<edm::ValueMap<float>>(mvaName);
}
Expand All @@ -79,15 +85,20 @@ void MTDTrackQualityMVAProducer::fillDescriptions(edm::ConfigurationDescriptions
desc.add<edm::InputTag>("etlMatchTimeChi2Src", edm::InputTag("trackExtenderWithMTD", "etlMatchTimeChi2"))
->setComment("ETL Chi2 Matching value Map");
desc.add<edm::InputTag>("mtdTimeSrc", edm::InputTag("trackExtenderWithMTD", "generalTracktmtd"))
->setComment("MTD TIme value Map");
->setComment("MTD Time value Map");
desc.add<edm::InputTag>("sigmamtdTimeSrc", edm::InputTag("trackExtenderWithMTD", "generalTracksigmatmtd"))
->setComment("sigma MTD Time value Map");
desc.add<edm::InputTag>("pathLengthSrc", edm::InputTag("trackExtenderWithMTD", "generalTrackPathLength"))
->setComment("MTD PathLength value Map");
desc.add<edm::InputTag>("npixBarrelSrc", edm::InputTag("trackExtenderWithMTD", "npixBarrel"))
->setComment("# of Barrel pixel associated to refitted tracks");
desc.add<edm::InputTag>("npixEndcapSrc", edm::InputTag("trackExtenderWithMTD", "npixEndcap"))
->setComment("# of Endcap pixel associated to refitted tracks");
desc.add<edm::InputTag>("outermostHitPositionSrc",
edm::InputTag("trackExtenderWithMTD", "generalTrackOutermostHitPosition"));
desc.add<edm::InputTag>("offlineBS", edm::InputTag("offlineBeamSpot"));
desc.add<edm::FileInPath>("qualityBDT_weights_file",
edm::FileInPath("RecoMTD/TimingIDTools/data/clf4D_MTDquality_bo.xml"))
edm::FileInPath("RecoMTD/TimingIDTools/data/BDT_nvars_17_d7.xml"))
->setComment("Track MTD quality BDT weights");
descriptions.add("mtdTrackQualityMVAProducer", desc);
}
Expand All @@ -109,6 +120,11 @@ void MTDTrackQualityMVAProducer::produce(edm::Event& ev, const edm::EventSetup&
ev.getByToken(tracksToken_, tracksH);
const auto& tracks = *tracksH;

reco::BeamSpot beamSpot;
edm::Handle<reco::BeamSpot> BeamSpotH;
ev.getByToken(RecBeamSpotToken_, BeamSpotH);
beamSpot = *BeamSpotH;

const auto& btlMatchChi2 = ev.get(btlMatchChi2Token_);
const auto& btlMatchTimeChi2 = ev.get(btlMatchTimeChi2Token_);
const auto& etlMatchChi2 = ev.get(etlMatchChi2Token_);
Expand All @@ -117,6 +133,8 @@ void MTDTrackQualityMVAProducer::produce(edm::Event& ev, const edm::EventSetup&
const auto& npixBarrel = ev.get(npixBarrelToken_);
const auto& npixEndcap = ev.get(npixEndcapToken_);
const auto& mtdTime = ev.get(mtdTimeToken_);
const auto& sigmamtdTime = ev.get(sigmamtdTimeToken_);
const auto& lHitPos = ev.get(outermostHitPositionToken_);

std::vector<float> mvaOutRaw;

Expand All @@ -127,14 +145,17 @@ void MTDTrackQualityMVAProducer::produce(edm::Event& ev, const edm::EventSetup&
mvaOutRaw.push_back(-1.);
else {
mvaOutRaw.push_back(mva_(trackref,
beamSpot,
npixBarrel,
npixEndcap,
btlMatchChi2,
btlMatchTimeChi2,
etlMatchChi2,
etlMatchTimeChi2,
mtdTime,
pathLength));
sigmamtdTime,
pathLength,
lHitPos));
}
}
fillValueMap(ev, tracksH, mvaOutRaw, mvaName);
Expand Down
Loading