Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
5cddb20
First compiling version of P modules in OT barrel SoA.
rovere May 20, 2025
a9adb7d
WIP.
rovere May 20, 2025
dd31530
Enable OT SoA producers, increase SoA size for pixelTracks.
rovere May 21, 2025
a88507b
Update CAHitNtuplet to support Phase2 OT CA extension.
rovere May 21, 2025
8bdee0a
Correctly compute the index used to address rotations.
rovere May 21, 2025
a098506
Fix counting of pixel modules.
rovere May 21, 2025
b1a837a
Add producer to merge Pixel and tracker recHits
Parsifal-2045 May 21, 2025
3588964
Modify PixelTrack converter (SoA -> legacy) to be able to handle the …
JanGerritSchulz May 21, 2025
683a914
Modify hltPhase2PixelTracks to enable OT extension by default in alpa…
JanGerritSchulz May 21, 2025
bd66226
Add missing moduleStart SoA to merged recHits collection
Parsifal-2045 May 21, 2025
62b1b32
WIP
rovere May 21, 2025
35837cf
Fix illegal memory access in RecHits merger
Parsifal-2045 May 22, 2025
6f8293f
Add plus one for the last layer.
rovere May 22, 2025
26f1dd9
Update hard-coded constants to be able to run CA+Extension.
rovere May 22, 2025
dba8905
Add last layer with cumulative number of modules.
rovere May 22, 2025
9211aa3
Correct PixelTrack converter (SoA -> legacy) for new ordering of OT R…
JanGerritSchulz May 22, 2025
3e29ae7
Fix topology for CA Extension.
rovere May 22, 2025
0dadd78
Improve debugging printouts.
rovere May 23, 2025
e98c85a
Fix size of allocated buffer.
rovere May 24, 2025
11e2539
Resolve conflicts.
bfonta Jun 30, 2025
0266d50
Simplified SiPixelRecHitExtendedAlpaka logic
AdrianoDee May 25, 2025
2488fe2
Add new TrackerTraits topology
AdrianoDee May 26, 2025
1eee46a
Code formats
AdrianoDee May 26, 2025
f02ad5e
updateFromDevice for merged SoA
AdrianoDee May 26, 2025
da945f1
Remove +1 in number of modules (now taken care of by the HitPortableC…
Parsifal-2045 May 26, 2025
c02e828
Add back one +1 for merging
Parsifal-2045 May 27, 2025
9c75ee1
Remove some leftover +1 in constructors' calls
Parsifal-2045 May 27, 2025
aeb88e4
allow SingleMuPt15Eta0p_0p4 configuration fragment for NGT scouting w…
mmusich May 27, 2025
ba68f55
Properly sizing hitToTuple buffers
AdrianoDee May 27, 2025
5539b07
Fix CA to work both with and without OT extension
Parsifal-2045 Jun 6, 2025
0e86ec0
WIP on CA-EXT.
rovere Jun 10, 2025
d29a4d4
Working configuration.
rovere Jun 13, 2025
2a9463f
Cache PinPSinOTBarrel. Use vector and unordered_map instead of set.
rovere Jun 14, 2025
ea5fd30
Move geometry-related logic in BeginRun.
rovere Jun 14, 2025
5699ae1
Update logic in PixelTrackProducerFromSoAAlpaka to reuse the HitModul…
JanGerritSchulz Jun 16, 2025
ea8371b
fix the hardCurvCut bug also in the CASimpleCell class (which is the …
JanGerritSchulz Jun 17, 2025
85ac5f5
Add more debugging printouts in brokenline fit.
rovere Jun 19, 2025
aa73850
Fix Jacobian for linefit in Brokenline.
rovere Jun 19, 2025
a2fe5da
Remove all debug printouts
Parsifal-2045 Jun 24, 2025
ab64c05
Resolve conflicts.
bfonta Jun 30, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -1978,7 +1978,7 @@ def setup_(self, step, stepName, stepDict, k, properties):
else:
stepDict[stepName][k] = merge([stepDict[step][k]])
def condition(self, fragment, stepList, key, hasHarvest):
return fragment=="TTbar_14TeV" and 'Run4' in key
return (fragment=="TTbar_14TeV" or fragment=="SingleMuPt15Eta0p_0p4") and 'Run4' in key
upgradeWFs['NGTScouting'] = UpgradeWorkflow_NGTScouting(
steps = [
'Reco',
Expand Down Expand Up @@ -2012,6 +2012,19 @@ def condition(self, fragment, stepList, key, hasHarvest):
'-s':'HARVESTING:@hltValidation'
}

upgradeWFs['NGTScoutingAlpaka'] = deepcopy(upgradeWFs['NGTScouting'])
upgradeWFs['NGTScoutingAlpaka'].suffix = '_NGTScoutingAlpaka'
upgradeWFs['NGTScoutingAlpaka'].offset = 0.771
upgradeWFs['NGTScoutingAlpaka'].step2 = {
'-s':'DIGI:pdigi_valid,L1TrackTrigger,L1,L1P2GT,DIGI2RAW,HLT:NGTScouting,VALIDATION:@hltValidation',
'--procModifiers': 'alpaka',
'--datatier':'GEN-SIM-DIGI-RAW,DQMIO',
'--eventcontent':'FEVTDEBUGHLT,DQMIO'
}
upgradeWFs['NGTScoutingAlpaka'].step3 = {
'-s':'HARVESTING:@hltValidation'
}

class UpgradeWorkflow_L1Complete(UpgradeWorkflow):
def setup_(self, step, stepName, stepDict, k, properties):
if 'Digi' in step and 'NoHLT' not in step:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ namespace pixelClustering {
constexpr uint16_t clusterThresholdPhase2OtherLayers = 4000;

constexpr uint32_t maxNumDigis = 3 * 256 * 1024; // @PU=200 µ=530k σ=50k this is >4σ away
constexpr uint16_t maxNumModules = 5000; // This is an upperlimit taking into account D110 has 4000 modules
constexpr uint16_t maxNumModules =
5000 + 2872; // This is an upperlimit taking into account D110 has 4000 modules + 3 layer of OT for CA Extension

constexpr int32_t maxNumClustersPerModules = maxHitsInModule();
constexpr uint16_t invalidModuleId = std::numeric_limits<uint16_t>::max() - 1;
Expand Down
2 changes: 2 additions & 0 deletions DataFormats/TrackSoA/interface/alpaka/TrackUtilities.h
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
#ifndef DataFormats_TrackSoA_interface_alpaka_TrackUtilities_h
#define DataFormats_TrackSoA_interface_alpaka_TrackUtilities_h

// MRMR #define NTUPLE_FIT_DEBUG // MRMR

#include <algorithm>
#include <cmath>
#include <cstdint>
Expand Down
10 changes: 7 additions & 3 deletions Geometry/CommonTopologies/interface/SimplePixelTopology.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
namespace pixelTopology {

constexpr auto maxNumberOfLadders = 160;
constexpr uint8_t maxLayers = 28;
constexpr uint8_t maxPairs = 64;
constexpr uint8_t maxLayers = 28 + 3; // CA Extension to 3 OT barrel layers
constexpr uint8_t maxPairs = 64 + 64; // CA

// TODO
// Once CUDA is dropped this could be wrapped in #ifdef CA_TRIPLETS_HOLE
Expand Down Expand Up @@ -216,7 +216,7 @@ namespace phase2PixelTopology {
using pixelTopology::phi0p07;
using pixelTopology::phi0p09;

constexpr uint32_t numberOfLayers = 28;
constexpr uint32_t numberOfLayers = 28 + 3; // CA Extension with 3 barrel layers from OT
constexpr int nPairs = 23 + 6 + 14 + 8 + 4; // include far forward layer pairs
constexpr uint16_t numberOfModules = 4000;

Expand Down Expand Up @@ -440,6 +440,10 @@ namespace pixelTopology {
static constexpr inline uint16_t localY(uint16_t py) { return py; }
};

struct Phase2OT : public Phase2 {
static constexpr uint32_t numberOfLayers = 28 + 3; //OT Barrel Extension
};

struct Phase1 {
// types
using hindex_type = uint32_t; // FIXME from siPixelRecHitsHeterogeneousProduct
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import FWCore.ParameterSet.Config as cms

from RecoLocalTracker.SiPixelRecHits.SiPixelRecHitExtendedAlpaka_alpaka import SiPixelRecHitExtendedAlpaka_alpaka as _SiPixelRecHitExtendedAlpaka_alpaka

hltPhase2PixelRecHitsExtendedSoA = _SiPixelRecHitExtendedAlpaka_alpaka()
Loading