-
Notifications
You must be signed in to change notification settings - Fork 4.6k
CAExtension rebase onto 15_1_0_pre4 #48471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update also the configuration parameters to include the 3 additional barrel layers from the OT. Added 6 more double connections.
The index in the SiStipHitSoA to address the proper rotation of the module is now correctly computed by couting all the preceeding pixel modules and simply incrementing that number by one, for every new P-module in the OT barrel. The code and logic is extremely fragile and relies on a couple of assumptions: - all pixel modules will be used in the CA, not matter what. - the order of modules in Phase2OTRecHitsSoAConverter and in CAHitNtuplet is the same.
…extension to OT in Phase-2
…orkflow and add an alpaka variant for it
The traits guarding Phase2 and Phase2OT should now be guarded correctly
…eStart for the OT RecHits as well
…one being used...)
Contributor
|
cms-bot internal usage |
Contributor
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48471/45397 ERROR: Unable to merge PR. See log https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48471/45397/cms-checkout-topic.log |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent developments on extending the CA algorithm for the first three layers of the outer tracker have been rebased onto release
15_1_0_pre4(technically15_1_X_2025-06-19-2300). It includes the following developments, in order:PR validation:
I run the following
cmsDriver.pycommands for both the branch included in this PR ("pre4") and the same commits rebased onto15_1_0_pre3("pre3"), where I only listed the first file:The validation plots are available here. As an example:
Note: The efficiency is below what the extension can currently provide since this PR was not included (cut on the transverse impact parameter).