Skip to content

Conversation

@mmusich
Copy link
Contributor

@mmusich mmusich commented Jun 26, 2025

PR description:

The goal of this PR is to extend support in the Phase 2 NGT Scouting NanoAODs (introduced at #48091 and complemented at #48394 and #48295 ) for HPS Tau reconstructed at HLT (including DeepTau scores association), MET and Energy Sums as well as GenJets (including GEN flavour).

PR validation:

Run successfully the following command:

runTheMatrix.py --what upgrade -l 29634.759,29634.771,29634.772 -i all --ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, not meant to be backported.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 26, 2025

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Jun 26, 2025

test parameters:

  • workflows = 29634.759, 29634.771, 29634.772

@mmusich
Copy link
Contributor Author

mmusich commented Jun 28, 2025

+hlt

@civanch
Copy link
Contributor

civanch commented Jun 28, 2025

+1

std::vector<ValType> vals;
vals.resize(selptrs.size());
if (vmap.isValid() || !skipNonExistingSrc_) {
vals.resize(selptrs.size());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering -- why does this have to be moved outside the if statement?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise we get a crash about mismatched sizes when trying to use the skipNonExistingSrc in our tables.
This should be a bug-fix

@ftorrresd
Copy link
Contributor

+1

@mmusich
Copy link
Contributor Author

mmusich commented Jul 2, 2025

kindly pinging @cms-sw/upgrade-l2 and @cms-sw/pdmv-l2 for the changes in Configuration/PyReleaseValidation.

@AdrianoDee
Copy link
Contributor

+pdmv

@Moanwar
Copy link
Contributor

Moanwar commented Jul 2, 2025

+Upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2ba4e54 into cms-sw:master Jul 2, 2025
13 checks passed
@mmusich mmusich deleted the ev_HLTNano_GenJets branch July 2, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants