-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Extend NanoAOD for NGT Phase 2 Scouting with Tau and Gen information #48425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…hltTriggerAcceptFilter
Co-authored-by: Konstantin Androsov <kandrosov@users.noreply.github.com>
…ertex and Tau Extra tables
…* collections Co-authored-by: Elena Vernazza <elena.vernazza@cern.ch>
|
cms-bot internal usage |
|
test parameters:
|
|
+hlt |
|
+1 |
| std::vector<ValType> vals; | ||
| vals.resize(selptrs.size()); | ||
| if (vmap.isValid() || !skipNonExistingSrc_) { | ||
| vals.resize(selptrs.size()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering -- why does this have to be moved outside the if statement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise we get a crash about mismatched sizes when trying to use the skipNonExistingSrc in our tables.
This should be a bug-fix
|
+1 |
|
kindly pinging @cms-sw/upgrade-l2 and @cms-sw/pdmv-l2 for the changes in |
|
+pdmv |
|
+Upgrade |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
The goal of this PR is to extend support in the Phase 2 NGT Scouting NanoAODs (introduced at #48091 and complemented at #48394 and #48295 ) for HPS Tau reconstructed at HLT (including DeepTau scores association), MET and Energy Sums as well as GenJets (including GEN flavour).
PR validation:
Run successfully the following command:
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, not meant to be backported.