Skip to content

Conversation

@fabiocos
Copy link
Contributor

PR description:

Following the update of the central CMS default upgrade geometry scenario #48297 and the decoupling of the MTD scenario to be used for unit tests, provided by #48300 per request of the geometry conveners, this PR moves the MTD unit tests to D121.

This PR requires the corresponding update of test references in cms-data/Geometry-TestReference#21

PR validation:

Test references produced with this CMSSW update.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 16, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabiocos for master.

It involves the following packages:

  • Geometry/MTDCommonData (upgrade, geometry)

@Dr15Jones, @Moanwar, @bsunanda, @civanch, @cmsbuild, @kpedro88, @makortel, @mdhildreth, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@bsunanda, @martinamalberti this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

please test with cms-data/Geometry-TestReference#21

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-198445/46759/summary.html
COMMIT: aee6f6c
CMSSW: CMSSW_15_1_X_2025-06-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48333/46759/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-198445/46759/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-198445/46759/git-merge-result

Comparison Summary

Summary:

  • You potentially added 10 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 7271 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4050745
  • DQMHistoTests: Total failures: 164185
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 3886538
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -230.75400000000013 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): -0.002 KiB EcalEndcap/EETriggerTowerTask
  • DQMHistoSizes: changed ( 16834.0,... ): -112.246 KiB GEM/Digis
  • DQMHistoSizes: changed ( 16834.0,... ): -1.978 KiB GEM/RecHits
  • DQMHistoSizes: changed ( 17034.0 ): -2.227 KiB SiStrip/MechanicalView
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 9 / 48 workflows

@civanch
Copy link
Contributor

civanch commented Jun 17, 2025

+1

@civanch
Copy link
Contributor

civanch commented Jun 18, 2025

@subirsarkar, @Moanwar Please approve this

@Moanwar
Copy link
Contributor

Moanwar commented Jun 18, 2025

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-data/Geometry-TestReference#21

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 76a9957 into cms-sw:master Jun 18, 2025
10 checks passed
@fabiocos fabiocos deleted the fc-mtdgeomD121-20250616 branch June 19, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants