Skip to content

Conversation

@iarspider
Copy link
Contributor

PR description:

Fixes #48360:

  • Handle any number of files passed to --filein
  • Avoid search space explosion by rewriting regex

PR validation:

Bot tests

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 18, 2025

cms-bot internal usage

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for CMSSW_15_1_RNTUPLE_X.

It involves the following packages:

  • Configuration/PyReleaseValidation (upgrade, pdmv)

@AdrianoDee, @Moanwar, @DickyChant, @miquork, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @missirol, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@iarspider
Copy link
Contributor Author

iarspider commented Jun 18, 2025

test parameters:

  • workflow = 1041.0, 1046.0

@iarspider
Copy link
Contributor Author

please test

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #48366 was updated. @AdrianoDee, @Moanwar, @DickyChant, @miquork, @srimanob, @subirsarkar can you please check and sign again.

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d0e925/46826/summary.html
COMMIT: f2b0062
CMSSW: CMSSW_15_1_RNTUPLE_X_2025-06-17-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48366/46826/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d0e925/46826/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d0e925/46826/git-merge-result

Unit Tests

I found 2 errors in the following unit tests:

---> test GeometryMTDCommonDataTestDriver had ERRORS
---> test SimG4CMSForwardTestDriver had ERRORS

RelVals

----- Begin Fatal Exception 19-Jun-2025 01:24:45 CEST-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type RNTupleSource
   [2] Calling StorageFactory::open()
   [3] Calling File::sysopen()
Exception Message:
Failed to open the file 'step3_inMINIAODSIM..rntpl'
   Additional Info:
      [a] open() failed with system error 'No such file or directory' (error code 2)
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 19-Jun-2025 01:13:22 CEST-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type RNTupleSource
   [2] Calling StorageFactory::open()
   [3] Calling File::sysopen()
Exception Message:
Failed to open the file 'step3..rntpl'
   Additional Info:
      [a] open() failed with system error 'No such file or directory' (error code 2)
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 19-Jun-2025 01:09:39 CEST-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type RNTupleSource
   [2] Calling StorageFactory::open()
   [3] Calling File::sysopen()
Exception Message:
Failed to open the file 'step1..rntpl'
   Additional Info:
      [a] open() failed with system error 'No such file or directory' (error code 2)
----- End Fatal Exception -------------------------------------------------
Expand to see more relval errors ...

@iarspider
Copy link
Contributor Author

please test

@iarspider
Copy link
Contributor Author

test parameters

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #48366 was updated. @AdrianoDee, @Moanwar, @cmsbuild, @DickyChant, @miquork, @srimanob, @subirsarkar can you please check and sign again.

@iarspider
Copy link
Contributor Author

please test

@iarspider
Copy link
Contributor Author

Command runTheMatrix.py --maxSteps=0 -l 1041.0 --useInput all --job-reports --command "--customise Validation/Performance/TimeMemorySummary.customiseWithTimeMemorySummary --prefix 'python2 /data/cmsbld/jenkins/workspace/ib-run-relvals/cms-bot/monitor_workflow.py timeout --signal SIGTERM 9000 '" -t 4 no longer hangs.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d0e925/46829/summary.html
COMMIT: a03f6b3
CMSSW: CMSSW_15_1_RNTUPLE_X_2025-06-18-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48366/46829/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@iarspider
Copy link
Contributor Author

@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 could you please review and sign this? Thanks!

@Moanwar
Copy link
Contributor

Moanwar commented Jun 23, 2025

+Upgrade

@iarspider
Copy link
Contributor Author

urgent
to fix running RelVals in RNTUPLE_X

@AdrianoDee
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_1_RNTUPLE_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7729358 into cms-sw:CMSSW_15_1_RNTUPLE_X Jun 24, 2025
10 checks passed
@iarspider iarspider deleted the patch-14 branch June 25, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants