Use constexpr in CondDB query building #48279

Dr15Jones · 2025-06-09T20:19:36Z

PR description:

Made various strings compile time constructions rather than runtime.

This was uncovered while looking at gcc 13 compiler failures.

PR validation:

Code compiles. Compile time tests pass.

resolves cms-sw/framework-team#1426

Dr15Jones · 2025-06-09T20:19:47Z

please test

cmsbuild · 2025-06-09T20:19:56Z

cms-bot internal usage

cmsbuild · 2025-06-09T20:21:13Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48279/45118

cmsbuild · 2025-06-09T20:21:21Z

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

CondCore/CondDB (db)

@atpathak, @francescobrivio, @perrotta can you please review it and eventually sign? Thanks.
@JanChyczynski, @PonIlya, @mmusich, @rsreds, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2025-06-09T20:26:27Z

-1

Failed Tests: ClangBuild
Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eba36c/46617/summary.html
COMMIT: c813f2d
CMSSW: CMSSW_15_1_X_2025-06-09-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48279/46617/install.sh to create a dev area with all the needed externals and cmssw changes.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' /usr/bin/time -v scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

cmsbuild · 2025-06-09T20:36:44Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48279/45119

Dr15Jones · 2025-06-09T20:36:47Z

please test

cmsbuild · 2025-06-09T20:37:06Z

Pull request #48279 was updated. @atpathak, @francescobrivio, @perrotta can you please check and sign again.

cmsbuild · 2025-06-09T22:32:49Z

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eba36c/46618/summary.html
COMMIT: f0a01d9
CMSSW: CMSSW_15_1_X_2025-06-09-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48279/46618/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 4048495
DQMHistoTests: Total failures: 61
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4048414
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 215 log files, 184 edm output root files, 50 DQM output files
TriggerResults: no differences found

perrotta · 2025-06-10T07:44:23Z

CondCore/CondDB/src/DbCore.h

+    for (int i = 0; i < M; ++i) {
+      ret[i + N + 1] = m[i];
+    }
+    return ret;


The location ret[N+M+1] remains empty: is t wanted?

The line std::array<char, N + M + 2> ret = {}; initializes all values to 0. In fact, the rules for consteval is no variable is allowed to have any values uninitialized and the compilers are required to enforce that.

Thank you @Dr15Jones . My question was rather: did you forget to fill with something different than 0 the last char? Or maybe the array was over-dimensioned with M+N+2 elements? Or maybe it is just wanted to stay as such...

All the arrays should be the size of the copied strings + 1 where the last element is a null termination. The compile time unit tests check that. That keeps with the standard C string behavior (even though I could explicitly tell the std::string_view how many characters it should use).

smuzaffar · 2025-06-10T13:27:39Z

please test for el8_amd64_gcc13

though link might fail for other packages which failed in IB but at least this will check if build passes for CondCore/CondDB package

cmsbuild · 2025-06-10T13:31:48Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eba36c/46626/summary.html
COMMIT: f0a01d9
CMSSW: CMSSW_15_1_X_2025-06-09-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48279/46626/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  src/CondCore/CondDB/test/testConnectionPool.cpp
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc13/external/gcc/13.4.0-6908cfdf803923e783448096ca4f0923/bin/c++ -c -DCMS_MICRO_ARCH='x86-64-v3' -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=130400 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DBOOST_MPL_IGNORE_PARENTHESES_WARNING -DCMSSW_GIT_HASH='CMSSW_15_1_X_2025-06-09-2300' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_15_1_X_2025-06-09-2300' -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc13/cms/cmssw/CMSSW_15_1_X_2025-06-09-2300/src -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc13/cms/coral/CORAL_2_3_21-6a983813b127fd440267ce4ce3baafc2/include/LCG -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc13/external/pcre/8.43-6d98fda3bfd074ebb583e2d6a2c75d25/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc13/external/boost/1.80.0-7c95322172bddd4f4d4058d88084276a/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc13/external/bz2lib/1.0.6-d113e1c6278c07eeaff5f84db9548446/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc13/external/curl/7.79.0-f85273a965f53d4e6abeddf7ccaef037/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc13/external/libuuid/2.34-5ba7a8abfc0c5fecdc448cca360c25ff/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc13/lcg/root/6.32.13-a9161cdd951cd04d5ef75d13f5e82876/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc13/external/tbb/v2022.0.0-aac0791036768f03d11d4da28c986f66/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc13/external/xerces-c/3.1.3-ab719034dc2061fa61b09353203a0c2d/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc13/external/xz/5.6.4-b9c4ffbc390ed320a5d57fd552e29a05/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc13/external/zlib/1.2.13-589f6bb51bbeba38a7adf5a10ea8a093/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc13/external/fmt/10.2.1-31d67b0504b4ba2262f03d3c5cad83c1/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc13/external/md5/1.0.0-26057075013e190e56dad37d35219376/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc13/external/tinyxml2/6.2.0-67924ead96ecb4e69aad321b767979a5/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/el8_amd64_gcc13/src/CondCore/CondDB/test/testConnectionPool/testConnectionPool.cpp.d src/CondCore/CondDB/test/testConnectionPool.cpp -o tmp/el8_amd64_gcc13/src/CondCore/CondDB/test/testConnectionPool/testConnectionPool.cpp.o
>> Building binary testConnectionPool
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc13/external/gcc/13.4.0-6908cfdf803923e783448096ca4f0923/bin/c++ -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC  tmp/el8_amd64_gcc13/src/CondCore/CondDB/test/testConnectionPool/testConnectionPool.cpp.o -Wl,-E -Wl,--hash-style=gnu -Wl,--as-needed -Wl,-z,noexecstack -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_1_X_2025-06-09-2300/biglib/el8_amd64_gcc13 -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_1_X_2025-06-09-2300/lib/el8_amd64_gcc13 -L/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc13/cms/cmssw/CMSSW_15_1_X_2025-06-09-2300/biglib/el8_amd64_gcc13 -L/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc13/cms/cmssw/CMSSW_15_1_X_2025-06-09-2300/lib/el8_amd64_gcc13 -L/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc13/cms/cmssw/CMSSW_15_1_X_2025-06-09-2300/external/el8_amd64_gcc13/lib -L/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_15_1_X_2025-06-09-2300/static/el8_amd64_gcc13 -L/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc13/cms/cmssw/CMSSW_15_1_X_2025-06-09-2300/static/el8_amd64_gcc13 -lCondFormatsRunInfo -lCondCoreCondDB -lFWCoreFramework -lCondFormatsCommon -lFWCoreCommon -lFWCoreServiceRegistry -lDataFormatsCommon -lFWCoreParameterSet -lFWCoreAbstractServices -lFWCoreMessageLogger -lDataFormatsProvenance -lFWCoreConcurrency -lFWCorePluginManager -lFWCoreReflection -lCondFormatsSerialization -lFWCoreUtilities -lFWCoreVersion -lUtilitiesOpenSSL -llcg_CoralCommon -llcg_RelationalAccess -llcg_CoralKernel -llcg_CoralBase -lTree -lNet -lThread -lboost_filesystem -lMathCore -lRIO -lboost_program_options -lboost_serialization -lboost_system -lCore -lboost_thread -lboost_date_time -lpcre -lbz2 -lcurl -luuid -ltbb -lxerces-c -llzma -lz -lfmt -lcms-md5 -lssl -lcrypto -lcrypt -ldl -lrt -lstdc++fs -ltinyxml2 -o tmp/el8_amd64_gcc13/src/CondCore/CondDB/test/testConnectionPool/testConnectionPool
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc13/external/gcc/13.4.0-6908cfdf803923e783448096ca4f0923/bin/../lib/gcc/x86_64-redhat-linux-gnu/13.4.0/../../../../x86_64-redhat-linux-gnu/bin/ld.bfd: cannot find -lCondFormatsRunInfo: No such file or directory
collect2: error: ld returned 1 exit status
>> Deleted: tmp/el8_amd64_gcc13/src/CondCore/CondDB/test/testConnectionPool/testConnectionPool
gmake: *** [tmp/el8_amd64_gcc13/src/CondCore/CondDB/test/testConnectionPool/testConnectionPool] Error 1
>> Compiling  src/CondCore/CondDB/test/testFrontier.cpp
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc13/external/gcc/13.4.0-6908cfdf803923e783448096ca4f0923/bin/c++ -c -DCMS_MICRO_ARCH='x86-64-v3' -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=130400 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DBOOST_MPL_IGNORE_PARENTHESES_WARNING -DCMSSW_GIT_HASH='CMSSW_15_1_X_2025-06-09-2300' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_15_1_X_2025-06-09-2300' -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc13/cms/cmssw/CMSSW_15_1_X_2025-06-09-2300/src -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc13/cms/coral/CORAL_2_3_21-6a983813b127fd440267ce4ce3baafc2/include/LCG -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc13/external/pcre/8.43-6d98fda3bfd074ebb583e2d6a2c75d25/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc13/external/boost/1.80.0-7c95322172bddd4f4d4058d88084276a/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc13/external/bz2lib/1.0.6-d113e1c6278c07eeaff5f84db9548446/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc13/external/curl/7.79.0-f85273a965f53d4e6abeddf7ccaef037/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc13/external/libuuid/2.34-5ba7a8abfc0c5fecdc448cca360c25ff/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc13/lcg/root/6.32.13-a9161cdd951cd04d5ef75d13f5e82876/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc13/external/tbb/v2022.0.0-aac0791036768f03d11d4da28c986f66/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc13/external/xerces-c/3.1.3-ab719034dc2061fa61b09353203a0c2d/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc13/external/xz/5.6.4-b9c4ffbc390ed320a5d57fd552e29a05/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc13/external/zlib/1.2.13-589f6bb51bbeba38a7adf5a10ea8a093/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc13/external/fmt/10.2.1-31d67b0504b4ba2262f03d3c5cad83c1/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc13/external/md5/1.0.0-26057075013e190e56dad37d35219376/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc13/external/tinyxml2/6.2.0-67924ead96ecb4e69aad321b767979a5/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/el8_amd64_gcc13/src/CondCore/CondDB/test/testFrontier/testFrontier.cpp.d src/CondCore/CondDB/test/testFrontier.cpp -o tmp/el8_amd64_gcc13/src/CondCore/CondDB/test/testFrontier/testFrontier.cpp.o
>> Building binary testFrontier

smuzaffar · 2025-06-11T07:53:10Z

please test for el8_amd64_gcc13 using addpkg CondFormats/RunInfo

cmsbuild · 2025-06-11T08:09:41Z

-1

Failed Tests: UnitTests RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eba36c/46651/summary.html
COMMIT: f0a01d9
CMSSW: CMSSW_15_1_X_2025-06-10-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48279/46651/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 3 errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS
---> test test_MC_22_crosscheck had ERRORS
---> test test_MC_23_crosscheck had ERRORS

RelVals

135.4135.4_ZEEFS_13/step1_ZEEFS_13.log
1000.01000.0_RunMinBias2011A/step2_RunMinBias2011A.log
2500.3012500.301_NANOmc150X/step2_NANOmc150X.log

Expand to see more relval errors ...

AddOn Tests

fastsim

UNKNOWN

fastsim1

UNKNOWN

fastsim2

UNKNOWN

Expand to see more addon errors ...

smuzaffar · 2025-06-11T08:30:00Z

gcc13 build issues are fixed now https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eba36c/46651/build-logs/

Dr15Jones · 2025-06-11T13:54:48Z

@smuzaffar

gcc13 build issues are fixed now

Though I was inspired to look at this code because of the gcc13 problem, I didn't actually make the change to fix it (although it is a nice bonus). I'm pretty sure the original gcc13 problem are indicative of a compiler bug.

smuzaffar · 2025-06-11T14:26:56Z

it might be gcc bug . We recently update GCC 13 to 13.4.0 but the PR tests for that update did not show any build errors .

smuzaffar · 2025-06-11T16:05:43Z

it might be gcc bug . We recently update GCC 13 to 13.4.0 but the PR tests for that update did not show any build errors .

OK the gcc 13.4.0 PR tests did not fail as it only built the x86-64-v3 and failure is when we build for x86-64-v2

perrotta · 2025-06-12T11:50:27Z

+db

cmsbuild · 2025-06-12T11:50:51Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2025-06-16T06:27:22Z

+1

Make tableName constexpr in CondDB

7d13744

cmsbuild added this to the CMSSW_15_1_X milestone Jun 9, 2025

cmsbuild added db-pending pending-signatures orp-pending tests-started code-checks-pending labels Jun 9, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 9, 2025

cmsbuild added tests-rejected and removed tests-started labels Jun 9, 2025

make fullyQualifiedName consteval in CondDB

f0a01d9

Dr15Jones force-pushed the constexprCondDB branch from c813f2d to f0a01d9 Compare June 9, 2025 20:35

cmsbuild added tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels Jun 9, 2025

cmsbuild added tests-started code-checks-approved and removed tests-pending code-checks-pending labels Jun 9, 2025

cmsbuild added tests-approved and removed tests-started labels Jun 9, 2025

perrotta reviewed Jun 10, 2025

View reviewed changes

cmsbuild added fully-signed db-approved and removed db-pending pending-signatures labels Jun 12, 2025

cmsbuild added orp-approved and removed orp-pending labels Jun 16, 2025

cmsbuild merged commit fcb8257 into cms-sw:master Jun 16, 2025
13 of 16 checks passed

Dr15Jones deleted the constexprCondDB branch June 23, 2025 13:59

Use constexpr in CondDB query building #48279

Use constexpr in CondDB query building #48279

Uh oh!

Conversation

Dr15Jones commented Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

Uh oh!

Dr15Jones commented Jun 9, 2025

Uh oh!

cmsbuild commented Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Jun 9, 2025

Uh oh!

cmsbuild commented Jun 9, 2025

Uh oh!

cmsbuild commented Jun 9, 2025

Clang Build

Uh oh!

cmsbuild commented Jun 9, 2025

Uh oh!

Dr15Jones commented Jun 9, 2025

Uh oh!

cmsbuild commented Jun 9, 2025

Uh oh!

cmsbuild commented Jun 9, 2025

Comparison Summary

Uh oh!

perrotta Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

Dr15Jones Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

perrotta Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Dr15Jones Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

smuzaffar commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Jun 10, 2025

Build

Uh oh!

smuzaffar commented Jun 11, 2025

Uh oh!

cmsbuild commented Jun 11, 2025

Unit Tests

RelVals

AddOn Tests

Uh oh!

smuzaffar commented Jun 11, 2025

Uh oh!

Dr15Jones commented Jun 11, 2025

Uh oh!

smuzaffar commented Jun 11, 2025

Uh oh!

smuzaffar commented Jun 11, 2025

Uh oh!

perrotta commented Jun 12, 2025

Uh oh!

cmsbuild commented Jun 12, 2025

Uh oh!

mandrenguyen commented Jun 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Dr15Jones commented Jun 9, 2025 •

edited

Loading

cmsbuild commented Jun 9, 2025 •

edited

Loading

perrotta Jun 10, 2025 •

edited

Loading

smuzaffar commented Jun 10, 2025 •

edited

Loading