Skip to content

Conversation

@hqucms
Copy link
Contributor

@hqucms hqucms commented May 28, 2025

backport of #48152

PR description:

Update NANO relval workflows to include using 150X data and MC as inputs.

This factorizes out the needed relval updates in #48104.

PR validation:

runTheMatrix.py -w nano --ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

to be backported to 150X

@cmsbuild
Copy link
Contributor

cmsbuild commented May 28, 2025

A new Pull Request was created by @hqucms for CMSSW_15_0_X.

It involves the following packages:

  • Configuration/ProcessModifiers (operations)
  • Configuration/PyReleaseValidation (upgrade, pdmv)
  • PhysicsTools/NanoAOD (xpog)
  • Validation/RecoTau (dqm)

@AdrianoDee, @Moanwar, @antoniovagnerini, @antoniovilela, @cmsbuild, @ctarricone, @davidlange6, @DickyChant, @fabiocos, @ftorrresd, @hqucms, @mandrenguyen, @miquork, @rappoccio, @rseidita, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @gpetruc, @makortel, @missirol, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@hqucms hqucms changed the title Xpog/nano relval update 150x [150X, backport of #48152] Update NANO relval workflows May 28, 2025
@cmsbuild
Copy link
Contributor

cmsbuild commented May 28, 2025

cms-bot internal usage

@hqucms
Copy link
Contributor Author

hqucms commented May 28, 2025

enable nano

@hqucms
Copy link
Contributor Author

hqucms commented May 28, 2025

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d94d35/46400/summary.html
COMMIT: b6b932d
CMSSW: CMSSW_15_0_X_2025-05-27-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48189/46400/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 4003557
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4003534
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 216 log files, 188 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

The workflows 2500.331, 2500.321, 2500.311, 2500.301 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

  • You potentially removed 314 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 21
  • DQMHistoTests: Total histograms compared: 70820
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 70820
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 16 files compared)
  • Checked 92 log files, 55 edm output root files, 21 DQM output files
  • TriggerResults: no differences found

Nano size comparison Summary:

  • Nano ERROR: Missing ref/2500.261_NANOmc2024reMINI-size.json
  • Nano ERROR: Missing ref/2500.261_NANOmc2024reMINI-size.json
  • Nano ERROR: Missing ref/2500.271_NANOdata2024reMINI-size.json
  • Nano ERROR: Missing ref/2500.271_NANOdata2024reMINI-size.json
  • Nano ERROR: Missing ref/2500.301_NANOmc150X-size.json
  • Nano ERROR: Missing ref/2500.301_NANOmc150X-size.json
  • Nano ERROR: Missing ref/2500.311_NANOdata150X-size.json
  • Nano ERROR: Missing ref/2500.311_NANOdata150X-size.json
  • Nano ERROR: Missing ref/2500.312_NANOdata150X-size.json
  • Nano ERROR: Missing ref/2500.312_NANOdata150X-size.json
  • Nano ERROR: Missing ref/2500.321_muPOGNANOmc150X-size.json
  • Nano ERROR: Missing ref/2500.321_muPOGNANOmc150X-size.json
  • Nano ERROR: Missing ref/2500.322_EGMNANOmc150X-size.json
  • Nano ERROR: Missing ref/2500.322_EGMNANOmc150X-size.json
  • Nano ERROR: Missing ref/2500.323_BTVNANOmc150X-size.json
  • Nano ERROR: Missing ref/2500.323_BTVNANOmc150X-size.json
  • Nano ERROR: Missing ref/2500.324_jmeNANOmc150X-size.json
  • Nano ERROR: Missing ref/2500.324_jmeNANOmc150X-size.json
  • Nano ERROR: Missing ref/2500.325_jmeNANOrePuppimc150X-size.json
  • Nano ERROR: Missing ref/2500.325_jmeNANOrePuppimc150X-size.json
  • Nano ERROR: Missing ref/2500.326_lepTrackInfoNANOmc150X-size.json
  • Nano ERROR: Missing ref/2500.326_lepTrackInfoNANOmc150X-size.json
  • Nano ERROR: Missing ref/2500.327_ScoutingNANOmc150X-size.json
  • Nano ERROR: Missing ref/2500.327_ScoutingNANOmc150X-size.json
  • Nano ERROR: Missing ref/2500.328_ScoutingNANOwithPromptmc150X-size.json
  • Nano ERROR: Missing ref/2500.328_ScoutingNANOwithPromptmc150X-size.json
  • Nano ERROR: Missing ref/2500.329_BPHNANOmc150X-size.json
  • Nano ERROR: Missing ref/2500.329_BPHNANOmc150X-size.json
  • Nano ERROR: Missing ref/2500.331_muPOGNANO150Xrun3-size.json
  • Nano ERROR: Missing ref/2500.331_muPOGNANO150Xrun3-size.json
  • Nano ERROR: Missing ref/2500.332_EGMNANOdata150Xrun3-size.json
  • Nano ERROR: Missing ref/2500.332_EGMNANOdata150Xrun3-size.json
  • Nano ERROR: Missing ref/2500.333_BTVNANOdata150Xrun3-size.json
  • Nano ERROR: Missing ref/2500.333_BTVNANOdata150Xrun3-size.json
  • Nano ERROR: Missing ref/2500.334_jmeNANOdata150Xrun3-size.json
  • Nano ERROR: Missing ref/2500.334_jmeNANOdata150Xrun3-size.json
  • Nano ERROR: Missing ref/2500.335_jmeNANOrePuppidata150Xrun3-size.json
  • Nano ERROR: Missing ref/2500.335_jmeNANOrePuppidata150Xrun3-size.json
  • Nano ERROR: Missing ref/2500.336_lepTrackInfoNANOdata150Xrun3-size.json
  • Nano ERROR: Missing ref/2500.336_lepTrackInfoNANOdata150Xrun3-size.json
  • Nano ERROR: Missing ref/2500.337_ScoutingNANOdata150Xrun3-size.json
  • Nano ERROR: Missing ref/2500.337_ScoutingNANOdata150Xrun3-size.json
  • Nano ERROR: Missing ref/2500.338_ScoutingNANOwithPromptdata150Xrun3-size.json
  • Nano ERROR: Missing ref/2500.338_ScoutingNANOwithPromptdata150Xrun3-size.json
  • Nano ERROR: Missing ref/2500.339_BPHNANOdata150Xrun3-size.json
  • Nano ERROR: Missing ref/2500.339_BPHNANOdata150Xrun3-size.json
    | Sample | kb/ev | ref kb/ev | diff kb/ev | ev/s/thd | ref ev/s/thd | diff rate | mem/thd | ref mem/thd |
    | --- | --- | --- | --- | --- | --- | --- | --- | --- |
    | 2500.001_NANOmc106Xul16v2 | 3.115 | 3.115 | 0.000 ( +0.0% ) | 6.08 | 6.20 | -1.8% | 2.427 | 2.591 |
    | 2500.002_NANOmc106Xul17v2 | 3.231 | 3.231 | 0.000 ( +0.0% ) | 5.49 | 5.44 | +0.9% | 2.833 | 3.053 |
    | 2500.003_NANOmc106Xul18v2 | 3.172 | 3.172 | 0.000 ( +0.0% ) | 5.45 | 5.57 | -2.2% | 2.848 | 3.047 |
    | 2500.011_NANOdata106Xul16v2 | 1.647 | 1.647 | 0.000 ( +0.0% ) | 9.76 | 10.72 | -9.0% | 2.516 | 2.628 |
    | 2500.012_NANOdata106Xul17v2 | 2.185 | 2.185 | 0.000 ( +0.0% ) | 5.71 | 5.81 | -1.9% | 2.662 | 2.751 |
    | 2500.013_NANOdata106Xul18v2 | 2.002 | 2.002 | 0.000 ( +0.0% ) | 7.79 | 8.22 | -5.2% | 2.606 | 2.701 |
    | 2500.021_NANOmcUL16APVreMINI | 0.022 | 0.022 | 0.000 ( +0.0% ) | 1.57 | 1.78 | -11.9% | 2.540 | 2.579 |
    | 2500.022_NANOmcUL16reMINI | 0.022 | 0.022 | 0.000 ( +0.0% ) | 1.59 | 1.73 | -8.3% | 2.531 | 2.568 |
    | 2500.023_NANOmcUL17reMINI | 0.022 | 0.022 | 0.000 ( +0.0% ) | 1.37 | 1.49 | -7.8% | 2.505 | 2.552 |
    | 2500.024_NANOmcUL18reMINI | 0.022 | 0.022 | 0.000 ( +0.0% ) | 1.26 | 1.34 | -6.0% | 2.686 | 2.722 |
    | 2500.031_NANOdataUL16APVreMINI | 0.035 | 0.035 | 0.000 ( +0.0% ) | 1.40 | 1.55 | -9.6% | 2.633 | 2.695 |
    | 2500.032_NANOdataUL16reMINI | 0.036 | 0.036 | 0.000 ( +0.0% ) | 1.43 | 1.57 | -9.0% | 2.551 | 2.613 |
    | 2500.033_NANOdataUL17reMINI | 0.037 | 0.037 | -0.000 ( -0.1% ) | 1.37 | 1.49 | -8.3% | 2.669 | 2.709 |
    | 2500.034_NANOdataUL18reMINI | 0.036 | 0.036 | 0.000 ( +0.0% ) | 1.35 | 1.48 | -9.4% | 2.646 | 2.698 |
    | 2500.101_NANOmc130X | 2.872 | 2.872 | 0.000 ( +0.0% ) | 13.75 | 14.77 | -6.9% | 2.535 | 2.665 |
    | 2500.111_NANOdata130Xrun3 | 1.474 | 1.474 | 0.000 ( +0.0% ) | 25.24 | 29.53 | -14.5% | 2.243 | 2.404 |
    | 2500.131_ScoutingNANOdata130Xrun3 | 0.771 | 0.771 | 0.000 ( +0.0% ) | 30.26 | 27.88 | +8.6% | 1.478 | 1.612 |
    | 2500.221_muPOGNANOmc140X | 2.062 | 2.141 | -0.079 ( -3.7% ) | 11.96 | 13.02 | -8.1% | 1.868 | 1.908 |
    | 2500.222_EGMNANOmc140X | 3.516 | 3.516 | 0.000 ( +0.0% ) | 11.32 | 11.91 | -5.0% | 1.938 | 1.971 |
    | 2500.223_BTVNANOmc140X | 10.327 | 10.328 | -0.001 ( -0.0% ) | 4.02 | 4.27 | -5.9% | 2.137 | 2.082 |
    | 2500.224_jmeNANOmc140X | 6.593 | 6.593 | 0.000 ( +0.0% ) | 1.04 | 1.12 | -7.0% | 2.088 | 2.091 |
    | 2500.226_lepTrackInfoNANOmc140X | 3.210 | 3.210 | 0.000 ( +0.0% ) | 11.82 | 12.63 | -6.4% | 1.933 | 1.939 |
    | 2500.227_ScoutingNANOmc140X | 1.486 | 1.486 | 0.000 ( +0.0% ) | 14.03 | 14.32 | -2.0% | 1.746 | 1.746 |
    | 2500.228_ScoutingNANOwithPromptmc140X | 4.105 | 4.105 | 0.000 ( +0.0% ) | 7.42 | 7.42 | +0.1% | 2.220 | 2.388 |
    | 2500.231_muPOGNANO140Xrun3 | 1.462 | 1.516 | -0.054 ( -3.6% ) | 18.22 | 18.37 | -0.8% | 2.146 | 2.140 |
    | 2500.232_EGMNANOdata140Xrun3 | 2.502 | 2.502 | 0.000 ( +0.0% ) | 17.69 | 17.97 | -1.6% | 2.191 | 2.210 |
    | 2500.233_BTVNANOdata140Xrun3 | 5.422 | 5.422 | 0.000 ( +0.0% ) | 6.03 | 5.98 | +0.8% | 2.089 | 2.392 |
    | 2500.234_jmeNANOdata140Xrun3 | 3.931 | 3.931 | 0.000 ( +0.0% ) | 1.35 | 1.40 | -3.7% | 2.054 | 2.017 |
    | 2500.236_lepTrackInfoNANOdata140Xrun3 | 2.292 | 2.292 | 0.000 ( +0.0% ) | 18.64 | 18.88 | -1.3% | 2.197 | 2.219 |
    | 2500.237_ScoutingNANOdata140Xrun3 | 1.101 | 1.101 | 0.000 ( +0.0% ) | 26.90 | 26.99 | -0.3% | 1.282 | 1.633 |
    | 2500.238_ScoutingNANOwithPromptdata140Xrun3 | 2.595 | 2.595 | 0.000 ( +0.0% ) | 12.65 | 12.59 | +0.5% | 2.285 | 2.454 |
    | 2500.241_l1DPGNANO140Xrun3 | 9.404 | 9.404 | 0.000 ( +0.0% ) | 6.25 | 5.96 | +5.0% | 1.776 | 1.781 |
    | 2500.242_muDPGNANO140Xrun3 | 10.331 | 10.331 | 0.000 ( +0.0% ) | 1.30 | 1.48 | -11.8% | 1.619 | 1.619 |
    | 2500.243_muDPGNANOBkg140Xrun3 | 2.712 | 2.712 | 0.000 ( +0.0% ) | 13.16 | 14.01 | -6.1% | 0.998 | 1.054 |
    | 2500.244_hcalDPGNANO140Xrun3 | 486.016 | 486.016 | 0.000 ( +0.0% ) | 1.05 | 1.02 | +3.2% | 1.576 | 1.670 |
    | 2500.245_hcalDPGCalibNANO140Xrun3 | 826.413 | 826.413 | 0.000 ( +0.0% ) | 1.41 | 1.41 | -0.1% | 1.534 | 1.647 |
    | 2500.251_hcalDPGMCNANO140Xrun3 | 645.333 | 645.333 | 0.000 ( +0.0% ) | 1.54 | 1.51 | +2.3% | 1.637 | 1.777 |
    | 2500.901_TTbarMINIAOD10.6_UL18v2 | 1.819 | 1.819 | 0.000 ( +0.0% ) | 32.83 | 30.30 | +8.4% | 1.756 | 1.838 |
    | 2500.902_TTbarMINIAOD14.0 | 1.665 | 1.665 | 0.000 ( +0.0% ) | 33.14 | 28.97 | +14.4% | 1.415 | 1.458 |
    | 2500.911_DYToLL_M-50_13TeV_pythia8 | 14.345 | 14.345 | 0.000 ( +0.0% ) | 7.05 | 6.94 | +1.6% | 1.082 | 1.087 |
    | 2500.912_DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV | 0.729 | 0.438 | 0.291 ( +66.4% ) | 3.07 | 2.00 | +53.5% | 0.845 | 0.848 |
    | 2500.913_TTbar_Pow_LHE_13TeV | 0.110 | 0.110 | 0.000 ( +0.0% ) | 2.66 | 2.43 | +9.6% | 0.851 | 0.848 |

@hqucms
Copy link
Contributor Author

hqucms commented May 28, 2025

+1

@antoniovagnerini
Copy link

+dqm

@hqucms
Copy link
Contributor Author

hqucms commented Jun 2, 2025

ping @cms-sw/upgrade-l2 @cms-sw/pdmv-l2 -- We would like to get this merged ASAP to test again #48176, which is needed for the 2022/2023/Run2 reMINI-from-MINI + NANO. Thanks!

@AdrianoDee
Copy link
Contributor

+pdmv

@Moanwar
Copy link
Contributor

Moanwar commented Jun 2, 2025

+Upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2025

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2025

REMINDER @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen: This PR was tested with #48176, please check if they should be merged together

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 892a359 into cms-sw:CMSSW_15_0_X Jun 4, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants