use BX info in L1-uGT emulation of CICADA conditions

[missirol]

PR description:

@rseidita reported that #48037 does not entirely fix the L1-uGT data-emulator discrepancies related to the CICADA seeds which are currently observed in the online DQM. It seems that, after including #48037, there are disagreements of the type "emulator fired but not data" in BXs different from the central one.

From a quick look at the L1-uGT emulator, I think this might be related to the L1-uGT emulator itself.

• In CICADA-uGT emulator additions #44222, the CICADA score was implemented as a data member of GlobalBoard (see m_cicadaScore), setting its value to the CICADA score for BX=0.
• While this works for BX=0, I think it leads to computing the emulated CICADA decisions for BX!=0 using the CICADA score for BX=0. This may explain why the emulator fires more often than data for BX!=0 in Roberto's tests.

This PR implements the use of CICADA scores from the relevant BXs when evaluating the decisions of CICADA seeds in the L1-uGT emulator.

PR validation:

None from my side. Dedicated tests were done by @rseidita (I let him comment on the outcome of his checks).

Edit (May-22): see #48142 (comment).

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

To be backported to CMSSW_15_0_X (2025 pp data-taking cycle) to reduce L1-uGT data-emulator mismatches in online DQM.

Note : the L1-uGT emulator also runs in the HLT jobs, and at T0 (e.g. offline reco), so this PR indirectly touches all those workflows as well.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48142/44906

[cmsbuild]

A new Pull Request was created by @missirol for master.

It involves the following packages:

• L1Trigger/L1TGlobal (l1)

@BenjaminRS, @cmsbuild, @quinnanm can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @mmusich this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[quinnanm]

please test

[cmsbuild]

+1

Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8cefad/46306/summary.html
COMMIT: 0155f31
CMSSW: CMSSW_15_1_X_2025-05-21-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48142/46306/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 4038193
• DQMHistoTests: Total failures: 50
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4038123
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 215 log files, 184 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[rseidita]

This change was tested on data from run 392301 in the playback DQM machines in P5 with the following configurations:
CMSSW_15_0_6, CMSSW_15_0_6+#48037, and CMSSW_15_0_6+#48037+#48142. Results here (sharing slides since playback DQM GUI links become stale when changing version).

As @missirol said, #48037 seems to cure the majority of mismatches in the central BX, but introduces the same order of mismatches in adjacent ones. This PR seems to address this.

[rseidita]

For the sake of completeness, the remaining mismatches seem to be on bit 422 which is AXO_Loose

[aloeliger]

@missirol Thanks for catching this!

[aloeliger]

Also @rseidita thanks for the checks!

[aloeliger]

As a note about CICADA emulation however. CICADA emulation has no time multiplexing information, so the emulator cannot provide BX -2, -1, +1, or +2 information correctly if it is feeding uGT emulation directly.

That is to say, in cases where CICADA emulation is direct input to uGT emulation (instead of unpacking CICADA), disagreements between data and emulation will be found in any non-central BX.

[quinnanm]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1