Skip to content

Conversation

@missirol
Copy link
Contributor

backport of #48142

PR description:

From the description of #48142.

@rseidita reported that #48037 does not entirely fix the L1-uGT data-emulator discrepancies related to the CICADA seeds which are currently observed in the online DQM. It seems that, after including #48037, there are disagreements of the type "emulator fired but not data" in BXs different from the central one.

From a quick look at the L1-uGT emulator, I think this might be related to the L1-uGT emulator itself.

  • In CICADA-uGT emulator additions #44222, the CICADA score was implemented as a data member of GlobalBoard (see m_cicadaScore), setting its value to the CICADA score for BX=0.

  • While this works for BX=0, I think it leads to computing the emulated CICADA decisions for BX!=0 using the CICADA score for BX=0. This may explain why the emulator fires more often than data for BX!=0 in Roberto's tests.

This PR implements the use of CICADA scores from the relevant BXs when evaluating the decisions of CICADA seeds in the L1-uGT emulator.

PR validation:

None beyond the checks discussed in #48142.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

CMSSW_15_0_X

Fix for the L1-uGT emulator (mainly to fix data-emulator mismatches in online DQM).

Note : the L1-uGT emulator also runs in the HLT jobs, and at T0 (e.g. offline reco), so this PR indirectly touches all those workflows as well.

@cmsbuild cmsbuild added this to the CMSSW_15_0_X milestone May 23, 2025
@cmsbuild
Copy link
Contributor

cmsbuild commented May 23, 2025

A new Pull Request was created by @missirol for CMSSW_15_0_X.

It involves the following packages:

  • L1Trigger/L1TGlobal (l1)

@BenjaminRS, @cmsbuild, @quinnanm can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @mmusich this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 23, 2025

cms-bot internal usage

@BenjaminRS
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-154fc1/46352/summary.html
COMMIT: 4b5fd13
CMSSW: CMSSW_15_0_X_2025-05-25-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48164/46352/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@BenjaminRS
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e7168b9 into cms-sw:CMSSW_15_0_X May 27, 2025
9 checks passed
@missirol missirol deleted the devel_l1tCICADAScoreBXInfoInL1uGT_150X branch June 13, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants