Calo towers L1 scouting data format update #48093

tj710 · 2025-05-15T16:31:11Z

PR description:

We add new data formats for L1 Scouting, which will this year be collecting the L1 Calo Trigger 'towers', in addition to the contents of the previous years.

PR validation:

The tests are documented in /DataFormats/L1Scouting/test/TestL1ScoutingFormat.sh

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

We require backport to CMSSW 16_1_X for data taking purposes from start of 2026 data taking.

Before submitting your pull requests, make sure you followed this checklist:

Associated data files are in: cms-data/DataFormats-L1Scouting#5

cmsbuild · 2025-05-15T16:32:09Z

This PR contains too many commits (400 >= 240) and will not be processed.
Please ensure you have selected the correct target branch and consider squashing unnecessary commits.
The processing of this PR will resume once the commit count drops below the limit.

… and unpackers

cmsbuild · 2025-05-15T22:33:07Z

cms-bot internal usage

cmsbuild · 2025-05-15T22:34:20Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48093/44845

ERROR: Build errors found during clang-tidy run.

src/L1TriggerScouting/OnlineProcessing/plugins/ScoutingJetProducer.cc:13:10: error: 'FWCore/Utilities/interface/Span.h' file not found [clang-diagnostic-error]
   13 | #include "FWCore/Utilities/interface/Span.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Suppressed 833 warnings (833 in non-user code).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

DataFormats/L1Scouting/test/read_L1Scouting_cfg.py

cmsbuild · 2025-05-16T13:37:43Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48093/44855

There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/L1Scouting/test/TestReadL1Scouting.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
- File DataFormats/L1Scouting/test/TestWriteL1Scouting.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48093/44855/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48093/44855/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2026-01-20T16:55:14Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48093/47582

There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/L1Scouting/test/TestReadL1Scouting.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
- File DataFormats/L1Scouting/test/TestWriteL1Scouting.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372

cmsbuild · 2026-01-20T16:55:44Z

Pull request #48093 was updated. @BenjaminRS, @cmsbuild, @emeschi, @quinnanm, @smorovic can you please check and sign again.

cmsbuild · 2026-01-20T17:01:24Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48093/47583

There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/L1Scouting/test/TestReadL1Scouting.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
- File DataFormats/L1Scouting/test/TestWriteL1Scouting.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372

cmsbuild · 2026-01-20T17:01:49Z

Pull request #48093 was updated. @BenjaminRS, @cmsbuild, @emeschi, @quinnanm, @smorovic can you please check and sign again.

cmsbuild · 2026-01-20T17:14:13Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48093/47585

There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/L1Scouting/test/TestReadL1Scouting.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
- File DataFormats/L1Scouting/test/TestWriteL1Scouting.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372

cmsbuild · 2026-01-20T17:14:34Z

Pull request #48093 was updated. @BenjaminRS, @cmsbuild, @emeschi, @quinnanm, @smorovic can you please check and sign again.

missirol

Two more comments (hopefully, the last ones).

Thanks for changing the position of mass in the jet data format.

missirol · 2026-01-20T17:27:58Z

DataFormats/L1Scouting/interface/L1ScoutingCaloTower.h

+#define DataFormats_L1Scouting_L1ScoutingCaloTower_h
+
+#include "DataFormats/L1Scouting/interface/OrbitCollection.h"
+


Because of int16_t, this file should now include

#include <cstdint>

Done. Do you know why the compiler does not complain about this?

Not really. I guess it's because OrbitCollection.h (which is also included) happens to include itself cstdint.

So should I still add it to this file, or is it not needed? Thanks

Generally the best practice is for every header and source file to #include the headers that it needs rather than rely on transitive #includes. E.g. hypothetically changing OrbitCollection.h to not #include <cstdint> would result in compilation failures here.

missirol · 2026-01-20T17:52:34Z

EventFilter/L1ScoutingRawToDigi/plugins/ScCaloTowerRawToDigi.cc

+      erBits = ((ct_raw >> l1ScoutingRun3::calol2::shiftsCaloTowers::erBits) &
+                l1ScoutingRun3::calol2::masksCaloTowers::erBits);
+      miscBits = ((ct_raw >> l1ScoutingRun3::calol2::shiftsCaloTowers::miscBits) &
+                  l1ScoutingRun3::calol2::masksCaloTowers::miscBits);


Let's see if I get it (maybe I do not).

erBits is shifted by 9 and the mask is 0x000e == 1110 , so the selected bits are (10,11,12).

miscBits is shifted by 12 and the mask is 0x000f == 1111, so the selected bits are (12,13,14,15).

It looks like bit 12 is used for both. Is that right ? If so, intended ?

Hi Marino

I understand it as the following:
- erBits is shifted by 9 and the mask is 0x000e == 1110 , so the selected bits are (9,10,11).

miscBits is shifted by 12 and the mask is 0x000f == 1111, so the selected bits are (12,13,14,15).

So there is no overlap.

Thanks a lot

Best regards

Thomas

Hi @tj710. What @missirol is saying is correct and that pointed to a bug in the code

Firstly, this is the format of the tower as it is sent by the scouting readout boards

bits content

31-24 ieta (signed, int8_t)

23-16 iphi (unsigned, uint8_t)

15 Ecal fine-grain flag

14 Hcal feature flag

13 E-over-H flag

12 Denominator=0 flag

11-9 Energy ratio

0-8 Total energy (Ecal + Hcal)

The mask for the energy ratio (erBits) is currently 0x000e and the shift is 9. Now that I am looking again at this, this is not correct (it was a typo made in a commit where I have introduced the shifts) and it indeed causes what Marino is describing. The correct mask should be 0x0007 if we use 9 as shift. Can you update?

Hi Rocco, thanks for explaining.

It's now fixed.

RoccoA97 · 2026-01-21T15:52:35Z

EventFilter/L1ScoutingRawToDigi/interface/masks.h

    };
  }  // namespace bmtf

+  namespace calol2 {


Maybe we should change namespace name to calol1?

RoccoA97 · 2026-01-21T15:53:03Z

EventFilter/L1ScoutingRawToDigi/interface/masks.h

+  namespace calol2 {
+    struct masksCaloTowers {
+      static constexpr uint32_t ET = 0x01ff;
+      static constexpr uint32_t erBits = 0x000e;


This mask should be 0x0007 (mea culpa)

RoccoA97 · 2026-01-21T15:53:29Z

EventFilter/L1ScoutingRawToDigi/interface/shifts.h

    };
  }  // namespace bmtf

+  namespace calol2 {


Same as before, maybe this namespace should be calol1

RoccoA97 · 2026-01-21T16:00:30Z

EventFilter/L1ScoutingRawToDigi/interface/masks.h

+      static constexpr uint32_t zeroFlag = 0x0001;
+      static constexpr uint32_t eohrFlag = 0x0002;
+      static constexpr uint32_t hcalFlag = 0x0004;
+      static constexpr uint32_t ecalFlag = 0x0008;


Not as relevant as before, but all these masks should be 0x0001. It is not a big deal as we unpack all of them together in miscBits rather than one by one

cmsbuild · 2026-01-21T16:25:44Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48093/47606

There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/L1Scouting/test/TestReadL1Scouting.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372
- File DataFormats/L1Scouting/test/TestWriteL1Scouting.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372

cmsbuild · 2026-01-21T16:26:04Z

Pull request #48093 was updated. @BenjaminRS, @cmsbuild, @emeschi, @quinnanm, @smorovic can you please check and sign again.

missirol · 2026-01-30T12:37:06Z

@cms-sw/l1-l2 , do you have any further comments on this PR ?

It would be good to move forward, since this is related to 2026 data-taking (so, to be backported to 16_0_X).
It looks like #48093 (comment) is the only outstanding comment (by now it applies to only one plugin, i.e. ScoutingJetProducer). I would suggest to leave it to a follow-up PR, to avoid delaying this one (I can take care of that, if that helps).

@tj710, before this gets merged, could you please squash this PR into one (or, just a few) commits, to have a cleaner git history ? (the reviewers might ask this anyway)

cmsbuild added this to the CMSSW_15_1_X milestone May 15, 2025

This was referenced May 15, 2025

Add storage tracer #48073

Merged

[NGT] Introduce NanoAOD flavour for Phase 2 HLT #48091

Merged

RoccoA97 and others added 6 commits May 16, 2025 00:30

Add support for CaloTower L1 Scouting with data format, blocks, masks…

d83cd2b

… and unpackers

Include new collection L1Scouting FastJet and producer

e786cd0

Fix wrong calo tower word masks

c4f70d5

Added tests for calo towers

158489d

Fixed L1 scouting OrbitCollection constructor

94004b7

updated CaloTowerMinSDSID and an argument in L1Scout file tests

cb130de

tj710 force-pushed the rebased branch from 34623be to cb130de Compare May 15, 2025 22:32

cmsbuild added l1-pending daq-pending pending-signatures tests-pending orp-pending code-checks-pending changes-dataformats labels May 15, 2025

cmsbuild added code-checks-rejected and removed code-checks-pending labels May 15, 2025

missirol reviewed May 16, 2025

View reviewed changes

DataFormats/L1Scouting/test/read_L1Scouting_cfg.py Outdated Show resolved Hide resolved

removed include of depreciated edm::span

bd06f05

cmsbuild added code-checks-pending and removed code-checks-rejected labels May 16, 2025

cmsbuild added code-checks-rejected and removed code-checks-pending labels May 16, 2025

applied code format rules and fixed typo

731ffef

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 20, 2026

replaced all uint16_t with int16_t in L1ScoutingCaloTower

035eb2d

cmsbuild added code-checks-pending and removed code-checks-approved labels Jan 20, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 20, 2026

moved position of mass in L1ScoutingFastJet class

8ad1596

cmsbuild added code-checks-pending and removed code-checks-approved labels Jan 20, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 20, 2026

missirol reviewed Jan 20, 2026

View reviewed changes

RoccoA97 suggested changes Jan 21, 2026

View reviewed changes

fixed erBits mask

bfce20e

cmsbuild added code-checks-pending and removed code-checks-approved labels Jan 21, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 21, 2026

tj710 requested a review from RoccoA97 January 21, 2026 16:51

		#define DataFormats_L1Scouting_L1ScoutingCaloTower_h

		#include "DataFormats/L1Scouting/interface/OrbitCollection.h"

bits	content
31-24	ieta (signed, `int8_t`)
23-16	iphi (unsigned, `uint8_t`)
15	Ecal fine-grain flag
14	Hcal feature flag
13	E-over-H flag
12	Denominator=0 flag
11-9	Energy ratio
0-8	Total energy (Ecal + Hcal)

Calo towers L1 scouting data format update #48093

Are you sure you want to change the base?

Calo towers L1 scouting data format update #48093

Conversation

tj710 commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Uh oh!

cmsbuild commented May 15, 2025

Uh oh!

cmsbuild commented May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented May 15, 2025

Uh oh!

Uh oh!

cmsbuild commented May 16, 2025

Uh oh!

cmsbuild commented Jan 20, 2026

Uh oh!

cmsbuild commented Jan 20, 2026

Uh oh!

cmsbuild commented Jan 20, 2026

Uh oh!

cmsbuild commented Jan 20, 2026

Uh oh!

cmsbuild commented Jan 20, 2026

Uh oh!

cmsbuild commented Jan 20, 2026

Uh oh!

missirol left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RoccoA97 Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cmsbuild commented Jan 21, 2026

Uh oh!

cmsbuild commented Jan 21, 2026

Uh oh!

missirol commented Jan 30, 2026

Uh oh!

Reviewers

Assignees

Labels

tj710 commented May 15, 2025 •

edited

Loading

cmsbuild commented May 15, 2025 •

edited

Loading

RoccoA97 Jan 21, 2026 •

edited

Loading