Add storage tracer #48073
Add storage tracer #48073
Conversation
|
cms-bot internal usage |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48073/44804 Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48073/44805 |
|
A new Pull Request was created by @makortel for master. It involves the following packages:
@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test |
|
@Dr15Jones Could you review? |
| #include <thread> | ||
|
|
||
| namespace edm::storage { | ||
| class StorageAddLatencyProxy : public Storage { |
There was a problem hiding this comment.
Suggestions for better name for this component?
There was a problem hiding this comment.
I'm OK with this name. What is it you are uncomfortable with for this name?
There was a problem hiding this comment.
Just a feeling there could exist a better phrasing
|
-1 Failed Tests: Build ClangBuild BuildI found compilation warning when building: See details on the summary page. Clang BuildI found compilation warning while trying to compile with clang. Command used: See details on the summary page. |
Note: this commit also removes the possibility for lazy-download to cache the file with 'file:' protocol (LocalStorageMaker) when the LocalFileSystem code determined the file resides in a "non-local" file system. I.e. now lazy-download has no effect with the 'file:' protocol.
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48073/44842
|
|
Pull request #48073 was updated. @Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please check and sign again. |
|
@cmsbuild, please test |
|
+1 Size: This PR adds an extra 24KB to repository Comparison SummarySummary:
|
|
Comparison differences are related to #47071 |
|
+core |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
4 participants
PR description:
The context of this PR is the investigation in #47750.
First this PR adds capability for generic storage proxies (after improving
TFileAdaptorfillDescriptions()and refactoring the wayStorageFactorywrapsedm::storage::Storageobjects intoLocalCacheFile). These proxies are components that implement theStorageAPI and hold a anotherStorageobject. The proxies are implemented as validated plugins, and they are configured bia theTFileAdaptor(i.e.AdaptorConfigService).This PR implements two such proxy components
StorageTracerProxyfor tracing the operations, including a script to do some analysis on the traceStorageAddLatencyProxyfor adding artificial latency to the operationsResolves cms-sw/framework-team#1361
Resolves cms-sw/framework-team#1391
PR validation:
The tracer and latency addition code were extensively used when studying #47750