Skip to content

Conversation

@patinkaew
Copy link
Contributor

PR description:

Backport of cms-sw/cmssw#47934: ScoutingNano Event Content Changes for 2022-25.

PR validation:

Pass all tests from scram b runtests use-ibeos.
Pass all ScoutingNano-related relval_nano workflows from

runTheMatrix.py --ibeos -l 2500.131,2500.227,2500.228,2500.237,2500.238

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a backport to 15_0_X release cycle for 2025 data-taking and ScoutingNano reprocessing of 2022-24 data.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 25, 2025

A new Pull Request was created by @patinkaew for CMSSW_15_0_X.

It involves the following packages:

  • Configuration/Eras (operations)
  • PhysicsTools/NanoAOD (xpog)

@antoniovilela, @cmsbuild, @davidlange6, @fabiocos, @ftorrresd, @hqucms, @mandrenguyen, @rappoccio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @gpetruc, @makortel, @missirol this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 25, 2025

cms-bot internal usage

@patinkaew patinkaew changed the title Backport of #47934 (ScoutingNano Event Content Changes for 2022-25) [15_0_X] Backport of #47934 (ScoutingNano Event Content Changes for 2022-25) Apr 25, 2025
@missirol
Copy link
Contributor

Hi @patinkaew @silviodonato @elfontan

  • As far as I understand, this PR updates the content of "ScoutingNano" also for 2025 data-taking ("ScoutingNano" runs at T0).
  • I suppose this will not be deployed for the first 2025 pp fills (those are expected to start in less than a week from now, and this PR is not yet integrated).

Some naive questions.

  • What is the timeline then ? Is the idea that a release with this will get deployed at T0 whenever ready (incl. T0 replay), and this should be accompanied by a processing-version change, or something else ?

(cc: ORM, @davidlange6)

@silviodonato
Copy link
Contributor

please test

@patinkaew
Copy link
Contributor Author

Hi @silviodonato

please test

I think we also need to enable nano?

@patinkaew
Copy link
Contributor Author

Hi @missirol

Hi @patinkaew @silviodonato @elfontan

  • As far as I understand, this PR updates the content of "ScoutingNano" also for 2025 data-taking ("ScoutingNano" runs at T0).
  • I suppose this will not be deployed for the first 2025 pp fills (those are expected to start in less than a week from now, and this PR is not yet integrated).

Some naive questions.

  • What is the timeline then ? Is the idea that a release with this will get deployed at T0 whenever ready (incl. T0 replay), and this should be accompanied by a processing-version change, or something else ?

(cc: ORM, @davidlange6)

Yes, I think so. Once this will be deployed at T0, this should be done together with a processing-version change.

@silviodonato
Copy link
Contributor

enable nano

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e8cfda/45754/summary.html
COMMIT: f822a7f
CMSSW: CMSSW_15_0_X_2025-04-28-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47950/45754/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4012378
  • DQMHistoTests: Total failures: 68
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4012290
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@patinkaew
Copy link
Contributor Author

Hi @silviodonato,
Can you please run test again so the tests also run the Nano workflows?

@silviodonato
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e8cfda/45763/summary.html
COMMIT: f822a7f
CMSSW: CMSSW_15_0_X_2025-04-28-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47950/45763/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4012378
  • DQMHistoTests: Total failures: 65
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4012293
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially removed 82 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 90269
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 90269
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 22 files compared)
  • Checked 113 log files, 65 edm output root files, 23 DQM output files
  • TriggerResults: no differences found

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.001 3.115 3.115 0.000 ( +0.0% ) 6.34 6.68 -5.1% 2.577 2.591
2500.002 3.231 3.231 0.000 ( +0.0% ) 5.69 5.89 -3.5% 2.595 3.057
2500.003 3.172 3.172 0.000 ( +0.0% ) 5.90 6.10 -3.2% 2.608 3.044
2500.011 1.647 1.647 0.000 ( +0.0% ) 10.40 11.35 -8.4% 2.692 2.688
2500.012 2.185 2.185 0.000 ( +0.0% ) 6.00 6.21 -3.3% 2.472 2.884
2500.013 2.002 2.002 0.000 ( +0.0% ) 8.35 8.67 -3.7% 2.458 2.800
2500.021 0.022 0.022 0.000 ( +0.0% ) 1.68 1.85 -9.4% 2.612 2.615
2500.022 0.022 0.022 0.000 ( +0.0% ) 1.60 1.77 -9.8% 2.593 2.616
2500.023 0.022 0.022 0.000 ( +0.0% ) 1.46 1.58 -8.1% 2.629 2.600
2500.024 0.022 0.022 0.000 ( +0.0% ) 1.30 1.42 -8.2% 2.747 2.757
2500.031 0.035 0.035 0.000 ( +0.0% ) 1.47 1.62 -8.9% 2.861 2.860
2500.032 0.036 0.036 0.000 ( +0.0% ) 1.43 1.60 -10.3% 2.863 2.851
2500.033 0.037 0.037 0.000 ( +0.0% ) 1.41 1.54 -8.4% 2.898 2.818
2500.034 0.036 0.036 0.000 ( +0.0% ) 1.44 1.56 -7.9% 2.876 2.876
2500.101 2.872 2.872 0.000 ( +0.0% ) 13.57 15.31 -11.3% 2.657 2.658
2500.111 1.474 1.474 0.000 ( +0.0% ) 28.04 29.62 -5.3% 2.399 2.392
2500.112 1.896 1.896 0.000 ( +0.0% ) 24.01 23.80 +0.9% 2.485 2.362
2500.131 0.771 0.758 0.014 ( +1.8% ) 29.71 33.40 -11.0% 1.654 1.643
2500.201 2.706 2.706 0.000 ( +0.0% ) 12.11 13.66 -11.4% 2.239 2.237
2500.211 1.845 1.845 0.000 ( +0.0% ) 22.01 25.21 -12.7% 2.514 2.503
2500.212 2.243 2.243 0.000 ( +0.0% ) 21.65 21.37 +1.3% 2.607 2.461
2500.221 2.141 2.141 0.000 ( +0.0% ) 13.41 13.38 +0.3% 2.098 2.097
2500.222 3.516 3.516 0.000 ( +0.0% ) 12.53 12.71 -1.4% 2.184 2.168
2500.223 10.328 10.328 0.000 ( +0.0% ) 4.22 4.58 -8.0% 2.353 2.169
2500.224 6.622 6.622 0.000 ( +0.0% ) 1.14 1.23 -7.1% 2.323 2.316
2500.225 6.671 6.671 0.000 ( +0.0% ) 1.08 1.16 -7.2% 2.543 2.512
2500.226 3.210 3.210 0.000 ( +0.0% ) 11.86 12.92 -8.2% 2.178 2.005
2500.227 1.486 1.463 0.023 ( +1.6% ) 14.06 15.81 -11.1% 1.928 1.856
2500.228 4.105 4.075 0.030 ( +0.7% ) 7.89 8.22 -4.1% 2.476 2.410
2500.231 1.516 1.516 0.000 ( +0.0% ) 16.48 21.19 -22.2% 2.433 2.433
2500.232 2.502 2.502 0.000 ( +0.0% ) 17.45 20.07 -13.1% 2.509 2.432
2500.233 5.422 5.422 0.000 ( +0.0% ) 5.77 6.87 -16.0% 2.673 2.671
2500.234 3.928 3.928 0.000 ( +0.0% ) 1.50 1.57 -4.2% 2.627 2.323
2500.235 3.960 3.960 0.000 ( +0.0% ) 1.40 1.46 -4.4% 2.631 2.238
2500.236 2.292 2.292 0.000 ( +0.0% ) 19.79 21.51 -8.0% 2.502 2.501
2500.237 1.101 1.030 0.071 ( +6.9% ) 28.64 29.60 -3.2% 1.639 1.643
2500.238 2.595 2.501 0.094 ( +3.8% ) 14.20 14.20 +0.1% 2.723 2.678
2500.241 9.404 9.404 0.000 ( +0.0% ) 7.09 7.12 -0.5% 1.929 1.929
2500.242 10.331 10.331 0.000 ( +0.0% ) 1.56 1.67 -6.8% 1.724 1.724
2500.243 2.712 2.712 0.000 ( +0.0% ) 15.41 15.57 -1.0% 1.061 1.064
2500.244 486.016 486.016 0.000 ( +0.0% ) 1.13 1.13 +0.3% 1.690 1.689
2500.245 826.413 826.413 0.000 ( +0.0% ) 1.51 1.53 -1.2% 1.679 1.683
2500.251 645.333 645.333 0.000 ( +0.0% ) 1.63 1.67 -2.2% 1.776 1.774
2500.301 0.021 0.021 0.000 ( +0.0% ) 1.68 1.72 -2.6% 3.098 2.863
2500.311 0.036 0.036 0.000 ( +0.0% ) 1.64 1.66 -0.8% 2.885 2.887
2500.901 1.819 1.819 0.000 ( +0.0% ) 31.54 31.76 -0.7% 1.875 1.440
2500.902 1.665 1.665 0.000 ( +0.0% ) 31.73 31.87 -0.4% 1.459 1.448
2500.911 14.345 14.345 0.000 ( +0.0% ) 7.45 6.80 +9.6% 1.092 1.087
2500.912 0.310 0.171 0.139 ( +81.2% ) 2.69 2.94 -8.4% 0.847 0.850
2500.913 0.110 0.110 0.000 ( +0.0% ) 2.61 2.61 +0.1% 0.851 0.847

@silviodonato
Copy link
Contributor

Just a reminder of what is written above: this PR changes the NANO scouting event content, likely we will need to coordinate with T0 and change the processing version number (eg. PromptReco-v2)

@hqucms
Copy link
Contributor

hqucms commented May 2, 2025

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2025

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mmusich
Copy link
Contributor

mmusich commented May 5, 2025

backport of #47934

@silviodonato
Copy link
Contributor

silviodonato commented May 5, 2025

As discussed at the Joint Ops meeting, this PR should go online with the new Era in the next days/weeks to avoid the renaming of all datasets to PromptReco-v2.
We are not aware of any other upcoming PR changing scouting Nano event content

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2025

REMINDER @rappoccio, @sextonkennedy, @mandrenguyen, @antoniovilela: This PR was tested with #47989, please check if they should be merged together

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 068a15f into cms-sw:CMSSW_15_0_X May 13, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants