Skip to content

Conversation

@LinaresToine
Copy link
Contributor

@LinaresToine LinaresToine commented May 13, 2025

PR description:

After validating the output of the new feature developed in #47525, we identified a bug in the logic in which the raw skim outputs are overwritten in the PSet file. I will provide details now:

  • When a stream is mapped to multiple PDs, it has different HLT paths in each output, one for each PD.
  • To make sure that we were selecting events based on the HLT path concerning one of the possible PDs, we create the process attribute in : https://github.com/cms-sw/cmssw/blob/master/Configuration/DataProcessing/python/Repack.py#L84
  • The issue is that this is in a loop for each output, so such process.baseSelection object gets overwritten.
  • The consequence is that when we enable ReserveDMu raw skim for ParkingDoubleMuonLowMass0 and ParkingDoubleMuonLowMass1, we get identical outputs for each raw skim dataset.

The previous behavior can be seen in the PSet section:

process.baseSelection = cms.EDFilter("HLTHighLevel",
    HLTPaths = cms.vstring('Dataset_ParkingDoubleMuonLowMass1'),
    TriggerResultsTag = cms.InputTag("TriggerResults","","HLT"),
    andOr = cms.bool(True),
    eventSetupPathsKey = cms.string(''),
    eventSetupPathsLabel = cms.string(''),
    mightGet = cms.optional.untracked.vstring,
    throw = cms.bool(True)
)

I have placed the bugged PSet and corresponding output in:

/eos/home-c/cmst0/public/RawSkim/bugged

PR validation:

We tested the changes in this PR locally, and now we get relevant outputs. In summary, we see the following:

  • Input file: /eos/cms/store/t0streamer/Data/ParkingDoubleMuonLowMass0/000/391/950/run391950_ls0003_streamParkingDoubleMuonLowMass0_StorageManager.dat --> 321 events
  • ParkingDoubleMuonLowMass0_ReserveDMu_RAW --> 56 events
  • ParkingDoubleMuonLowMass1_ReserveDMu_RAW --> 32 events

I have placed the new PSet and corresponding output in:

/eos/home-c/cmst0/public/RawSkim/fixed

This PR is a backport to CMSSW_15_0_X for current datataking

@cmsbuild
Copy link
Contributor

cmsbuild commented May 13, 2025

A new Pull Request was created by @LinaresToine for CMSSW_15_0_X.

It involves the following packages:

  • Configuration/DataProcessing (operations)

@antoniovilela, @cmsbuild, @davidlange6, @fabiocos, @mandrenguyen, @rappoccio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @missirol this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 13, 2025

cms-bot internal usage

@LinaresToine LinaresToine changed the title fix-Repack-RawSkim-Logic Backport-CMSSW_15_0_X-fix-Repack-RawSkim-Logic May 13, 2025
@mandrenguyen
Copy link
Contributor

backport of #48069

@mandrenguyen
Copy link
Contributor

please test workflow 141.114

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d7d95a/46102/summary.html
COMMIT: 368459b
CMSSW: CMSSW_15_0_X_2025-05-13-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48070/46102/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d7d95a/46102/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d7d95a/46102/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 9 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 4062644
  • DQMHistoTests: Total failures: 1746
  • DQMHistoTests: Total nulls: 999
  • DQMHistoTests: Total successes: 4059879
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -6492.132 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 145.014,... ): -654.212 KiB HLT/BTV
  • DQMHistoSizes: changed ( 16834.0,... ): -629.218 KiB HLT/BTV
  • Checked 222 log files, 193 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 5e696b5 into cms-sw:CMSSW_15_0_X May 14, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants