Skip to content

Conversation

@patinkaew
Copy link
Contributor

@patinkaew patinkaew commented Apr 23, 2025

PR description:

This PR supersedes cms-sw/cmssw#47302 for era modifier part. Hence, cms-sw/cmssw#47302 is now completely superseded by this PR and cms-sw/cmssw#47739.

This PR introduces era modifiers to handle changes in event content in scouting format for 2022-24. Addressed changes are as follows:

2023:

  • Add additional track variables to the Run 3 scouting electron collection for low pT electrons (cms-sw/cmssw#41025)

2024:

Compared to the already-integrated ScoutingNano content, this adds:

2022:

  • add missing attributes in ScoutingElectron (charge, d0, dz)

2023:

  • replace charge, d0, dz added in 2022 with ScoutingElectron's best track parameters introduced in cms-sw/cmssw#41025. Best track is selected by the plugin integrated in cms-sw/cmssw#47836.

2024:

  • add off-diagonal entries of the vertex fir covariance matrix from cms-sw/cmssw#43758 for ScoutingPrimaryVertex, ScoutingMuonNoVtxDisplacedVertex, and ScoutingMuonVtxDisplacedVertex as they are from the same Run3ScoutingVertex format.
  • add ScoutingElectron's best track parameters introduced in cms-sw/cmssw#43744.
  • add other variables introduced in cms-sw/cmssw#43744 for ScoutingElectron and ScoutingPhoton.

In addition, for all years,

  • add rechitZeroSuppression for ScoutingElectron and ScoutingPhoton.
  • add vtxIndx and HitPattern information for ScoutingMuon (with SimpleCollectionFlatTableProducer added in cms-sw/cmssw#46702.

Also, this introduce customisation command for cmsDriver.py:

--customise PhysicsTools/NanoAOD/custom_run3scouting_cff.addScoutingElectronTrack

This will include all Scouting Electron Tracks for best track selection optimisation. This customisation mainly targets private production, not central production.

PR validation:

Pass all tests from scram b runtests use-ibeos.
Pass all ScoutingNano-related relval_nano workflows from

runTheMatrix.py --ibeos -l 2500.131,2500.227,2500.228,2500.237,2500.238

In addition, several cmsDriver.py commands have been tested on data and MC samples documented with the same commands used in cms-sw/cmssw#47739.
In brief, concerning data:

  • @Scout works for ScoutingPFRun3 2022-24
  • @ScoutMonitor works for ScoutingPFMonitor 2022-24
  • @ScoutFromMini works for ScoutingPFMonitor 2024 (Scouting objects are in MiniAOD starting in Prompt 2024)
  • @Prompt+@ScoutMonitor works for ScoutingPFMonitor 2023. Input 2022 fails because of Tau.
  • @Prompt+@ScoutFromMiniworks for ScoutingPFMonitor 2024 (Scouting objects are in MiniAOD starting in Prompt 2024)

Relevant test results (python config, root, event content, size report, log) are included in [1]. Summary of size report is in [2] with percentage increase compared to already-integrated ScoutingNano before Scouting GloParT is added cms-sw/cmssw#47801. This is, the increase in size is a combination of Scouting GloParT and attributes added in this PR. For data configuration above, the increase is <7%.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is not a backport, but a backport to 15_0_X will follow as this is necessary for ScoutingNano reprocessing for 2022-24 data (planned with 15_0_X release cycles) and 2025 data-taking.

[1] https://cernbox.cern.ch/s/pLV0RmwJgUba33c
[2] https://docs.google.com/spreadsheets/d/1FOW-bGCLbNf4zcaZ9zMDca6FiRWwVBNnizFvaGUQ64Q/edit?usp=sharing

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 23, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @patinkaew for master.

It involves the following packages:

  • Configuration/Eras (operations)
  • PhysicsTools/NanoAOD (xpog)

@antoniovilela, @cmsbuild, @davidlange6, @fabiocos, @ftorrresd, @hqucms, @mandrenguyen, @rappoccio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @gpetruc, @makortel, @missirol this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@patinkaew
Copy link
Contributor Author

Tagging Scouting conveners: @silviodonato @elfontan.

@ftorrresd
Copy link
Contributor

enable nano

@ftorrresd
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-508c45/45687/summary.html
COMMIT: ca8bea7
CMSSW: CMSSW_15_1_X_2025-04-23-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47934/45687/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

NANO Comparison Summary

Summary:

  • You potentially added 374 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 90509
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 90509
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 22 files compared)
  • Checked 113 log files, 65 edm output root files, 23 DQM output files
  • TriggerResults: no differences found

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.001 3.115 3.115 0.000 ( +0.0% ) 6.29 6.32 -0.5% 2.636 2.631
2500.002 3.231 3.231 0.000 ( +0.0% ) 5.61 5.67 -1.1% 3.092 3.099
2500.003 3.172 3.172 0.000 ( +0.0% ) 5.86 5.73 +2.3% 3.093 3.082
2500.011 1.647 1.647 0.000 ( +0.0% ) 10.21 10.52 -2.9% 2.734 2.743
2500.012 2.185 2.185 0.000 ( +0.0% ) 5.91 6.00 -1.5% 2.932 2.921
2500.013 2.002 2.002 0.000 ( +0.0% ) 8.09 8.38 -3.5% 2.843 2.843
2500.021 0.022 0.022 0.000 ( +0.0% ) 1.72 1.45 +18.6% 2.986 2.976
2500.022 0.022 0.022 0.000 ( +0.0% ) 1.63 1.58 +3.0% 2.987 2.975
2500.023 0.022 0.022 0.000 ( +0.0% ) 1.43 1.21 +18.0% 2.706 2.702
2500.024 0.022 0.022 0.000 ( +0.0% ) 1.30 1.27 +2.1% 3.099 3.106
2500.031 0.035 0.035 0.000 ( +0.0% ) 1.50 1.38 +8.4% 2.935 2.939
2500.032 0.036 0.036 0.000 ( +0.0% ) 1.50 1.35 +11.2% 2.932 2.923
2500.033 0.037 0.037 0.000 ( +0.0% ) 1.41 1.37 +2.6% 2.981 2.974
2500.034 0.036 0.036 0.000 ( +0.0% ) 1.44 1.20 +19.8% 2.951 2.955
2500.101 2.872 2.872 0.000 ( +0.0% ) 13.98 14.08 -0.7% 2.744 2.736
2500.111 1.474 1.474 0.000 ( +0.0% ) 27.15 25.46 +6.7% 2.424 2.443
2500.112 1.896 1.896 0.000 ( +0.0% ) 22.51 22.60 -0.4% 2.516 2.515
2500.131 0.771 0.758 0.014 ( +1.8% ) 31.22 31.98 -2.4% 1.702 1.692
2500.201 2.706 2.706 0.000 ( +0.0% ) 12.24 12.69 -3.6% 2.268 2.271
2500.211 1.845 1.845 0.000 ( +0.0% ) 22.58 23.63 -4.4% 2.546 2.541
2500.212 2.243 2.243 0.000 ( +0.0% ) 19.57 19.84 -1.4% 2.645 2.642
2500.221 2.141 2.141 0.000 ( +0.0% ) 12.45 12.57 -1.0% 2.135 2.131
2500.222 3.516 3.516 0.000 ( +0.0% ) 11.54 11.90 -3.0% 2.227 2.224
2500.223 10.328 10.328 0.000 ( +0.0% ) 4.25 4.30 -1.2% 2.395 2.393
2500.224 6.622 6.622 0.000 ( +0.0% ) 1.11 1.18 -6.3% 2.362 2.360
2500.225 6.671 6.671 0.000 ( +0.0% ) 1.06 1.10 -4.1% 2.565 2.571
2500.226 3.210 3.210 0.000 ( +0.0% ) 12.65 12.58 +0.5% 2.216 2.223
2500.227 1.486 1.463 0.023 ( +1.6% ) 14.11 15.02 -6.0% 1.967 1.962
2500.228 4.105 4.075 0.030 ( +0.7% ) 7.84 8.00 -1.9% 2.510 2.509
2500.231 1.516 1.516 0.000 ( +0.0% ) 19.26 20.09 -4.2% 2.465 2.463
2500.232 2.502 2.502 0.000 ( +0.0% ) 18.73 18.95 -1.2% 2.546 2.544
2500.233 5.422 5.422 0.000 ( +0.0% ) 6.23 6.55 -4.9% 2.715 2.706
2500.234 3.928 3.928 0.000 ( +0.0% ) 1.42 1.50 -5.6% 2.644 2.650
2500.235 3.960 3.960 0.000 ( +0.0% ) 1.35 1.43 -5.2% 2.866 2.859
2500.236 2.292 2.292 0.000 ( +0.0% ) 16.00 20.71 -22.8% 2.542 2.540
2500.237 1.101 1.030 0.071 ( +6.9% ) 26.47 28.09 -5.8% 1.686 1.673
2500.238 2.595 2.501 0.094 ( +3.8% ) 13.76 13.71 +0.4% 2.751 2.745
2500.241 9.404 9.404 0.000 ( +0.0% ) 3.89 6.74 -42.3% 1.965 1.961
2500.242 10.331 10.331 0.000 ( +0.0% ) 1.56 1.54 +1.1% 1.761 1.760
2500.243 2.712 2.712 0.000 ( +0.0% ) 14.08 14.28 -1.4% 1.096 1.095
2500.244 486.016 486.016 0.000 ( +0.0% ) 1.06 1.12 -5.1% 1.730 1.725
2500.245 826.413 826.413 0.000 ( +0.0% ) 1.41 1.51 -6.7% 1.715 1.704
2500.251 645.333 645.333 0.000 ( +0.0% ) 1.53 1.61 -4.9% 1.817 1.816
2500.301 0.021 0.021 0.000 ( +0.0% ) 1.67 1.63 +2.8% 3.143 3.128
2500.311 0.036 0.036 0.000 ( +0.0% ) 1.63 1.58 +2.9% 2.932 2.927
2500.901 1.819 1.819 0.000 ( +0.0% ) 31.57 32.34 -2.4% 1.915 1.917
2500.902 1.665 1.665 0.000 ( +0.0% ) 31.51 31.65 -0.4% 1.496 1.496
2500.911 14.345 14.345 0.000 ( +0.0% ) 8.16 7.27 +12.3% 1.130 1.124
2500.912 0.171 0.240 -0.069 ( -28.9% ) 2.65 2.81 -5.4% 0.878 0.880
2500.913 0.110 0.110 0.000 ( +0.0% ) 2.53 2.50 +1.1% 0.884 0.882

@patinkaew
Copy link
Contributor Author

Dear @ftorrresd,

Do you have any further comments on this?

@hqucms
Copy link
Contributor

hqucms commented May 2, 2025

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 50259f7 into cms-sw:master May 2, 2025
13 checks passed
cmsbuild added a commit that referenced this pull request May 13, 2025
…r_15_0_X_IB

[15_0_X] Backport of #47934 (ScoutingNano Event Content Changes for 2022-25)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants