Skip to content

Conversation

@mmusich
Copy link
Contributor

@mmusich mmusich commented Apr 3, 2025

backport of #47782

PR description:

This PR is meant to fix issue #47780.
The crash is due to PR #47664.
In cosmic data-taking there might be events without any HLT pixel vertex collection in input for the monitoring module, but it's unnecessary to check the validity of the handle, as anyway the logic of the program repurposes the beam-spot for the vertex compatibility checks.

PR validation:

Checked that the recipe at #47780 (comment):

cmsrel CMSSW_15_0_3
cd CMSSW_15_0_3/src
cmsenv
cp /afs/cern.ch/work/f/fbrivio/public/ORM_April_2025/crash_Run390254/PSet.pkl .
cp /afs/cern.ch/work/f/fbrivio/public/ORM_April_2025/crash_Run390254/PSet.py .
cmsRun PSet.py

runs when used in conjunction of this branch.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport to #47782 for 2025 data-taking operations.

@mmusich mmusich changed the title [15.0.X] fix TrackToTrackComparisonHists logic for comsics [15.0.X] fix TrackToTrackComparisonHists logic for cosmics Apr 3, 2025
@cmsbuild cmsbuild added this to the CMSSW_15_0_X milestone Apr 3, 2025
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2025

A new Pull Request was created by @mmusich for CMSSW_15_0_X.

It involves the following packages:

  • DQM/TrackingMonitorSource (dqm)

@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks.
@VinInn, @VourMa, @arossi83, @fioriNTU, @idebruyn, @jandrea, @mmusich, @mtosi, @richa2710, @sroychow, @threus this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2025

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Apr 3, 2025

type bug-fix

@mmusich
Copy link
Contributor Author

mmusich commented Apr 3, 2025

test parameters:

  • workflow = 7.25

@mmusich
Copy link
Contributor Author

mmusich commented Apr 3, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2025

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8730d3/45375/summary.html
COMMIT: 6ef7ef2
CMSSW: CMSSW_15_0_X_2025-04-03-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47783/45375/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@francescobrivio
Copy link
Contributor

@cms-sw/dqm-l2 a kind reminder of this PR

@antoniovagnerini
Copy link

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2025

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@francescobrivio
Copy link
Contributor

urgent

  • To keep this in the loop for the next 15_0_X for data taking FYI @cms-sw/orp-l2
  • FYI @mpresill

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ba987ce into cms-sw:CMSSW_15_0_X Apr 7, 2025
10 checks passed
@mmusich mmusich deleted the mm_fix_TrackToTrackComparisonHists_logic_15_0_X branch April 7, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants