-
Notifications
You must be signed in to change notification settings - Fork 4.6k
[15.0.X] fix TrackToTrackComparisonHists logic for cosmics
#47783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0.X] fix TrackToTrackComparisonHists logic for cosmics
#47783
Conversation
TrackToTrackComparisonHists logic for comsicsTrackToTrackComparisonHists logic for cosmics
|
A new Pull Request was created by @mmusich for CMSSW_15_0_X. It involves the following packages:
@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
|
cms-bot internal usage |
|
type bug-fix |
|
test parameters:
|
|
@cmsbuild, please test |
|
+1 Size: This PR adds an extra 24KB to repository Comparison SummarySummary:
|
|
@cms-sw/dqm-l2 a kind reminder of this PR |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
|
urgent
|
|
+1 |
backport of #47782
PR description:
This PR is meant to fix issue #47780.
The crash is due to PR #47664.
In cosmic data-taking there might be events without any HLT pixel vertex collection in input for the monitoring module, but it's unnecessary to check the validity of the handle, as anyway the logic of the program repurposes the beam-spot for the vertex compatibility checks.
PR validation:
Checked that the recipe at #47780 (comment):
runs when used in conjunction of this branch.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Verbatim backport to #47782 for 2025 data-taking operations.