-
Notifications
You must be signed in to change notification settings - Fork 4.6k
fix TrackToTrackComparisonHists logic for cosmics
#47782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix TrackToTrackComparisonHists logic for cosmics
#47782
Conversation
|
type bug-fix |
|
cms-bot internal usage |
TrackToTrackComparisonHists logic for comsicsTrackToTrackComparisonHists logic for cosmics
|
type bug-fix |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47782/44366 |
|
A new Pull Request was created by @mmusich for master. It involves the following packages:
@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
test parameters:
|
|
@cmsbuild, please test |
|
@mmusich I tested this PR and I can confirm it fixes the crash. Thanks a lot! |
|
urgent
|
|
+1 Size: This PR adds an extra 24KB to repository Comparison SummarySummary:
|
|
@cms-sw/dqm-l2 a kind reminder of this PR (and its backport) |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
resolves #47780
PR description:
This PR is meant to fix issue #47780.
The crash is due to PR #47663.
In cosmic data-taking there might be events without any HLT pixel vertex collection in input for the monitoring module, but it's unnecessary to check the validity of the handle, as anyway the logic of the program repurposes the beam-spot for the vertex compatibility checks.
PR validation:
Checked that the recipe at #47780 (comment):
runs when used in conjunction of this branch.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, but will be backported to CMSSW_15_0_X for 2025 data-taking operations.