TICLv5 - Fix TracksterLinkingbySkeletons Logic

[waredjeb]

This PR introduces a fix in the logic of the Skeletons algorithm for the Linking step in TICLv5.
It also introduces a small fix for comparing two floating points in the SimTrackster Producer.

This PR should be tested enabling some TICLv5 workflows:

• 29688.203 SinglePiPt25Eta1p7_2p7_2026D110_GenSimHLBeamSpot+DigiTrigger_2026D110+RecoGlobal_ticl_v5_2026D110+HARVESTGlobal_ticl_v5_2026D110+ALCAPhase2_2026D110
• 29888.203 SinglePiPt25Eta1p7_2p7_2026D110PU_GenSimHLBeamSpot+DigiTriggerPU_2026D110PU+RecoGlobalPU_ticl_v5_2026D110PU+HARVESTGlobalPU_ticl_v5_2026D110PU

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45215/40570

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoHGCal/TICL/plugins/SimTrackstersProducer.cc modified in PR(s): Move commons.h to DataFormats/HGCalReco to break cyclic dep #45208

[cmsbuild]

A new Pull Request was created by @waredjeb for master.

It involves the following packages:

• RecoHGCal/TICL (reconstruction, upgrade)

@jfernan2, @subirsarkar, @cmsbuild, @mandrenguyen, @srimanob can you please review it and eventually sign? Thanks.
@youyingli, @sameasy, @forthommel, @lecriste, @sobhatta, @missirol, @rovere, @apsallid, @hatakeyamak, @felicepantaleo this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[felicepantaleo]

test parameters:

• workflow = 25288.203,25488.203

[felicepantaleo]

@cmsbuild please test

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5e74bc/39870/summary.html
COMMIT: 68810a2
CMSSW: CMSSW_14_1_X_2024-06-13-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45215/39870/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

ValueError: Undefined workflows: 25288.203, 25488.203

[felicepantaleo]

test parameters:

• workflow_opts= -w upgrade
• workflow = 25288.203,25488.203

[felicepantaleo]

@cmsbuild please test

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5e74bc/39873/summary.html
COMMIT: 68810a2
CMSSW: CMSSW_14_1_X_2024-06-13-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45215/39873/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 25488.203

----- Begin Fatal Exception 13-Jun-2024 18:52:27 CEST-----------------------
An exception of category 'NoSecondaryFiles' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
RootEmbeddedFileSequence no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

[felicepantaleo]

test parameters:

• workflow_opts= -w upgrade
• workflow = 29888.203,29688.203

[felicepantaleo]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5e74bc/39890/summary.html
COMMIT: 68810a2
CMSSW: CMSSW_14_1_X_2024-06-13-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45215/39890/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3545656
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3545628
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 211 log files, 173 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1