Avoid using 'module' identifier - is a keyword in C++20

[iarspider]

PR description:

Fixes these warnings:

  src/RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelRawToClusterGPUKernel.cu(362): warning #3189-D: "module" is parsed as an identifier rather than a keyword because the tokens that follow it do not match those of a preprocessor directive
           module = (rawId >> pixelgpudetails::moduleStartBit) & pixelgpudetails::moduleMask;
          ^

Remark: The warnings can be suppressed with "-diag-suppress <warning-number>"

  src/RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelRawToClusterGPUKernel.cu(362): warning #3189-D: "module" is parsed as an identifier rather than a keyword because the tokens that follow it do not match those of a preprocessor directive
           module = (rawId >> pixelgpudetails::moduleStartBit) & pixelgpudetails::moduleMask;
          ^

Remark: The warnings can be suppressed with "-diag-suppress <warning-number>"

  src/RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelRawToClusterGPUKernel.cu(362): warning #3189-D: "module" is parsed as an identifier rather than a keyword because the tokens that follow it do not match those of a preprocessor directive
           module = (rawId >> pixelgpudetails::moduleStartBit) & pixelgpudetails::moduleMask;
          ^

Remark: The warnings can be suppressed with "-diag-suppress <warning-number>"

  src/RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelRawToClusterGPUKernel.cu(362): warning #3189-D: "module" is parsed as an identifier rather than a keyword because the tokens that follow it do not match those of a preprocessor directive
           module = (rawId >> pixelgpudetails::moduleStartBit) & pixelgpudetails::moduleMask;
          ^

Remark: The warnings can be suppressed with "-diag-suppress <warning-number>"

  src/RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelRawToClusterGPUKernel.cu(362): warning #3189-D: "module" is parsed as an identifier rather than a keyword because the tokens that follow it do not match those of a preprocessor directive
           module = (rawId >> pixelgpudetails::moduleStartBit) & pixelgpudetails::moduleMask;
          ^

Remark: The warnings can be suppressed with "-diag-suppress <warning-number>"

  src/RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelRawToClusterGPUKernel.cu(362): warning #3189-D: "module" is parsed as an identifier rather than a keyword because the tokens that follow it do not match those of a preprocessor directive
           module = (rawId >> pixelgpudetails::moduleStartBit) & pixelgpudetails::moduleMask;
          ^

Remark: The warnings can be suppressed with "-diag-suppress <warning-number>"

PR validation:

Bot tests

[cmsbuild]

cms-bot internal usage

[iarspider]

please test for CMSSW_14_1_CPP20_X

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45252/40634

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelRawToClusterGPUKernel.cu modified in PR(s): [DO NOT MERGE] remove duplicate pixels #37359

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• RecoLocalTracker/SiPixelClusterizer (reconstruction)

@mandrenguyen, @jfernan2 can you please review it and eventually sign? Thanks.
@missirol, @mroguljic, @VourMa, @VinInn, @rovere, @dkotlins, @gpetruc, @GiacomoSguazzoni, @tsusa, @ferencek, @tvami, @threus, @mtosi, @mmusich, @JanFSchulte, @felicepantaleo this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[iarspider]

please test for CMSSW_14_1_CPP20_X

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45252/40638

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelRawToClusterGPUKernel.cu modified in PR(s): [DO NOT MERGE] remove duplicate pixels #37359

[cmsbuild]

Pull request #45252 was updated. @jfernan2, @mandrenguyen can you please check and sign again.

[fwyzard]

assign heterogeneous

[cmsbuild]

New categories assigned: heterogeneous

@fwyzard,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks

[fwyzard]

I don't see GCC and clang complain about this ?

https://godbolt.org/z/h3cxxavn9

[iarspider]

@fwyzard this warning is from nvcc, not gcc/clang.

[fwyzard]

I see.

Since gcc and clang do not warn about it, I would prefer to simply silence the warning in nvcc.

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eba795/39951/summary.html
COMMIT: 643baa7
CMSSW: CMSSW_14_1_CPP20_X_2024-06-17-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45252/39951/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @fwyzard Add a serialisation test #45218
• @fwyzard Introduce kInvalidDenseId for ECAL and HCAL #45238
• @bsunanda Phase2-gex178 Update the cfi's for HFNose in testing some beyond Phase2 scenarios #45229
• @CMSTrackingPOG Introduce reco::Track::recHitsOk() and use it to remove try/catch pattern in SingleLongTrackProducer  #45213
• @bsunanda Run3-alca247C Modify CalibFitPlots to provide multiple depth plots to individual plots with single depths #45234
• @fabiocos MTD geometry: fix BTL numbering scheme for scenario v3, input by Geant4, move unit tests to D110 scenario #45211
• @smuzaffar Remove unused variable, fixes cuda warnings #45222
• @perrotta Move online (frozen) GTs to 141X and add the dedxCalibration record for HI #45220
• @mmusich introduce const variant of XGBooster::predict and use it in PhotonXGBoostEstimator #45232
• @waredjeb TICLv5 - Fix TracksterLinkingbySkeletons Logic #45215

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eba795/39951/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eba795/39951/git-merge-result

Unit Tests

I found 5 errors in the following unit tests:

---> test GeometryMTDGeometryBuilderTestDriver had ERRORS
---> test GeometryMTDNumberingBuilderTestDriver had ERRORS
---> test GeometryMTDCommonDataTestDriver had ERRORS
and more ...

Comparison Summary

Summary:

• You potentially added 2597 lines to the logs
• Reco comparison results: 118 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3345018
• DQMHistoTests: Total failures: 902
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3344096
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[fwyzard]

-heterogeneous

I'd rather silence the warning in nvcc.

[iarspider]

@cmsbuild please close